Skip to content

An AI-powered search engine with a generative UI

refactor: extract feedback database operations into action layer

Yoshiki Miuraedda569a2483
diff --git a/app/api/feedback/route.ts b/app/api/feedback/route.ts
index 5d6c9d3f..909cdc4d 100644
--- a/app/api/feedback/route.ts
+++ b/app/api/feedback/route.ts
@@ -1,9 +1,6 @@
-import { eq } from 'drizzle-orm'
import { Langfuse } from 'langfuse'
-import { chatCache } from '@/lib/cache/memory-cache'
-import { db } from '@/lib/db'
-import { messages } from '@/lib/db/schema'
+import { updateMessageFeedback } from '@/lib/actions/feedback'
import { isTracingEnabled } from '@/lib/utils/telemetry'
export async function POST(req: Request) {
@@ -46,37 +43,12 @@ export async function POST(req: Request) {
// Flush to ensure the score is sent
await langfuse.flushAsync()
- // Update the message metadata with the feedback score
+ // Update the message metadata with the feedback score using the action
if (messageId) {
- try {
- // First get the current message to preserve existing metadata and get chatId
- const [currentMessage] = await db
- .select({
- metadata: messages.metadata,
- chatId: messages.chatId
- })
- .from(messages)
- .where(eq(messages.id, messageId))
- .limit(1)
-
- // Merge the feedback score with existing metadata
- const updatedMetadata = {
- ...(currentMessage?.metadata || {}),
- feedbackScore: score
- }
-
- // Update the message with the new metadata
- await db
- .update(messages)
- .set({ metadata: updatedMetadata })
- .where(eq(messages.id, messageId))
-
- // Invalidate cache for this chat to ensure fresh data is loaded
- if (currentMessage?.chatId) {
- chatCache.deletePattern(`${currentMessage.chatId}-`)
- }
- } catch (dbError) {
- console.error('Error updating message metadata:', dbError)
+ const result = await updateMessageFeedback(messageId, score)
+
+ if (!result.success) {
+ console.error('Error updating message feedback:', result.error)
// Continue even if database update fails
}
}
diff --git a/lib/actions/feedback.ts b/lib/actions/feedback.ts
new file mode 100644
index 00000000..7bf7c2ea
--- /dev/null
+++ b/lib/actions/feedback.ts
@@ -0,0 +1,87 @@
+'use server'
+
+import { eq } from 'drizzle-orm'
+import { Langfuse } from 'langfuse'
+
+import { chatCache } from '@/lib/cache/memory-cache'
+import { db } from '@/lib/db'
+import { messages } from '@/lib/db/schema'
+import { isTracingEnabled } from '@/lib/utils/telemetry'
+
+export async function updateMessageFeedback(
+ messageId: string,
+ score: number
+): Promise<{ success: boolean; error?: string }> {
+ try {
+ // Get the current message to preserve existing metadata and get chatId
+ const [currentMessage] = await db
+ .select({
+ metadata: messages.metadata,
+ chatId: messages.chatId
+ })
+ .from(messages)
+ .where(eq(messages.id, messageId))
+ .limit(1)
+
+ if (!currentMessage) {
+ return { success: false, error: 'Message not found' }
+ }
+
+ // Merge the feedback score with existing metadata
+ const updatedMetadata = {
+ ...(currentMessage.metadata || {}),
+ feedbackScore: score
+ }
+
+ // Update the message with the new feedback score
+ await db
+ .update(messages)
+ .set({ metadata: updatedMetadata })
+ .where(eq(messages.id, messageId))
+
+ // Send feedback to Langfuse if trace ID exists and tracing is enabled
+ const traceId = (currentMessage.metadata as any)?.traceId
+ if (traceId && isTracingEnabled()) {
+ const langfuse = new Langfuse()
+ langfuse.score({
+ traceId,
+ name: 'user-feedback',
+ value: score,
+ comment: score === 1 ? 'Thumbs up' : 'Thumbs down'
+ })
+ await langfuse.flushAsync()
+ }
+
+ // Invalidate cache for this chat to ensure fresh data is loaded
+ if (currentMessage.chatId) {
+ chatCache.deletePattern(`${currentMessage.chatId}-`)
+ }
+
+ return { success: true }
+ } catch (error) {
+ console.error('Error updating message feedback:', error)
+ return {
+ success: false,
+ error: error instanceof Error ? error.message : 'Failed to update feedback'
+ }
+ }
+}
+
+export async function getMessageFeedback(messageId: string): Promise<number | null> {
+ try {
+ const [message] = await db
+ .select({ metadata: messages.metadata })
+ .from(messages)
+ .where(eq(messages.id, messageId))
+ .limit(1)
+
+ if (!message) {
+ return null
+ }
+
+ return (message.metadata as any)?.feedbackScore || null
+ } catch (error) {
+ console.error('Error getting message feedback:', error)
+ return null
+ }
+}
\ No newline at end of file