Skip to content

Visualize Your Ideas With Code

fix: improper cloning of custom fields (#925)

Shmish4981da74e7b2
diff --git a/packages/core/src/meta/ObjectMetaField.ts b/packages/core/src/meta/ObjectMetaField.ts
index 44822970..c483487e 100644
--- a/packages/core/src/meta/ObjectMetaField.ts
+++ b/packages/core/src/meta/ObjectMetaField.ts
@@ -72,16 +72,28 @@ class ObjectMetaFieldInternal<
}
public override serialize(): ValueOf<T> {
- return this.transform('serialize');
+ return {
+ ...this.transform('serialize'),
+ ...this.customFields,
+ };
}
public override clone(): this {
- return new (<any>this.constructor)(this.name, this.transform('clone'));
+ const cloned = new (<any>this.constructor)(
+ this.name,
+ this.transform('clone'),
+ );
+ cloned.set(structuredClone(this.customFields));
+
+ return cloned;
}
protected handleChange = () => {
if (this.ignoreChange) return;
- this.value.current = this.transform('get');
+ this.value.current = {
+ ...this.transform('get'),
+ ...this.customFields,
+ };
};
protected transform<TKey extends CallableKeys<MetaField<any>>>(
@@ -91,10 +103,7 @@ class ObjectMetaFieldInternal<
Array.from(this.fields, ([name, field]) => [name, field[fn]()]),
) as TransformationOf<T, TKey>;
- return {
- ...transformed,
- ...this.customFields,
- };
+ return transformed;
}
}