Skip to content

Visualize Your Ideas With Code

fix(2d): minor fixes (#915)

Jacob63cfc9e033f2
diff --git a/packages/2d/src/editor/NodeInspectorConfig.tsx b/packages/2d/src/editor/NodeInspectorConfig.tsx
index b2d64b3b..c71daf0a 100644
--- a/packages/2d/src/editor/NodeInspectorConfig.tsx
+++ b/packages/2d/src/editor/NodeInspectorConfig.tsx
@@ -11,7 +11,7 @@ import {
useApplication,
} from '@motion-canvas/ui';
import {useComputed} from '@preact/signals';
-import {usePluginState} from './Provider';
+import {NodeInspectorKey, usePluginState} from './Provider';
function Component() {
const {inspection} = useApplication();
@@ -70,8 +70,6 @@ function Component() {
);
}
-export const NodeInspectorKey = '@motion-canvas/2d/node-inspector';
-
export const NodeInspectorConfig: PluginInspectorConfig = {
key: NodeInspectorKey,
component: Component,
diff --git a/packages/2d/src/editor/Provider.tsx b/packages/2d/src/editor/Provider.tsx
index 5bfff66a..e3e8c0d4 100644
--- a/packages/2d/src/editor/Provider.tsx
+++ b/packages/2d/src/editor/Provider.tsx
@@ -10,7 +10,6 @@ import {
} from '@preact/signals';
import {ComponentChildren, createContext} from 'preact';
import {useContext, useMemo} from 'preact/hooks';
-import {NodeInspectorKey} from './NodeInspectorConfig';
export interface PluginState {
selectedKey: Signal<string | null>;
@@ -23,6 +22,8 @@ export interface PluginState {
const PluginContext = createContext<PluginState | null>(null);
+export const NodeInspectorKey = '@motion-canvas/2d/node-inspector';
+
export function usePluginState() {
return useContext(PluginContext)!;
}
diff --git a/packages/2d/src/editor/tree/NodeElement.tsx b/packages/2d/src/editor/tree/NodeElement.tsx
index 98293293..ed4b483b 100644
--- a/packages/2d/src/editor/tree/NodeElement.tsx
+++ b/packages/2d/src/editor/tree/NodeElement.tsx
@@ -22,7 +22,7 @@ export function NodeElement({node, depth = 0}: NodeElementProps) {
const children = useComputed(() => {
afterRender.value;
- return node.children();
+ return nodeSignal.value.children();
});
useSignalEffect(() => {
diff --git a/packages/2d/src/lib/components/Img.ts b/packages/2d/src/lib/components/Img.ts
index 01e5e16f..633806a3 100644
--- a/packages/2d/src/lib/components/Img.ts
+++ b/packages/2d/src/lib/components/Img.ts
@@ -73,8 +73,8 @@ export class Img extends Rect {
if (import.meta.hot) {
import.meta.hot.on('motion-canvas:assets', ({urls}) => {
for (const url of urls) {
- if (this.pool[url]) {
- delete this.pool[url];
+ if (Img.pool[url]) {
+ delete Img.pool[url];
}
}
});