Browser-based graphical shell and control plane for a Linux server you own — real terminal, file manager, live metrics and BYOK AI in one mobile-first workspace. Next.js 16 · React 19 · node-pty · Tailwind v4 · shadcn/ui. Public alpha, self-hosted.
TypeScript browser-shellcontrol-planefile-managerhomelabmobile-firstnextjsptyreactself-hostedserver-managementshadcn-uisysadmintailwindcssterminaltypescriptvpsweb-desktopweb-terminal
fix(integrations): keyboard-operable confirmation, visible transfer errors, and wrapping status
Abdurrahman Fakhrul2b21616a6811
diff --git a/lib/infra/connection-ui-layout.test.ts b/lib/infra/connection-ui-layout.test.tsindex 68ef1e32..78ed18c7 100644--- a/lib/infra/connection-ui-layout.test.ts+++ b/lib/infra/connection-ui-layout.test.ts@@ -156,3 +156,25 @@ it("explains why hosted authorization is disabled when already linked (Poin 3, Rexpect(CONNECTION_MANAGER_SCRIPT).toContain('authorize.title="Already linked to "+c.external.connectedAccountId');expect(CONNECTION_MANAGER_SCRIPT).toContain('"Already linked to "+c.external.connectedAccountId');});++it("makes confirmation dialog accessible and keyboard-operable with Escape, alertdialog role, and focus restoration (R-32, R-26)", () => {+ // 1. role="alertdialog", aria-modal="true", and aria-labelledby pointing to title+ expect(CONNECTION_MANAGER_SCRIPT).toContain('box.setAttribute("role","alertdialog")');+ expect(CONNECTION_MANAGER_SCRIPT).toContain('box.setAttribute("aria-modal","true")');+ expect(CONNECTION_MANAGER_SCRIPT).toContain('box.setAttribute("aria-labelledby",titleId)');++ // 2. Escape key handler cancels dialog+ expect(CONNECTION_MANAGER_SCRIPT).toMatch(/box\.addEventListener\("keydown",\s*event\s*=>\s*\{\s*if\s*\(event\.key\s*===\s*"Escape"\)\s*\{\s*event\.preventDefault\(\);\s*cancel\(\);/);++ // 3. Focus saved before replaceChildren and restored on cancel+ expect(CONNECTION_MANAGER_SCRIPT).toMatch(/trigger\s*=\s*document\.activeElement/);+ expect(CONNECTION_MANAGER_SCRIPT).toMatch(/trigger\.focus\(\)/);++ // 4. Cancel button is focused on open (safe default for destructive actions)+ expect(CONNECTION_MANAGER_SCRIPT).toMatch(/cancelBtn\.focus\(\)/);++ // 5. Destructive confirmation button displays descriptive action text instead of generic "Confirm"+ expect(CONNECTION_MANAGER_SCRIPT).toMatch(/confirmBtn\s*=\s*b\(title,/);+ expect(CONNECTION_MANAGER_SCRIPT).not.toMatch(/b\("Confirm",/);+});+diff --git a/lib/infra/connection-ui-style.ts b/lib/infra/connection-ui-style.tsindex ac62ada1..c370d77a 100644--- a/lib/infra/connection-ui-style.ts+++ b/lib/infra/connection-ui-style.ts@@ -20,14 +20,14 @@ export const CONNECTION_MANAGER_STYLE = String.raw`.integration .identity-guide[open]{padding-bottom:var(--space-3)}.integration .identity-guide summary{display:flex;align-items:center;min-height:var(--control-size);cursor:pointer;font-weight:var(--weight-strong)}.integration .identity-guide li{margin:var(--space-2) 0}.integration .identity-guide a{display:inline-flex;align-items:center;min-height:var(--control-size);margin:var(--space-2) var(--space-3) var(--space-1) 0;color:var(--settings-action-text);overflow-wrap:anywhere}-.integration .provider-heading,.integration .connection-heading{display:flex;align-items:flex-start;justify-content:space-between;gap:var(--space-4)}+.integration .provider-heading,.integration .connection-heading{display:flex;align-items:flex-start;justify-content:space-between;gap:var(--space-4);flex-wrap:wrap}.integration .provider-title{display:flex;align-items:flex-start;gap:var(--space-3);min-width:0}.integration .provider-heading .provider-mark{width:var(--settings-section-icon-size);height:var(--settings-section-icon-size);border-radius:var(--radius-panel)}-.integration .provider-title h2,.integration .integration-settings-detail>h2{font:var(--weight-strong) var(--type-title)/var(--line-title) var(--font-display);margin:0}.integration .provider-title p{max-width:var(--measure-copy);margin:var(--space-1) 0 0;color:var(--muted-foreground);font-size:var(--type-small)}+.integration .provider-title h2,.integration .integration-settings-detail>h2,.integration .identity-confirmation>h2{font:var(--weight-strong) var(--type-title)/var(--line-title) var(--font-display);margin:0}.integration .provider-title p{max-width:var(--measure-copy);margin:var(--space-1) 0 0;color:var(--muted-foreground);font-size:var(--type-small)}.integration .identity-summary-line{margin:var(--space-4) 0;padding-bottom:var(--space-3);border-bottom:var(--stroke) solid var(--border);font-size:var(--type-small);color:var(--muted-foreground)}.integration .connection-card{border:var(--stroke) solid var(--border);border-radius:var(--radius-panel);padding:var(--space-4);margin:var(--space-4) 0 0;background:var(--settings-card)}-.integration .connection-card h3{margin:0;font-size:var(--type-section);font-weight:var(--weight-strong);overflow-wrap:anywhere}.integration .connection-heading small{display:block;margin-top:var(--space-1);color:var(--muted-foreground)}-.integration .connection-state{font-size:var(--type-caption);line-height:var(--line-body);border:var(--stroke) solid var(--border);border-radius:var(--radius-pill);padding:var(--space-1) var(--space-2);white-space:nowrap}.integration .connection-state[data-ready=true]{color:var(--success-text);background:var(--settings-success-fill)}-.integration .identity-tags{display:flex;flex-wrap:wrap;gap:var(--space-2);margin:var(--space-3) 0;color:var(--muted-foreground);font-size:var(--type-caption)}.integration .identity-tags span{border-radius:var(--radius-pill);background:var(--muted);padding:var(--space-1) var(--space-2)}+.integration .connection-card h3{margin:0;font-size:var(--type-section);font-weight:var(--weight-strong);overflow-wrap:anywhere}.integration .connection-heading small{display:block;margin-top:var(--space-1);color:var(--muted-foreground);overflow-wrap:anywhere}.integration .connection-heading>div{min-width:0;max-width:100%}+.integration .connection-state{display:inline-block;max-width:100%;font-size:var(--type-caption);line-height:var(--line-body);border:var(--stroke) solid var(--border);border-radius:var(--radius-pill);padding:var(--space-1) var(--space-2);overflow-wrap:anywhere}.integration .connection-state[data-ready=true]{color:var(--success-text);background:var(--settings-success-fill)}+.integration .identity-tags{display:flex;flex-wrap:wrap;gap:var(--space-2);margin:var(--space-3) 0;color:var(--muted-foreground);font-size:var(--type-caption)}.integration .identity-tags span{display:inline-block;max-width:100%;border-radius:var(--radius-pill);background:var(--muted);padding:var(--space-1) var(--space-2);overflow-wrap:anywhere}.integration .identity-secret{display:flex;flex-wrap:wrap;align-items:center;gap:var(--space-2);min-width:0;max-width:100%}.integration .identity-secret-value{display:inline-block;max-width:100%;min-width:0;padding:var(--space-1) var(--space-2);font:var(--type-small)/var(--line-body) var(--font-mono);background:var(--secondary);color:var(--foreground);border:var(--stroke) solid var(--border);border-radius:var(--radius-control);overflow-wrap:anywhere;word-break:break-word}.integration .identity-secret-toggle{min-height:var(--control-size);min-width:var(--control-size)}.integration .identity-secret-copy{min-height:var(--control-size);min-width:var(--control-size)}.integration .identity-credential-status{display:grid;margin:var(--space-3) calc(var(--space-4) * -1) 0;font-size:var(--type-small);border-top:var(--stroke) solid var(--border)}.integration .identity-credential-status>div{display:grid;grid-template-columns:minmax(0,1fr) auto auto;align-items:center;gap:var(--space-2);min-height:var(--control-size);padding:var(--space-2) var(--space-4);border-bottom:var(--stroke) solid var(--border)}.integration .identity-credential-status>div:last-child{border-bottom:0}.integration .credential-field-state{font-size:var(--type-caption);color:var(--destructive-text)}.integration .credential-field-state[data-stored=true]{color:var(--success-text)}.integration .identity-fields{display:grid;grid-template-columns:1fr 1fr;gap:var(--space-4);margin:var(--space-4) 0}.integration .identity-fields label{min-width:0}.integration .identity-fields input,.integration .identity-fields select{margin-top:var(--space-2)}@@ -62,7 +62,7 @@ export const CONNECTION_MANAGER_STYLE = String.raw`.integration .integration-mobile-toolbar{position:sticky;top:0;z-index:var(--settings-layer-sticky);display:flex;align-items:center;border-bottom:var(--stroke) solid var(--border);padding:var(--space-2) var(--space-3);background:var(--settings-canvas);backdrop-filter:blur(var(--settings-backdrop-blur))}.integration .integration-heading{padding:var(--space-4) var(--space-4) 0}.integration .integration-settings-detail{padding:var(--space-4)}.integration .identity-feedback{padding:0 var(--space-4) var(--space-4)}- .integration .provider-heading{gap:var(--space-3);flex-wrap:wrap}.integration .provider-heading>.primary{width:100%}+ .integration .provider-heading,.integration .connection-heading{gap:var(--space-3);flex-wrap:wrap}.integration .provider-heading>.primary{width:100%}.integration .identity-fields{grid-template-columns:1fr}.integration .identity-tools[open] .identity-actions{position:static;box-shadow:none;min-width:0}.integration .identity-credential-status>div{grid-template-columns:minmax(0,1fr) auto}.integration .identity-credential-status>div>button{grid-column:1/-1;justify-self:start}.integration .identity-secret{width:100%}.integration .identity-credential-status>div>.identity-secret{grid-column:1/-1}}`;diff --git a/lib/infra/connection-ui.ts b/lib/infra/connection-ui.tsindex 473b41c0..2f02b727 100644--- a/lib/infra/connection-ui.ts+++ b/lib/infra/connection-ui.ts@@ -91,7 +91,7 @@ function mountConnectionManager(root,catalog,bridge,initial={}){activateNav(navMode);if(navMode==="owners")profiles();else if(navMode==="variables")variables();else if(navMode==="demo-users")void demoUsers();else if(navMode==="ai-providers")void aiProviders();else if(navMode==="routing")bindings();else if(navMode==="project-mcp")showProjectMcp();else drawProvider();}- function confirmation(title,id,fn){detail.replaceChildren(n("h2",title),n("p","This changes only the selected identity. Type “"+id+"” to confirm."));const value=input("Confirmation");detail.append(value.label,b("Confirm",()=>{if(value.input.value!==id){status.textContent="Confirmation does not match.";return}void fn()},"danger"),b("Cancel",()=>{navMode="provider";activateNav(navMode);drawProvider()}));}+ function confirmation(title,id,fn){const trigger=document.activeElement,cancel=()=>{if(navMode==="owners")profiles();else if(navMode==="demo-users")void demoUsers();else{navMode="provider";activateNav(navMode);drawProvider();}if(trigger&&typeof trigger.focus==="function"){if(document.contains(trigger))trigger.focus();else{const m=Array.from(detail.querySelectorAll("button")).find(e=>e.textContent===trigger.textContent);if(m)m.focus();else trigger.focus();}setTimeout(()=>{if(document.contains(trigger))trigger.focus();},0);}};const box=n("div",undefined,"identity-confirmation");box.setAttribute("role","alertdialog");box.setAttribute("aria-modal","true");const titleId="confirmation-title-"+(++sequence),heading=n("h2",title);heading.id=titleId;box.setAttribute("aria-labelledby",titleId);box.addEventListener("keydown",event=>{if(event.key==="Escape"){event.preventDefault();cancel();}});const desc=n("p","This changes only the selected identity. Type “"+id+"” to confirm."),value=input("Confirmation"),confirmBtn=b(title,()=>{if(value.input.value!==id){status.textContent="Confirmation does not match.";return}void fn()},"danger"),cancelBtn=b("Cancel",cancel);box.append(heading,desc,value.label,confirmBtn,cancelBtn);detail.replaceChildren(box);cancelBtn.focus();setTimeout(()=>cancelBtn.focus(),0);}function profiles(){detail.replaceChildren(n("h2","Credential owners"),n("p","These profiles isolate service accounts. They do not grant MSO device roles."));const id=input("New user ID"),name=input("Display label");detail.append(id.label,name.label);const create=b("Create user",()=>change({action:"user.create",user:id.input.value,label:name.input.value||id.input.value},async()=>{user=id.input.value;await reload()}),"primary");create.disabled=!bridge.manage;detail.append(create);diff --git a/lib/infra/integration-style-contract.test.ts b/lib/infra/integration-style-contract.test.tsindex 3d97f1ad..1493c503 100644--- a/lib/infra/integration-style-contract.test.ts+++ b/lib/infra/integration-style-contract.test.ts@@ -1,7 +1,7 @@import { describe, expect, it } from "vitest";import { CONNECTION_MANAGER_STYLE } from "./connection-ui-style";import { INTEGRATION_FORM_STYLE } from "./setup-ui";-import { PORTABILITY_STYLE } from "./portable/ui";+import { PORTABILITY_SCRIPT, PORTABILITY_STYLE } from "./portable/ui";import { INTEGRATION_PAGE_STYLE } from "./setup-page";import { SETTINGS_COMPACT_MAX } from "@/lib/presentation/responsive-contract";import { readFileSync } from "node:fs";@@ -68,4 +68,29 @@ describe("Integrations visual token contract", () => {expect(CONNECTION_MANAGER_STYLE).toContain(".integration .identity-check{display:flex;align-items:center;gap:var(--space-2);min-height:var(--control-size);cursor:pointer;font-weight:var(--weight-regular)}");expect(PORTABILITY_STYLE).toContain(".portable-transfer .identity-check{display:flex;gap:var(--space-2);align-items:center;min-height:var(--control-size);cursor:pointer;font-weight:var(--weight-regular)}");});++ it("enforces WCAG AA compliant error styling and accessible role for transfer errors (R-27)", () => {+ expect(PORTABILITY_STYLE).toContain(".transfer-error{");+ expect(PORTABILITY_STYLE).toContain("color:var(--destructive-text)");+ expect(PORTABILITY_STYLE).toContain("background:var(--settings-card)");+ expect(PORTABILITY_STYLE).toContain("overflow-wrap:anywhere");+ expect(PORTABILITY_SCRIPT).toContain("err.setAttribute('role','alert')");+ });++ it("enforces safe text wrapping and explicit overflow handling without nowrap on connection badges (R-03)", () => {+ // 1. .connection-state must not use white-space:nowrap, must allow wrap, and must handle overflow explicitly+ expect(CONNECTION_MANAGER_STYLE).not.toMatch(/\.connection-state\{[^}]*white-space:nowrap/);+ expect(CONNECTION_MANAGER_STYLE).toContain(".integration .connection-state{display:inline-block;max-width:100%");+ expect(CONNECTION_MANAGER_STYLE).toMatch(/\.connection-state\{[^}]*overflow-wrap:anywhere/);+ expect(CONNECTION_MANAGER_STYLE).toMatch(/\.connection-state\{[^}]*max-width:100%/);++ // 2. .identity-tags span must handle overflow and wrap cleanly+ expect(CONNECTION_MANAGER_STYLE).toContain(".integration .identity-tags span{display:inline-block;max-width:100%");+ expect(CONNECTION_MANAGER_STYLE).toMatch(/\.identity-tags span\{[^}]*overflow-wrap:anywhere/);++ // 3. .connection-heading and its contents must wrap and prevent flex blowouts+ expect(CONNECTION_MANAGER_STYLE).toContain(".integration .provider-heading,.integration .connection-heading{display:flex;align-items:flex-start;justify-content:space-between;gap:var(--space-4);flex-wrap:wrap}");+ expect(CONNECTION_MANAGER_STYLE).toContain(".integration .connection-heading small{display:block;margin-top:var(--space-1);color:var(--muted-foreground);overflow-wrap:anywhere}");+ expect(CONNECTION_MANAGER_STYLE).toContain(".integration .connection-heading>div{min-width:0;max-width:100%}");+ });});diff --git a/lib/infra/portable/ui.ts b/lib/infra/portable/ui.tsindex fb067c34..b58d34ff 100644--- a/lib/infra/portable/ui.ts+++ b/lib/infra/portable/ui.ts@@ -58,7 +58,7 @@ function mountPortability(root,bridge){const apply=button('Apply import',async()=>{if(!preview||!reviewed.i.checked){status.textContent='Review the preview and confirm first.';return}apply.disabled=check.disabled=true;try{const result=await bridge.request({...input(),apply:true,confirm:preview.planId,acceptWarnings:reviewed.i.checked});previewBox.textContent=JSON.stringify(result,null,2);status.textContent='Import complete. Imported connections are not marked verified; external authorization must be completed again.';documentData=null;file.i.value='';decrypt.i.value='';preview=null}catch(e){status.textContent=e.message;apply.disabled=false}finally{check.disabled=false}},'primary');apply.disabled=true;card.append(file.l,decrypt.l,prefix.l,policyLabel,check,previewBox,reviewed.l,apply,status);body.append(card);}function render(){if(disposed)return;body.replaceChildren();exportTab.setAttribute('aria-selected',String(active==='export'));importTab.setAttribute('aria-selected',String(active==='import'));active==='export'?exportView():importView()}- render();bridge.request({action:'tree'}).then(data=>{if(disposed)return;tree=data;for(const owner of tree.users)for(const p of owner.providers)for(const c of p.connections)selected.add(owner.id+'|'+p.id+'|'+c.id);if(active==='export')render()}).catch(e=>{if(!disposed){tree={users:[]};body.prepend(el('p',e.message,'transfer-error'))}});+ render();bridge.request({action:'tree'}).then(data=>{if(disposed)return;tree=data;for(const owner of tree.users)for(const p of owner.providers)for(const c of p.connections)selected.add(owner.id+'|'+p.id+'|'+c.id);if(active==='export')render()}).catch(e=>{if(!disposed){tree={users:[]};const err=el('p',e.message,'transfer-error');err.setAttribute('role','alert');body.prepend(err)}});function cleanup(){disposed=true;documentData=null;preview=null;selected.clear();root.replaceChildren();root.classList.remove('portable-transfer','integration')}return cleanup;}@@ -71,5 +71,6 @@ export const PORTABILITY_STYLE=String.raw`.portable-transfer .identity-check{display:flex;gap:var(--space-2);align-items:center;min-height:var(--control-size);cursor:pointer;font-weight:var(--weight-regular)}.portable-transfer .identity-check input{width:var(--icon-size);height:var(--icon-size);margin:0;order:-1;flex:none;accent-color:var(--primary)}.portable-transfer .transfer-tree{max-height:var(--settings-scroll-max-height);overflow:auto;margin:var(--space-3) 0;padding:var(--space-3);border:var(--stroke) solid var(--border);border-radius:var(--radius-control);background:var(--background)}.portable-transfer .transfer-tree-user{padding:var(--space-2) 0;border-bottom:var(--stroke) solid var(--border)}.portable-transfer .transfer-tree-provider{padding-left:var(--space-6)}.portable-transfer .transfer-tree-provider>.identity-check~.identity-check{padding-left:var(--space-6);color:var(--muted-foreground)}.portable-transfer pre{max-height:var(--settings-code-max-height);overflow:auto;font:var(--type-caption)/var(--line-body) var(--font-mono);white-space:pre-wrap;overflow-wrap:anywhere;background:var(--muted);border-radius:var(--radius-control);padding:var(--space-3)}.portable-transfer [role=status]{font-size:var(--type-small);overflow-wrap:anywhere}.portable-transfer .transfer-hint{font-size:var(--type-caption);color:var(--muted-foreground);margin-top:var(--space-3)}.portable-transfer button{min-height:var(--control-size);margin:var(--space-2) var(--space-2) var(--space-2) 0}+.portable-transfer .transfer-error{color:var(--destructive-text);background:var(--settings-card);border:var(--stroke) solid var(--settings-danger-border);border-radius:var(--radius-control);padding:var(--space-3);margin:var(--space-3) 0;overflow-wrap:anywhere}@container integration (max-width:${SETTINGS_COMPACT_MAX}){.portable-transfer .transfer-card{padding:var(--space-4)}.portable-transfer .transfer-tabs button{flex:1}.portable-transfer .transfer-tree-provider,.portable-transfer .transfer-tree-provider>.identity-check~.identity-check{padding-left:var(--space-3)}}`;