Skip to content

armgit / mso

Public Imported from GitHub
0

Browser-based graphical shell and control plane for a Linux server you own — real terminal, file manager, live metrics and BYOK AI in one mobile-first workspace. Next.js 16 · React 19 · node-pty · Tailwind v4 · shadcn/ui. Public alpha, self-hosted.

fix(workflows): remount editors when sandbox policy changes

Rahman2e9bbde68d50
diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md
index a9ec29b4..e76f3169 100644
--- a/docs/CHANGELOG.md
+++ b/docs/CHANGELOG.md
@@ -13,6 +13,7 @@ this is the *what*, and it is what Settings → About shows as “What's new”.
**Fixed**
+- `workflows` remount editors when sandbox policy changes
- `workflows` retain approved shared surface placements
- `browser` keep Camoufox automation on demand
- `workflows` isolate external editors from cockpit session cookies
diff --git a/docs/PROGRESS.md b/docs/PROGRESS.md
index ed2dadc1..5dc57169 100644
--- a/docs/PROGRESS.md
+++ b/docs/PROGRESS.md
@@ -1,3 +1,10 @@
+## 2026-09-18 — Remount reviewed workflow editors when sandbox policy changes
+
+A focus refresh can tighten an existing external editor's sandbox without changing its id or origin.
+The embedded document must not keep the permissions from the previous navigation. The iframe key now
+includes the reviewed sandbox policy, so a policy change remounts the document before it can continue.
+Blocked destinations and cookie-isolated origins remain unchanged; no sandbox capability is added.
+
## 2026-09-18 — Preserve existing MCP Page approval during Workflow metadata edits
The shared registry review found that a Workflow-only save replaced a previously shared
diff --git a/frontend/slices/workflows/components/workflow-embed-panel.test.tsx b/frontend/slices/workflows/components/workflow-embed-panel.test.tsx
index fa91f6a1..2e7f419f 100644
--- a/frontend/slices/workflows/components/workflow-embed-panel.test.tsx
+++ b/frontend/slices/workflows/components/workflow-embed-panel.test.tsx
@@ -1,3 +1,4 @@
+import { readFileSync } from "node:fs";
import { describe, expect, it } from "vitest";
import { renderToStaticMarkup } from "react-dom/server";
import { WorkflowEmbedPanel } from "./workflow-embed-panel";
@@ -9,6 +10,11 @@ describe("blocked external editor rendering", () => {
expect(html).toContain("Blocked session cookie scope");
expect(html).not.toContain("<iframe"); expect(html).not.toContain('href='); expect(html).not.toContain(app.origin);
});
+
+ it("remounts the iframe whenever the reviewed sandbox policy changes", () => {
+ const source = readFileSync(new URL("./workflow-embed-panel.tsx", import.meta.url), "utf8");
+ expect(source).toContain('key={`${revision}:${app.sandbox}`}');
+ });
it("fails closed if a destination is missing even without the blocked flag", () => {
const html = renderToStaticMarkup(<WorkflowEmbedPanel app={{ ...app, url: undefined }} />);
expect(html).not.toContain("<iframe"); expect(html).not.toContain('href=');
diff --git a/frontend/slices/workflows/components/workflow-embed-panel.tsx b/frontend/slices/workflows/components/workflow-embed-panel.tsx
index 764bf99d..176e5c3b 100644
--- a/frontend/slices/workflows/components/workflow-embed-panel.tsx
+++ b/frontend/slices/workflows/components/workflow-embed-panel.tsx
@@ -27,7 +27,7 @@ export function WorkflowEmbedPanel({ app }: { app: WorkflowEmbed }) {
</div>
{app.renderer === "iframe" ? <div className="relative min-h-0 min-w-0 flex-1">
{loading ? <div className="absolute inset-x-0 top-0 z-10 border-b bg-background px-3 py-2 text-xs text-muted-foreground" role="status">{slow ? `Taking longer than expected. Open ${app.title} in a new tab if its login or frame policy blocks embedding.` : `Loading ${app.title}…`}</div> : null}
- <iframe key={revision} src={app.url} title={`${app.title} workflow editor`} sandbox={app.sandbox} referrerPolicy="no-referrer" className="h-full w-full border-0 bg-background" onLoad={() => setLoading(false)} onError={() => { setLoading(true); setSlow(true); }}/>
+ <iframe key={`${revision}:${app.sandbox}`} src={app.url} title={`${app.title} workflow editor`} sandbox={app.sandbox} referrerPolicy="no-referrer" className="h-full w-full border-0 bg-background" onLoad={() => setLoading(false)} onError={() => { setLoading(true); setSlow(true); }}/>
</div> : <div className="flex min-h-0 flex-1 items-center justify-center p-6 text-center text-sm text-muted-foreground">{app.reason || `${app.title} opens in a separate tab. Embedded access is not enabled for this provider.`}</div>}
<p className="shrink-0 border-t px-3 py-1.5 text-xs text-muted-foreground [@media(max-height:520px)]:sr-only">{app.title} keeps its own login. Sign in in a new tab, then reload here. If embedding is blocked, use Open {app.title}.</p>
</div>;