Skip to content

armgit / mso

Public Imported from GitHub
0

Browser-based graphical shell and control plane for a Linux server you own — real terminal, file manager, live metrics and BYOK AI in one mobile-first workspace. Next.js 16 · React 19 · node-pty · Tailwind v4 · shadcn/ui. Public alpha, self-hosted.

docs: reconcile all frontend audit findings

Abdurrahman Fakhrul40693ee405d1
diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md
index d749a354..5c422710 100644
--- a/docs/CHANGELOG.md
+++ b/docs/CHANGELOG.md
@@ -8,6 +8,10 @@ this is the *what*, and it is what Settings → Account → About shows as “Wh
**Fixed**
+- preserve window drafts and modal focus
+- bind Composio sessions to selected connections
+- guard concurrent workflow replacements
+- guard workspace save and browser lifecycles
- prevent direct remote markdown file export
- `settings` retain About subpage across shell changes
- `ui` preserve external editor height on short screens
@@ -19,6 +23,11 @@ this is the *what*, and it is what Settings → Account → About shows as “Wh
- `frontend` allow relinking recovered media
- `frontend` protect workspace and media sessions
+**Docs**
+
+- reconcile all frontend audit findings
+- record rendered surfaces verification
+
## 2026-11-03
**Added**
diff --git a/docs/PROGRESS.md b/docs/PROGRESS.md
index 7186f1a1..5a987163 100644
--- a/docs/PROGRESS.md
+++ b/docs/PROGRESS.md
@@ -4,6 +4,14 @@ Markdown transcripts may contain server-provided content. The TUI now prints the
review and copying instead of writing that content directly to a local file. File flags
are refused before fetching a session; the separate non-Markdown export is unchanged.
+## 2026-11-04 — Complete audited frontend implementation follow-ups
+
+The existing 55-group frontend audit is tracked in [the implementation ledger](evidence/2026-11-04-frontend-audit-ledger.md), with per-slice source, behavior evidence and remaining acceptance limits. The previous foundation is on main through PR #270; this increment addresses its unresolved Settings credential remount, Composio selection/cache binding and external-frame readiness gaps, plus save/conflict/pending-action races found during verification.
+
+Settings retains operational input in the existing exact-window memory store, tags sensitive drafts for selective cleanup, preserves nonsecret editor buffers at auth boundaries, orders session probes across logout and blocks navigation during submitted provider writes. Responsive drawers acquire focus on open, including Shortcuts; the actual full Settings remount and five-shell/two-theme focus regressions are wired into mandatory release journeys. Workspace saves acknowledge only the revision saved, video draft baselines come from their load, and Camoufox aborts its current operation on unmount. Workflow source copy/restore share the action lock and preserve newer edits. Composio uses an authorized explicit owner/connection and a credential-revision-bound cache; frame fallback says readiness is unknown instead of inferring success from load.
+
+Focused unit and mounted synthetic component checks passed during implementation. External headless fixtures cover selected five-shell/two-theme/320–844 samples with a prior CSS build; they are not exact-SHA release proof. Full local, pinned scanner and remote results must be recorded for the final commit before merge readiness; real devices, assistive technology and upstream vendor behavior remain explicit limits. No production deployment, host data or tunnel was changed.
+
## 2026-11-03: frontend contract for every feature and agent
Frontend rules were spread across product direction, shell design notes and the dynamic
diff --git a/docs/evidence/2026-11-04-final-agents.md b/docs/evidence/2026-11-04-final-agents.md
index f2237daf..3e05bf0b 100644
--- a/docs/evidence/2026-11-04-final-agents.md
+++ b/docs/evidence/2026-11-04-final-agents.md
@@ -17,3 +17,7 @@ Base a2268f2b includes the earlier changes described in [frontend agent evidence
| Managed install | Existing clipboard consumer awaits the boolean result; static Orca tests passed. No real clipboard or installation proof. |
Validation: Node 22, umask 077, VITEST_MAX_WORKERS=2. Two isolated component fixtures passed (GroupEditor CAS and VersionPanel cancellation/single-flight); they live in ignored .agent/evidence/final-agents and use the audit's external react-test-renderer installation, so are not portable CI tests. Five tracked test files passed 15 tests, including 2 form, 2 memory transform and 7 Orca static tests. TypeScript, targeted ESLint, and diff check passed. No full build, security scan, PR gates, real API, browser, assistive technology, actual device or remote CI was run; integration owner must run applicable gates and behavioral journeys on the final SHA.
+
+## Mounted replacement cancellation follow-up
+
+A synthetic React test-renderer fixture mounted the actual WorkflowsApp, source and version panels with mocked network, shell and visual children. Cancelling Duplicate, Restore and Copy each asked for confirmation; zero update/clone/restore/POST calls were made and the dirty workflow name remained. Source was 1367a24b. This tests application-level cancellation, not browser focus, real API persistence or full-shell rendering. Receipts are final-workspace-mounted-receipt JSON/Markdown in the external audit work folder.
diff --git a/docs/evidence/2026-11-04-final-workspace.md b/docs/evidence/2026-11-04-final-workspace.md
index acbf31fc..17ac7e71 100644
--- a/docs/evidence/2026-11-04-final-workspace.md
+++ b/docs/evidence/2026-11-04-final-workspace.md
@@ -23,3 +23,7 @@ Scope: isolated workspace branch based on origin/main a2268f2b, including PR #27
| WSC-04 | Unmount now aborts the current retry/power controller, session fetch receives its signal, late status/transport updates are guarded, and superseded power operations cannot clear a newer busy state. Mocked delayed operation and actual noVNC lifecycle still need interactive proof. |
Validation: targeted draft, relink and media-kind tests passed 28 tests; new terminal delivery tests passed 2; new draft race hook test passed 1. TypeScript, targeted ESLint and architecture checks were run; see final task report for final rerun results. The draft hook test uses a synthetic hook scheduler, not React DOM. Existing tests and source review do not prove the outstanding UI journeys above.
+
+## Mounted negative-path follow-up
+
+A synthetic React test-renderer fixture mounted the actual CodeEditor with mocked visual children and host API: the inactive dirty tab vetoed close, and a rejected Save & Close kept the window and edited text with an error. The actual draft autosave hook reported savedAt null plus error for a quota failure; the full Video Editor/Saved indicator was not mounted. Actual AssetRecovery relinked a mocked video asset from an old blob reference to a new reference and metadata, without real media decoding. The source was 185aaa99; JSON/Markdown receipts are final-workspace-mounted-receipt in the external audit work folder. These are not browser DOM, mobile or full-shell proofs.
diff --git a/docs/evidence/2026-11-04-frontend-audit-ledger.md b/docs/evidence/2026-11-04-frontend-audit-ledger.md
new file mode 100644
index 00000000..1cbe39e9
--- /dev/null
+++ b/docs/evidence/2026-11-04-frontend-audit-ledger.md
@@ -0,0 +1,75 @@
+# Frontend audit implementation ledger, 2026-11-04
+
+This ledger covers the existing 55 finding groups (8 P1, 47 P2), not an assertion that every application or possible resolution has passed acceptance. The earlier implementation is on main via PR #270. This follow-up closes the remaining source gaps and adds regression evidence. Implementation present and journey verified are separate claims.
+
+Ownership follows [the frontend contract](../FRONTEND-CONTRACT.md): shell owns presentation and inherited metrics; each feature owns data, scope and draft lifetime; the UI kit owns shared controls and dialogs. No shell forks provider authorization or durable data.
+
+| Finding | Original observation | Implemented behavior | Detailed evidence |
+|---|---|---|---|
+| SH-01 (P1) | Tab Image Picker tidak dapat dipindahkan dengan keyboard | Roving Arrow/Home/End tab navigation and unique panel IDs. | [scope and limits](2026-11-04-final-shell.md) |
+| SH-02 (P1) | Pemilih berkas Upload tidak mempunyai pintu masuk keyboard | Native Choose file button reaches the hidden file input. | [scope and limits](2026-11-04-final-shell.md) |
+| SH-03 (P2) | Clipboard menyatakan sukses walaupun write ditolak/tidak tersedia | Clipboard result awaited; rejected writes retain manual-copy recovery. | [scope and limits](2026-11-04-final-shell.md) |
+| SH-04 (P2) | Link gambar gagal tetap diterima sebagai gambar valid | Image link checked for load/error/timeout with request identity. | [scope and limits](2026-11-04-final-shell.md) |
+| SH-05 (P2) | Palet Icon Picker terpotong di coarse pointer | Palette wraps coarse-pointer swatches and expandable pills. | [scope and limits](2026-11-04-final-shell.md) |
+| SH-06 (P2) | Config lebar sidebar React belum dikonsumsi shared rail | Shared sidebar consumes inherited feature width token. | [scope and limits](2026-11-04-final-shell.md) |
+| SH-07 (P2) | State navigasi/draft Settings belum mengikuti identitas window | Exact-window Settings/form state, sensitive in-memory drafts, save/discard/close/navigation guards and ordered auth cleanup. | [scope and limits](2026-11-04-final-shell.md) |
+| SH-08 (P2) | Overlay shortcut/clipboard belum memiliki modal focus boundary | Shared modal boundary, native drawer autofocus, keyboard containment and opener restoration. | [scope and limits](2026-11-04-final-shell.md) |
+| SH-09 (P2) | Aksi Pin/Remove clipboard hanya muncul saat hover | Clipboard controls visible for keyboard focus and coarse pointers. | [scope and limits](2026-11-04-final-shell.md) |
+| SH-10 (P2) | Icon Picker fallback dialog tidak diberi judul aksesibel | Icon picker dialog has an accessible name. | [scope and limits](2026-11-04-final-shell.md) |
+| SH-11 (P2) | Kegagalan memuat theme presets menjadi panel kosong tanpa recovery | Preset error/retry UI and rejected registry promise reset. | [scope and limits](2026-11-04-final-shell.md) |
+| SH-12 (P2) | Close target Dialog UI kit belum mengikuti minimum touch44 | Coarse close targets use 44px geometry with title clearance. | [scope and limits](2026-11-04-final-shell.md) |
+| AD-01 (P1) | Membuka form Alfa membongkar chat dan menghapus identitas/history percakapan lokal | Chat remains mounted while its form is visible. | [scope and limits](2026-11-04-final-agents.md) |
+| AD-02 (P1) | Channels dan Agent groups dapat menyimpan draft lama dengan revision snapshot yang sudah baru | Editors submit the original captured CAS revision and retain conflicting drafts. | [scope and limits](2026-11-04-final-agents.md) |
+| AD-03 (P1) | Workflows: Duplicate, copy dari Sources dan restore versi dapat mengganti draft dirty tanpa keputusan | Dirty decisions precede replacement; source copy/restore share the action lock and protect later edits. | [scope and limits](2026-11-04-final-agents.md) |
+| AD-04 (P2) | Delete Organization langsung, tanpa status pending dan jalur error yang ditangkap editor | Named Organization confirmation with pending and error state. | [scope and limits](2026-11-04-final-agents.md) |
+| AD-05 (P2) | Workflow variables: aksi hapus tanpa label, konfirmasi, pending atau catch | Named variable actions, confirmation, pending and caught errors. | [scope and limits](2026-11-04-final-agents.md) |
+| AD-06 (P2) | Shared Alfa form Field hanya teks visual, tidak mengasosiasikan label/hint dengan input | Shared form labels and hint associations. | [scope and limits](2026-11-04-final-agents.md) |
+| AD-07 (P2) | Memory graph mempunyai keyboard node-open, tetapi belum parity selection dan viewport controls | Memory selection and viewport pan/zoom/fit controls support keyboard. | [scope and limits](2026-11-04-final-agents.md) |
+| AD-08 (P2) | Memory graph menampilkan “No notes yet” untuk hasil search/filter kosong | No search matches is distinct from an empty note collection. | [scope and limits](2026-11-04-final-agents.md) |
+| AD-09 (P2) | Memory dan Agent Vault bergantung pada localStorage yang tidak diguard | Memory/Vault catch unavailable or failing browser storage. | [scope and limits](2026-11-04-final-agents.md) |
+| AD-10 (P2) | Draft baru Channels/groups dihapus diam-diam bila revision berubah di background | New editor draft identity survives background snapshot refresh; cancel asks about dirtiness. | [scope and limits](2026-11-04-final-agents.md) |
+| AD-11 (P2) | Organization Unit/Seat actions menjadi ikon tanpa nama di panel sempit | Narrow Organization actions retain accessible names. | [scope and limits](2026-11-04-final-agents.md) |
+| AD-12 (P2) | Member editor Agent groups tidak mempunyai label yang persisten dan select credential tak bernama | Member editor labels and credential fieldsets remain named. | [scope and limits](2026-11-04-final-agents.md) |
+| WS-01 (P1) | Code: Save & Close tetap menutup saat penulisan host gagal | Failed writes veto Save & Close and keep the draft. | [scope and limits](2026-11-04-final-workspace.md) |
+| WS-02 (P1) | Code: Guard window hanya melihat tab aktif, sehingga draft tab lain tidak dilindungi | All dirty tabs participate in the exact-window close guard. | [scope and limits](2026-11-04-final-workspace.md) |
+| WS-03 (P1) | Video Editor: Status Saved ditampilkan meski autosave gagal atau media upload tidak dapat dipulihkan | Failed storage is not Saved; transient media warns and supports relinking. | [scope and limits](2026-11-04-final-workspace.md) |
+| WS-04 (P2) | Image Editor: Autosave dokumen host tidak memeriksa HTTP/error dan tidak memberi status/retry | Serialized project writes, failure/retry, flush-before-image-save and revision-aware dirty acknowledgement. | [scope and limits](2026-11-04-final-workspace.md) |
+| WS-05 (P2) | Preview: File baru dari Files dapat diabaikan setelah pengguna pernah paging | New payload identity supersedes paged preview state. | [scope and limits](2026-11-04-final-workspace.md) |
+| WS-06 (P2) | Preview: Tombol panah global memindahkan file meski fokus ada pada aplikasi lain | Preview arrow handling is limited to the focused window. | [scope and limits](2026-11-04-final-workspace.md) |
+| WS-07 (P2) | Finder/Files: Virtualisasi 28 px bertentangan dengan row sentuh minimum 44 px | Virtualizer and coarse row geometry agree at 44px. | [scope and limits](2026-11-04-final-workspace.md) |
+| WS-08 (P2) | Code: Tab file hanya div dengan klik, tidak bisa dipilih sebagai tab melalui keyboard | Code tab roles and roving keyboard selection. | [scope and limits](2026-11-04-final-workspace.md) |
+| WS-09 (P2) | Finder/Files iOS: Search memakai teks 14 px dan close target sekitar 14 px tanpa fokus yang terlihat | 16px iOS search input and coarse close/focus treatment. | [scope and limits](2026-11-04-final-workspace.md) |
+| WS-10 (P2) | Terminal/Claude: Kegagalan POST input diam-diam membuang ketikan tanpa status kegagalan | HTTP/network input failures halt uncertain delivery without replay. | [scope and limits](2026-11-04-final-workspace.md) |
+| WS-11 (P2) | Image Editor: Resize panel mobile hanya pointer, tanpa keyboard/semantik atau pointer-cancel cleanup | Keyboard separator operation and pointer-cancel cleanup. | [scope and limits](2026-11-04-final-workspace.md) |
+| WS-12 (P2) | Video Editor: Import browser dapat menerima respons folder lama dan awal loading tidak ditandai | Import response identity, initial loading and retry. | [scope and limits](2026-11-04-final-workspace.md) |
+| WS-13 (P2) | Video Editor: Render tidak dibatalkan/URL dibersihkan saat fitur unmount | Export abort, activity generation and object URL cleanup. | [scope and limits](2026-11-04-final-workspace.md) |
+| PX-01 (P2) | Dokploy / Cloudflare: Refresh dapat ditimpa respons request lama | Superseded Infrastructure reads abort and cannot publish. | [scope and limits](2026-11-04-final-surfaces.md) |
+| PX-02 (P2) | Dokploy / Cloudflare: Loading, error, empty dan tombol Refresh belum jelas | Infrastructure loading/error/empty/stale and retry states are distinct. | [scope and limits](2026-11-04-final-surfaces.md) |
+| PX-03 (P2) | Integrations / Composio: Panel Composio tidak mengikuti owner/connection yang dipilih manager | Manager owner and explicit connection bind UI requests and server cache to authorized credential identity/revision. | [scope and limits](2026-11-04-final-surfaces.md) |
+| PX-04 (P2) | Create App: Label form visual tidak terhubung ke kontrol | Create App input labels are associated. | [scope and limits](2026-11-04-final-surfaces.md) |
+| PX-05 (P2) | Create App: Palet Accent tidak reflow setelah target sentuh diperbesar | Accent controls reflow with coarse geometry and expose selection. | [scope and limits](2026-11-04-final-surfaces.md) |
+| PX-06 (P2) | Create App: Draft form tidak mempunyai lifetime window/guard discard | Create App draft has exact-window lifetime and discard guard. | [scope and limits](2026-11-04-final-surfaces.md) |
+| PX-07 (P2) | n8n: Kegagalan Refresh sesudah data tersedia tidak terlihat | n8n refresh failures identify retained content as stale. | [scope and limits](2026-11-04-final-surfaces.md) |
+| PX-08 (P2) | System Monitor: Telemetry lama tetap tampak sehat setelah polling gagal | Monitor identifies stale telemetry and superseded polls cannot overwrite it. | [scope and limits](2026-11-04-final-surfaces.md) |
+| SH-13 (P2) | Image Picker: file pengganti invalid tetap meninggalkan file lama siap diunggah | Invalid replacement clears the previous accepted upload. | [scope and limits](2026-11-04-final-shell.md) |
+| SH-14 (P2) | Desktop icons: tombol hanya bereaksi pada double-click, bukan Enter/Space | Keyboard activation opens desktop icons; Delete is scoped to desktop focus. | [scope and limits](2026-11-04-final-shell.md) |
+| WSC-01 (P2) | Video: tab browser lain dapat menimpa recovery draft yang lebih baru | Draft conflict baseline captured during the same initial read; concurrent storage changes cannot be silently adopted. | [scope and limits](2026-11-04-final-workspace.md) |
+| WSC-02 (P2) | Preview: Download/Open in editor tidak memakai isi sample yang ditampilkan | Sample actions use displayed bytes; unsupported byte-dependent actions are withheld. | [scope and limits](2026-11-04-final-workspace.md) |
+| WF-02 (P2) | Workflows: Delete tidak meminta keputusan untuk target dan draft | Workflow deletion names the target and asks about unsaved state, under the action lock. | [scope and limits](2026-11-04-final-agents.md) |
+| AC-01 (P2) | Channels/groups: response refresh lama dapat menggantikan snapshot terbaru | Only the newest Channels/group refresh generation can publish. | [scope and limits](2026-11-04-final-agents.md) |
+| ST-01 (P2) | Store/Create/Shell features: storage gagal tetapi state terlihat berhasil tersimpan | Browser registry commits persistence before publishing success and reports failures. | [scope and limits](2026-11-04-final-surfaces.md) |
+| ST-02 (P2) | Skills: respons reload lama dapat menggantikan katalog terbaru | Skills catalog publishes a coherent generation and serializes mutations. | [scope and limits](2026-11-04-final-surfaces.md) |
+| ST-03 (P2) | External app frame: load selesai meskipun embedding ditolak | External iframe load is not asserted as readiness; visible Open and recovery guidance remain available. | [scope and limits](2026-11-04-final-surfaces.md) |
+| PX-09 (P2) | Integrations: daftar Composio panjang menghilangkan ruang manager | Composio tool disclosure is capped and scrolls internally. | [scope and limits](2026-11-04-final-surfaces.md) |
+
+## Investigations and limits
+
+WF-01 is grouped under AD-03. SH-C01 desktop Delete scope is guarded under SH-14. WSC-03 null/throwing image export and WSC-04 superseded/unmounted Camoufox operations received defensive fixes; their actual canvas/noVNC journeys remain acceptance limits. AD-13 managed upstream readiness is unknown without a vendor handshake. ST-I01 blocked-domain correction, ST-I02 successful mutation followed by failed refresh, and ST-I03 system-monitor no-match remain distinguished from proven implementation defects; the no-match UI is present. Do not turn these into fabricated security or upstream success claims.
+
+Cross-origin frame readiness cannot be proven by iframe load. Browser teardown can interrupt writes. Unsaved operational drafts are not durable after a reload; transient media uploads require relinking. Terminal failure reports uncertain delivery and never blindly resends potentially executed input.
+
+## Integration evidence
+
+Per-agent records list focused tests, mocked component receipts and remaining manual checks. Shared-shell fixtures used five shells, two themes and 320/390/844 landscape samples, with previously compiled CSS; they do not replace the current-build browser gate. Physical devices, assistive technology and real upstream credentials are outside those fixtures. Required local, pinned security and remote checks must be recorded for the final committed SHA before readiness or merge is asserted.
+
+Rollback: revert the incremental audit commits through an ordinary reviewed PR. No live deployment, tunnel, runtime state or credential store was modified by this audit work.