Skip to content

armgit / mso

Public Imported from GitHub
0

Browser-based graphical shell and control plane for a Linux server you own — real terminal, file manager, live metrics and BYOK AI in one mobile-first workspace. Next.js 16 · React 19 · node-pty · Tailwind v4 · shadcn/ui. Public alpha, self-hosted.

refactor(workflows): remove optimizer type cycle

Rahman4783997e6d01
diff --git a/lib/workflow/graph-optimizer-candidates.ts b/lib/workflow/graph-optimizer-candidates.ts
index c4f04af0..fd2deb24 100644
--- a/lib/workflow/graph-optimizer-candidates.ts
+++ b/lib/workflow/graph-optimizer-candidates.ts
@@ -1,7 +1,7 @@
import type { GraphCustomNode } from "@/lib/contracts/graph-custom-nodes";
import type { WorkflowGraph, WorkflowGraphEdge, WorkflowGraphNode } from "@/lib/contracts/workflow-graph";
import type { CapabilityTool } from "@/lib/capabilities/tool";
-import type { WorkflowOptimizerCandidate } from "./graph-optimizer";
+import type { WorkflowOptimizerCandidate } from "./graph-optimizer-types";
export type InternalOptimizerCandidate = WorkflowOptimizerCandidate & {
apply: (graph: WorkflowGraph) => WorkflowGraph;
diff --git a/lib/workflow/graph-optimizer-types.ts b/lib/workflow/graph-optimizer-types.ts
new file mode 100644
index 00000000..e9a38638
--- /dev/null
+++ b/lib/workflow/graph-optimizer-types.ts
@@ -0,0 +1,52 @@
+export type WorkflowOptimizerRisk = "safe" | "review";
+export type WorkflowOptimizerCandidateKind = "presentation-group" | "loop-compaction";
+export type WorkflowOptimizerCandidate = {
+ id: string;
+ kind: WorkflowOptimizerCandidateKind;
+ title: string;
+ description: string;
+ nodeIds: string[];
+ risk: WorkflowOptimizerRisk;
+ estimatedNodeDelta: number;
+ hostEligible: true;
+ probability?: number;
+ selected?: boolean;
+ reason?: string;
+};
+
+export type WorkflowOptimizerDecisionMode = "deterministic" | "jev";
+export type WorkflowOptimizerEvaluation = {
+ provider: "deterministic" | "jev" | "fallback";
+ probabilities: Record<string, number>;
+ fallbackReason?: string;
+};
+
+export type WorkflowOptimizerEvaluator = (
+ state: Record<string, unknown>,
+ candidates: WorkflowOptimizerCandidate[],
+) => Promise<WorkflowOptimizerEvaluation>;
+
+export type WorkflowOptimizationPreview = {
+ version: 1;
+ source: { id: string; revision: string; name: string; nodeCount: number; edgeCount: number };
+ mode: WorkflowOptimizerDecisionMode;
+ provider: WorkflowOptimizerEvaluation["provider"];
+ threshold: number;
+ candidates: WorkflowOptimizerCandidate[];
+ selectedCandidateIds: string[];
+ reviewCandidateIds: string[];
+ summary: {
+ candidateCount: number;
+ selectedCount: number;
+ reviewCount: number;
+ beforeNodes: number;
+ afterNodes: number;
+ beforeEdges: number;
+ afterEdges: number;
+ visualGroupsAdded: number;
+ nodeReduction: number;
+ edgeReduction: number;
+ };
+ fallbackReason?: string;
+ shadow?: { baseline: "deterministic"; compared: "jev"; agreement: number; disagreements: string[] };
+};
diff --git a/lib/workflow/graph-optimizer.ts b/lib/workflow/graph-optimizer.ts
index 47f3930b..d78f41de 100644
--- a/lib/workflow/graph-optimizer.ts
+++ b/lib/workflow/graph-optimizer.ts
@@ -2,56 +2,22 @@ import type { WorkflowGraph } from "@/lib/contracts/workflow-graph";
import type { CapabilityTool } from "@/lib/capabilities/tool";
import { workflowOptimizerCandidates } from "./graph-optimizer-candidates";
-export type WorkflowOptimizerRisk = "safe" | "review";
-export type WorkflowOptimizerCandidateKind = "presentation-group" | "loop-compaction";
-export type WorkflowOptimizerCandidate = {
- id: string;
- kind: WorkflowOptimizerCandidateKind;
- title: string;
- description: string;
- nodeIds: string[];
- risk: WorkflowOptimizerRisk;
- estimatedNodeDelta: number;
- hostEligible: true;
- probability?: number;
- selected?: boolean;
- reason?: string;
-};
-export type WorkflowOptimizerDecisionMode = "deterministic" | "jev";
-export type WorkflowOptimizerEvaluation = {
- provider: "deterministic" | "jev" | "fallback";
- probabilities: Record<string, number>;
- fallbackReason?: string;
-};
-export type WorkflowOptimizerEvaluator = (
- state: Record<string, unknown>,
- candidates: WorkflowOptimizerCandidate[],
-) => Promise<WorkflowOptimizerEvaluation>;
-
-export type WorkflowOptimizationPreview = {
- version: 1;
- source: { id: string; revision: string; name: string; nodeCount: number; edgeCount: number };
- mode: WorkflowOptimizerDecisionMode;
- provider: WorkflowOptimizerEvaluation["provider"];
- threshold: number;
- candidates: WorkflowOptimizerCandidate[];
- selectedCandidateIds: string[];
- reviewCandidateIds: string[];
- summary: {
- candidateCount: number;
- selectedCount: number;
- reviewCount: number;
- beforeNodes: number;
- afterNodes: number;
- beforeEdges: number;
- afterEdges: number;
- visualGroupsAdded: number;
- nodeReduction: number;
- edgeReduction: number;
- };
- fallbackReason?: string;
- shadow?: { baseline: "deterministic"; compared: "jev"; agreement: number; disagreements: string[] };
-};
+import type {
+ WorkflowOptimizationPreview,
+ WorkflowOptimizerCandidate,
+ WorkflowOptimizerDecisionMode,
+ WorkflowOptimizerEvaluation,
+ WorkflowOptimizerEvaluator,
+} from "./graph-optimizer-types";
+export type {
+ WorkflowOptimizationPreview,
+ WorkflowOptimizerCandidate,
+ WorkflowOptimizerCandidateKind,
+ WorkflowOptimizerDecisionMode,
+ WorkflowOptimizerEvaluation,
+ WorkflowOptimizerEvaluator,
+ WorkflowOptimizerRisk,
+} from "./graph-optimizer-types";
function optimizerState(graph: WorkflowGraph, candidates: WorkflowOptimizerCandidate[]): Record<string, unknown> {
return {