Skip to content

armgit / mso

Public Imported from GitHub
0

Browser-based graphical shell and control plane for a Linux server you own — real terminal, file manager, live metrics and BYOK AI in one mobile-first workspace. Next.js 16 · React 19 · node-pty · Tailwind v4 · shadcn/ui. Public alpha, self-hosted.

docs(progress): record the integrations close-out, the reverted merge, and the traps

Abdurrahman Fakhrul8db474be8c6a
diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md
index b5cdc9dc..1f7497c2 100644
--- a/docs/CHANGELOG.md
+++ b/docs/CHANGELOG.md
@@ -8,7 +8,7 @@ this is the *what*, and it is what Settings → Account → About shows as “Wh
**Added**
-- `tui` @ addresses agents and MCP plugins, with / owning commands
+- `tui` @ addresses agents and MCP plugins, with / owning commands (#263)
- `tui` opencode batch three, from starved flags to a written contract (#258)
**Fixed**
diff --git a/docs/PROGRESS.md b/docs/PROGRESS.md
index 7184fedc..7e3c3862 100644
--- a/docs/PROGRESS.md
+++ b/docs/PROGRESS.md
@@ -1,3 +1,104 @@
+## 2026-11-03: integrations UI closed out, and one merged fix that had been silently deleted
+
+Everything below is merged. `main` at `269b6721`, working tree clean, gate green.
+
+### The finding that matters most
+
+PR #248 fixed four integration-UI defects, each with a test. **PR #249 (unrelated TUI feature
+work) overwrote two of the same files with stale copies**, removing the code *and the assertions
+that pinned it*. The gate stayed green because the tests vanished with the behaviour.
+
+What was actually gone from main, verified by reading the files rather than trusting the merge log:
+
+```
+role="alertdialog" on the delete confirmation missing
+Escape / focus return on that dialog missing
+.transfer-error styling missing
+.connection-state wrapping missing
+```
+
+Found by a browser audit, not by CI. `lib/infra/integration-ui-regressions.test.ts` now asserts them
+**by behaviour, reading the source directly**, so replacing a file wholesale fails there even if the
+original tests disappear with it.
+
+Lesson: a green gate after a merge proves nothing about whether the merge kept the previous work.
+A test file that a later PR can delete is not a guard.
+
+### Browser evidence, and why string tests kept lying
+
+Two UI claims in this work passed their tests while the browser disagreed:
+
+| claim | what the test checked | what the browser did |
+|---|---|---|
+| iOS auto-zoom fixed | `input[type=search]` | page uses `.integration .integration-sidebar-header>input[type=search]`, still 12px |
+| theme follows the shell | the two backgrounds *differ* | they differed because the OS differed, not because the app chose |
+
+`scripts/integrations-ui-evidence.mjs` now drives four viewports, light and dark, and a 240px-tall
+iframe, checking horizontal overflow, one `main`, one `h1`, 44px tap targets, accessible names, alt
+text, the 16px input threshold, keyboard reachability, focus visibility, console errors, and that a
+dark preference produces dark tokens. **43/43** on the current build.
+
+### Keyboard defects closed
+
+| defect | evidence |
+|---|---|
+| skip link pointed at `#main-content`, which wraps the menu bar, and was not focusable | `hash=#shell-main`, `activeElement=SECTION#shell-main` |
+| closed mobile drawer left 30 items in the tab order (31 invisible stops) | 10 Tabs, zero off-screen stops |
+| full-screen backdrop ignored Escape (handler lived on the panel) | Escape sets `data-open="false"` |
+| `<details>` "More" popover had no Escape and no outside-click close | both handled, focus returns to summary |
+
+Every shell (macOS, Windows, mobile) now carries `#shell-main` with `role="main"` and `tabIndex={-1}`.
+
+### A regression I caused, caught by the release E2E
+
+Marking the sidebar `inert` whenever `data-open` was false also hit the desktop layout, where the
+sidebar is a permanent visible column with `data-open="false"`. Every nav button became unclickable:
+
+```
+waiting for getByRole('button', { name: /^Convex$/ })
+<div class="integration-settings-shell"> intercepts pointer events
+```
+
+`verify-build.sh` caught it; the unit suite did not. The inert is now scoped to the 37.5rem compact
+breakpoint, matching the CSS rule that does the translating.
+
+### Dependencies, without force-merging
+
+Four Dependabot PRs could not merge cleanly. Each was rebased, `bun install`ed and gated on its own
+branch rather than merged as-is, because a lockfile resolved against an older tree is a guess.
+`@anthropic-ai/sdk` **0.135.0 -> 1.3.0** is a major jump, so it was verified at runtime
+(`messages.stream` is a function, constructor works) and then 6434 tests passed.
+
+The gate they were all failing was my own: it listed dependency bumps as user-facing changelog
+entries. It then failed a second time in a subtler way — the file depended on **when** it was
+regenerated, because a squash appends `" (#NNN)"` to the subject. That one was CI-only: local passed
+while GitHub's PR merge ref, which includes the squash, reported stale.
+
+### Traps that cost real time
+
+1. **A parallel track moved this session's worktree to `main` twice mid-run.** Commits appeared lost;
+ recovered from the reflog, then all further work moved to a dedicated worktree with a symlinked
+ `node_modules`.
+2. **`/tmp` filled to 78% with three out-of-tree builds.** The release E2E reported it as
+ `verification failed during mandatory release E2E`, which reads exactly like a code failure.
+ Cleaned; re-ran; passed.
+3. **A stale build directory made three evidence runs report false failures.** After changing
+ source, the harness must be rebuilt; check the build's own files before believing a red result.
+4. `git stash pop` after `git checkout main` silently dropped a change that the merge had already
+ taken; `gen-changelog --check` caught it, nothing else would have.
+
+### Deliberately not changed
+
+Disabled buttons render at `opacity .55`, giving 2.26:1 on "Add connection". WCAG 1.4.3 exempts
+disabled controls, so it is not a violation, but it reads as a broken button rather than a
+deliberately inactive one. The honest fix is a disabled state built from `color`/`background`
+instead of `opacity`, which is a design decision, not a bug fix.
+
+### Open
+
+- `perf-baseline.json` predates several dependency bumps. Re-measure on an idle host before trusting
+ the TBT comparison.
+- Three remote branches were left over and all already merged; deleted.
## 2026-11-01: the green full run, and the parallel-run trap
`bash scripts/gates-12.sh full` on the TUI panel branch: **passed=16, failed=0, skipped=1**. The