Skip to content

armgit / mso

Public Imported from GitHub
0

Browser-based graphical shell and control plane for a Linux server you own — real terminal, file manager, live metrics and BYOK AI in one mobile-first workspace. Next.js 16 · React 19 · node-pty · Tailwind v4 · shadcn/ui. Public alpha, self-hosted.

test(workflows): stabilize repeated artifact inspection journeys

Rahmanacb9ba27508f
diff --git a/docs/PROGRESS.md b/docs/PROGRESS.md
index cd1f1603..bb4d0390 100644
--- a/docs/PROGRESS.md
+++ b/docs/PROGRESS.md
@@ -31,6 +31,10 @@ UI ordering must not change the existing API default for an omitted connection s
The API retains its original direct default; the UI explicitly submits the selected OAuth
source, preserving both existing callers and OAuth-first presentation. Detailed verification
and release status belong to the workflow evidence; this entry does not claim deployment.
+The expanded browser acceptance now reseeds its synthetic Git history idempotently for
+all three viewports, waits for complete modal exit/focus cleanup, and asserts node-click
+selection before inspecting details. It does not replace a failed node click with a
+compact-toolbar fallback or skip any artifact, redaction, terminal or accessibility check.
## 2026-09-17 — GitHub OAuth-first Integrations routing
diff --git a/scripts/e2e/mcp-sessions.mjs b/scripts/e2e/mcp-sessions.mjs
index cff5c397..5d8d8445 100644
--- a/scripts/e2e/mcp-sessions.mjs
+++ b/scripts/e2e/mcp-sessions.mjs
@@ -88,10 +88,12 @@ export async function mcpSessionsJourney(page, fixture) {
await expect(page.locator('[data-slot="session-artifact-snapshot"]')).toBeVisible();
await expect(page.locator('[data-slot="session-artifact-diff"]')).toBeVisible();
expect(await page.locator('[data-slot="session-artifact-history"]').innerText()).not.toMatch(/FIXTURE_SECRET_MUST_NOT_LEAK/);
- const openDetailsOverlay = page.locator('[data-slot="sheet-overlay"][data-state="open"]');
- if (await openDetailsOverlay.count()) {
+ const artifactDialog = page.locator('[data-slot="shell-dialog-surface"]').filter({ has: page.locator('[data-slot="session-artifact-history"]') });
+ if (await artifactDialog.isVisible()) {
await page.keyboard.press("Escape");
- await expect(openDetailsOverlay).toHaveCount(0);
+ // A closed state is not an unmounted modal. Wait for its exit/focus cleanup
+ // before the next canvas click, for both desktop Sheet and mobile Drawer.
+ await expect(artifactDialog).toHaveCount(0);
}
const terminalStep = selectedGraph.steps.find(step => step.actions.some(action => action.terminalContext));
expect(terminalStep).toBeTruthy();
@@ -102,9 +104,9 @@ export async function mcpSessionsJourney(page, fixture) {
expect(await page.locator('[data-slot="workflows-feature"]').innerText()).not.toMatch(/\b\d{8}_\d{6}_[a-f0-9]{8}\b/);
await terminalStepNode.click();
const terminalActionGroups = page.getByText("Action groups", { exact: true }).last();
- if (!await terminalActionGroups.isVisible().catch(() => false)) {
- await page.getByRole("button", { name: "Session details", exact: true }).click();
- }
+ // Selection updates asynchronously; assert the promised node-click behavior
+ // instead of racing it with a fallback button that lives in compact overflow.
+ await expect(terminalStepNode).toHaveClass(/\bselected\b/);
await expect(terminalActionGroups).toBeVisible();
await expect(page.getByRole("button", { name: `Save ${terminalStep.ref} as workflow draft`, exact: true })).toBeVisible();
await expect(page.getByText("Self-improve", { exact: true }).last()).toBeVisible();
diff --git a/scripts/e2e/session-fixture.mjs b/scripts/e2e/session-fixture.mjs
index c95b26bd..682f7fab 100644
--- a/scripts/e2e/session-fixture.mjs
+++ b/scripts/e2e/session-fixture.mjs
@@ -1,4 +1,4 @@
-import { mkdir, writeFile } from "node:fs/promises";
+import { mkdir, writeFile, access } from "node:fs/promises";
import { execFileSync } from "node:child_process";
import { createHash } from "node:crypto";
import path from "node:path";
@@ -11,8 +11,13 @@ export async function seedSessionMonitor(env, count = 9) {
const original = "export const value = 1;\n", current = "export const value = 2;\n", artifactFile = path.join(project, "src", "fixture.ts");
await writeFile(artifactFile, original, { mode: 0o600 });
const git = (...args) => execFileSync("git", args, { cwd: project, encoding: "utf8" }).trim();
- git("init", "-b", "main"); git("config", "user.email", "[email protected]"); git("config", "user.name", "MSO Release Fixture");
- git("add", "src/fixture.ts"); git("commit", "-m", "fixture artifact");
+ // Each viewport reseeds the same synthetic store. Reuse the exact fixture
+ // commit instead of failing on a second commit with an unchanged index.
+ const initialized = await access(path.join(project, ".git")).then(() => true, () => false);
+ if (!initialized) git("init", "-b", "main");
+ git("config", "user.email", "[email protected]"); git("config", "user.name", "MSO Release Fixture");
+ git("add", "src/fixture.ts");
+ if (git("status", "--porcelain", "--", "src/fixture.ts")) git("commit", "-m", "fixture artifact");
const gitHead = git("rev-parse", "HEAD"), headBlob = git("rev-parse", "HEAD:src/fixture.ts"), worktreeSha256 = createHash("sha256").update(original).digest("hex");
const artifactRevision = { version: 1, cwd: project, relativePath: "src/fixture.ts", repoRoot: project, repoRelativePath: "src/fixture.ts", gitHead, headBlob, worktreeBlob: headBlob, worktreeSha256, bytes: Buffer.byteLength(original), cleanAtCapture: true };
await writeFile(artifactFile, current, { mode: 0o600 });
diff --git a/scripts/session-fixture.test.ts b/scripts/session-fixture.test.ts
new file mode 100644
index 00000000..cb17ffc8
--- /dev/null
+++ b/scripts/session-fixture.test.ts
@@ -0,0 +1,27 @@
+import { mkdtemp, readFile, rm } from "node:fs/promises";
+import { execFileSync } from "node:child_process";
+import os from "node:os";
+import path from "node:path";
+import { expect, it } from "vitest";
+import { seedSessionMonitor } from "./e2e/session-fixture.mjs";
+
+it("reseeds all responsive journeys without rewriting the synthetic artifact commit", async () => {
+ const root = await mkdtemp(path.join(os.tmpdir(), "mso-session-seed-test-"));
+ try {
+ const env = { OS_AGENT_SESSIONS_DIR: path.join(root, "sessions"), OS_LOCAL_AGENT_PRESENCE_STORE: path.join(root, "presence.json") };
+ let firstHead: string | undefined;
+ for (let pass = 0; pass < 3; pass++) {
+ await seedSessionMonitor(env);
+ const row = JSON.parse(await readFile(path.join(env.OS_AGENT_SESSIONS_DIR, "20260909_120000_00000000.json"), "utf8"));
+ const captured = row.events[0].artifactRevision;
+ firstHead ??= captured.gitHead;
+ expect(captured.gitHead).toBe(firstHead);
+ expect(captured.cleanAtCapture).toBe(true);
+ expect(await readFile(path.join(root, "session-project/src/fixture.ts"), "utf8")).toBe("export const value = 2;\n");
+ const original = execFileSync("git", ["show", `${captured.gitHead}:src/fixture.ts`], { cwd: path.join(root, "session-project"), encoding: "utf8" });
+ expect(original).toBe("export const value = 1;\n");
+ const presence = JSON.parse(await readFile(env.OS_LOCAL_AGENT_PRESENCE_STORE, "utf8"));
+ expect(presence.entries).toHaveLength(9);
+ }
+ } finally { await rm(root, { recursive: true, force: true }); }
+});