Skip to content

armgit / mso

Public Imported from GitHub
0

Browser-based graphical shell and control plane for a Linux server you own — real terminal, file manager, live metrics and BYOK AI in one mobile-first workspace. Next.js 16 · React 19 · node-pty · Tailwind v4 · shadcn/ui. Public alpha, self-hosted.

test(oauth): receive consent callbacks outside the shell

Abdurrahman Fakhrulc4cc3ed0a21d
diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md
index 0f099034..be1bcae3 100644
--- a/docs/CHANGELOG.md
+++ b/docs/CHANGELOG.md
@@ -13,6 +13,7 @@ this is the *what*, and it is what Settings → Account → About shows as “Wh
**Tests**
+- `oauth` receive consent callbacks outside the shell
- `security` exercise webhook admission with explicit proxy trust
- `auth` isolate default proxy policy from host configuration
diff --git a/docs/PROGRESS.md b/docs/PROGRESS.md
index 0a3ba345..a15564d8 100644
--- a/docs/PROGRESS.md
+++ b/docs/PROGRESS.md
@@ -1,3 +1,7 @@
+## 2026-10-10: Give the OAuth browser fixture its own callback receiver
+
+GitHub's required browser journey reached the synthetic OAuth callback and then mounted the catch-all MSO shell, which rewrote that unknown client path to the previously focused Settings window before the URL assertion. The fixture now supplies a bounded HTML callback receiver and removes it after testing. Actual registration, exact callback validation, PKCE exchange, state, pruned/manual-client refusal and desktop/mobile checks remain unchanged; production routes and security gates are not relaxed.
+
## 2026-10-09: Reuse MSO login for reviewed private applications
The bootstrap JavaScript is static: the login destination lives in percent-encoded HTML data, never code construction. A hostile app identifier cannot change the script or escape its data attribute; regression coverage executes the no-ticket redirect with hostile metadata.
diff --git a/scripts/e2e/mcp-settings.mjs b/scripts/e2e/mcp-settings.mjs
index ed7f9bf3..993ca0ae 100644
--- a/scripts/e2e/mcp-settings.mjs
+++ b/scripts/e2e/mcp-settings.mjs
@@ -142,6 +142,10 @@ export async function oauthRegistrationJourney(page, fixture) {
const callback = fixture.base + "/oauth-fixture-callback", verifier = "v".repeat(43);
const challenge = createHash("sha256").update(verifier).digest("base64url");
const consent = (clientId, redirectUri = callback) => fixture.base + "/oauth/authorize?" + new URLSearchParams({ client_id: clientId, redirect_uri: redirectUri, code_challenge: challenge, code_challenge_method: "S256", resource: fixture.base + "/mcp", state: "fixture-state", scope: "read" });
+ // The synthetic OAuth client must receive the callback instead of mounting the MSO shell.
+ const receiveCallback = route => route.fulfill({ status: 200, contentType: "text/html", body: "<!doctype html><title>OAuth fixture callback</title>" });
+ await page.route(callback + "?*", receiveCallback);
+ try {
for (const viewport of [{ width: 1280, height: 900 }, { width: 390, height: 844 }]) {
await page.setViewportSize(viewport);
await page.goto(consent("chatgpt-mso", "https://attacker.invalid/callback"));
@@ -170,4 +174,5 @@ export async function oauthRegistrationJourney(page, fixture) {
await expect(page.getByRole("button", { name: "Allow", exact: true })).toHaveCount(0);
}
console.log("PASS actual OAuth registered consent/exchange and manual/pruned callback denial on desktop/mobile");
+ } finally { await page.unroute(callback + "?*", receiveCallback); }
}