Skip to content

armgit / mso

Public Imported from GitHub
0

Browser-based graphical shell and control plane for a Linux server you own — real terminal, file manager, live metrics and BYOK AI in one mobile-first workspace. Next.js 16 · React 19 · node-pty · Tailwind v4 · shadcn/ui. Public alpha, self-hosted.

fix(security): key portable import preview confirmations

Rahmanc5e361edf2e9
diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md
index 2dc3cbe8..2209b39f 100644
--- a/docs/CHANGELOG.md
+++ b/docs/CHANGELOG.md
@@ -19,6 +19,7 @@ this is the *what*, and it is what Settings → About shows as “What's new”.
**Fixed**
+- `security` key portable import preview confirmations
- `mcp` render one bounded inline Page preview
- preserve home-relative stores and prove tunnel rollback completion
- `security` verify exact branch dispositions and narrow message origins
diff --git a/lib/infra/portable/data.test.ts b/lib/infra/portable/data.test.ts
index 76ee1df2..13955c58 100644
--- a/lib/infra/portable/data.test.ts
+++ b/lib/infra/portable/data.test.ts
@@ -1,4 +1,5 @@
import {beforeEach,afterEach,it,expect,vi} from 'vitest';
+import {createHash} from 'node:crypto';
import {promises as fs} from 'node:fs';import os from 'node:os';import path from 'node:path';
import sample from '@/schemas/integration-bundle-example.json';
vi.mock('server-only',()=>({}));
@@ -14,6 +15,14 @@ it('previews SC format without writing and imports mapped identities, not role/d
expect(state.defaultUser).toBeNull();expect(state.bindings).toEqual([]);expect(state.users['sample-user'].defaults).toEqual({});
expect(state.users['sample-user'].connections.github.work.authMethod).toBe('direct');expect(state.users['sample-user'].connections.github.work.values).toEqual({});
});
+it('uses a keyed preview confirmation instead of exposing a plain digest of imported values',async()=>{
+ const codec=await import('./codec.js'),api=await import('./data'),{readIntegrationState}=await import('../connection-storage');
+ const payload=codec.validate({...structuredClone(sample),mode:'secrets'},true);payload.users[0].connections[0].values={GITHUB_TOKEN:KEY,GH_OWNER:'sample-org'};
+ const envelope=await codec.seal(payload,PASS),preview=await api.importIntegrationData(envelope,{passphrase:PASS}),state=await readIntegrationState();
+ const plain=createHash('sha256').update(JSON.stringify([payload,'','skip',state.users,state.defaultUser,state.bindings])).digest('hex');
+ expect(preview.planId).toMatch(/^[a-f0-9]{64}$/);expect(preview.planId).not.toBe(plain);
+ expect((await api.importIntegrationData(envelope,{passphrase:PASS})).planId).toBe(preview.planId);
+});
it('roundtrips encrypted direct fields and rejects incorrect passphrase without mutation',async()=>{
const codec=await import('./codec.js'),api=await import('./data'),{readIntegrationState}=await import('../connection-storage');
const payload=codec.validate({...structuredClone(sample),mode:'secrets'},true);payload.users[0].connections[0].values={GITHUB_TOKEN:KEY,GH_OWNER:'sample-org'};
diff --git a/lib/infra/portable/data.ts b/lib/infra/portable/data.ts
index 494eba91..2f7bffb9 100644
--- a/lib/infra/portable/data.ts
+++ b/lib/infra/portable/data.ts
@@ -1,4 +1,4 @@
-import {createHash,randomUUID} from 'node:crypto';
+import {createHmac,randomBytes,randomUUID} from 'node:crypto';
import * as codec from './codec.js';
import {FIELD_MAP,wireMethod,nativeMethod} from './mapping';
import {readIntegrationState,mutateIntegrationState} from '../connection-storage';
@@ -6,6 +6,10 @@ import {connectionMethod} from '../connection-registry';
import {IntegrationError,identity,type IntegrationState} from '../identity';
import {isInfraProviderId,normalizeInfraValues} from '../catalog';
export type TransferOptions={users?:string[];includeSecrets?:boolean;passphrase?:string;prefix?:string;policy?:'skip'|'error';apply?:boolean;confirm?:string;acceptWarnings?:boolean};
+// Preview confirmation must bind the exact decrypted bundle without exposing an
+// unkeyed digest of credential values as an offline guessing oracle. A process-local
+// random key intentionally invalidates pending previews after a server restart.
+const PLAN_KEY=randomBytes(32);
export async function exportIntegrationData(options:TransferOptions={}){
const state=await readIntegrationState(),ids=options.users??Object.keys(state.users);
if(!Array.isArray(ids)||ids.some(id=>!Object.hasOwn(state.users,identity(id))))throw new IntegrationError('unknown_export_user');
@@ -37,7 +41,7 @@ function previewIn(bundle:codec.Bundle,options:TransferOptions,state:Integration
}
}
// Exclude random empty-store instance IDs; bind the preview to all persisted destination data.
- const planId=createHash('sha256').update(JSON.stringify([bundle,prefix,policy,state.users,state.defaultUser,state.bindings])).digest('hex');
+ const planId=createHmac('sha256',PLAN_KEY).update(JSON.stringify([bundle,prefix,policy,state.users,state.defaultUser,state.bindings])).digest('hex');
return{preview:{planId,mode:bundle.mode,producer:bundle.producer.name,createUsers:users,connections:rows,warnings,canApply:policy!=='error'||!rows.some(r=>r.status==='skip'),requiresWarningAcceptance:warnings.length>0,defaultsChanged:false,folderBindingsImported:false,verified:false},pending};
}
export async function importIntegrationData(document:unknown,options:TransferOptions={}){