Browser-based graphical shell and control plane for a Linux server you own — real terminal, file manager, live metrics and BYOK AI in one mobile-first workspace. Next.js 16 · React 19 · node-pty · Tailwind v4 · shadcn/ui. Public alpha, self-hosted.
TypeScript browser-shellcontrol-planefile-managerhomelabmobile-firstnextjsptyreactself-hostedserver-managementshadcn-uisysadmintailwindcssterminaltypescriptvpsweb-desktopweb-terminal
chore(security): expose sanitized alert annotations
Rahmandd6ee465a75a
diff --git a/scripts/security-alerts.mjs b/scripts/security-alerts.mjsindex 53bd8dbd..e9718665 100644--- a/scripts/security-alerts.mjs+++ b/scripts/security-alerts.mjs@@ -45,6 +45,20 @@ function descriptor(alert) {dismissed_reason: alert.dismissed_reason, dismissed_comment: alert.dismissed_comment,location: alert.most_recent_instance?.location };}+function commandValue(value) {+ return String(value ?? "").replace(/%/g, "%25").replace(/\r/g, "%0D").replace(/\n/g, "%0A").replace(/:/g, "%3A").replace(/,/g, "%2C");+}+function emitAnnotation(alert) {+ // Make the actual open finding visible through the public check-run annotation API.+ // Only rule/path/line/number are emitted; no snippets, secret values, or dismissal text.+ const location = alert.instances?.[0]?.location ?? alert.location ?? {};+ const rawPath = typeof location.path === "string" ? location.path : ".github";+ const safePath = /^[A-Za-z0-9_./-]{1,500}$/.test(rawPath) && !rawPath.includes("..") ? rawPath : ".github";+ const line = Number.isSafeInteger(location.start_line) && location.start_line > 0 ? location.start_line : 1;+ const rule = typeof alert.rule?.id === "string" ? alert.rule.id.slice(0, 160) : "unknown-rule";+ const severity = alert.rule?.security_severity_level ?? alert.rule?.severity ?? "unknown";+ console.log(`::warning file=${commandValue(safePath)},line=${line},title=${commandValue(`Code scanning #${alert.number} · ${rule}`)}::${commandValue(`${severity} finding remains open`)}`);+}try {const repository = (await get("")).value;const ref = selectedRef ?? `refs/heads/${repository.default_branch}`;@@ -74,7 +88,7 @@ try {console.log(`CODE_SCANNING_REF ${ref}`);console.log(`CODE_SCANNING_HEAD ${report.head}`);console.log(`CODE_SCANNING_OPEN ${rows.length}`);- for (const alert of rows) console.log(`ALERT ${JSON.stringify(alert)}`);+ for (const alert of rows) { console.log(`ALERT ${JSON.stringify(alert)}`); emitAnnotation(alert); }for (const alert of closed) console.log(`CLOSED_ALERT ${JSON.stringify(alert)}`);console.log(`CODE_SCANNING_REPORT ${JSON.stringify(report)}`);console.log("No alert was dismissed or deleted by this read-only verification.");diff --git a/scripts/security-alerts.test.ts b/scripts/security-alerts.test.tsindex c979ecfd..9f3f5c6d 100644--- a/scripts/security-alerts.test.ts+++ b/scripts/security-alerts.test.ts@@ -6,16 +6,16 @@ import { afterEach, describe, expect, it } from "vitest";const roots: string[] = [];afterEach(() => { for (const root of roots.splice(0)) rmSync(root, { recursive: true, force: true }); });-function run(options: { count?: number; denied?: boolean; noAnalysis?: boolean; paginate?: boolean; stale?: boolean } = {}) {+function run(options: { count?: number; denied?: boolean; noAnalysis?: boolean; paginate?: boolean; stale?: boolean; hostile?: boolean } = {}) {const root = mkdtempSync(path.join(tmpdir(), "mso-alert-report-test-")); roots.push(root);const stub = `const options=${JSON.stringify(options)};globalThis.fetch=async(url)=>{if(options.denied)return new Response('{}',{status:403});let value={default_branch:'main'};let headers={};if(url.includes('/branches/'))value={commit:{sha:'a'.repeat(40)}};- if(url.includes('/alerts?')){value=Array.from({length:options.count??0},(_,i)=>({number:i+1,state:'open',tool:{name:'CodeQL'},rule:{id:'js/test',severity:'warning'}}));+ if(url.includes('/alerts?')){value=Array.from({length:options.count??0},(_,i)=>({number:i+1,state:'open',tool:{name:'CodeQL'},rule:{id:options.hostile?'js/test%0A::error::boom':'js/test',severity:'warning',security_severity_level:'high'}}));if(options.paginate){if(url.includes('page=2'))value=[];else headers={link:'<https://api.github.com/next>; rel="next"'};}}- if(url.includes('/instances?'))value=[{ref:'refs/heads/main',state:'open',location:{path:'lib/test.ts',start_line:3},message:{text:'review me'}}];+ if(url.includes('/instances?'))value=[{ref:'refs/heads/main',state:'open',location:{path:options.hostile?'../escape.ts':'lib/test.ts',start_line:3},message:{text:'review me'}}];if(url.includes('/analyses?'))value=options.noAnalysis?[]:[{id:1,commit_sha:(options.stale?'b':'a').repeat(40),tool:{name:'CodeQL'},ref:'refs/heads/main'}];return new Response(JSON.stringify(value),{status:200,headers});};await import(${JSON.stringify(path.join(process.cwd(), "scripts/security-alerts.mjs"))});`;@@ -29,6 +29,12 @@ describe("GitHub open-alert evidence", () => {it("does not turn 21 open alerts into a successful security check", () => {const result = run({ count: 21 }); expect(result.status).toBe(1); expect(result.report?.openCount).toBe(21);expect(result.stdout).not.toContain("synthetic-test-value"); expect(result.stderr).not.toContain("synthetic-test-value");+ expect(result.stdout).toContain("::warning file=lib/test.ts,line=3,title=Code scanning #1 · js/test::high finding remains open");+ });+ it("sanitizes workflow-command metadata before exposing alert annotations", () => {+ const result = run({ count: 1, hostile: true });+ expect(result.status).toBe(1); expect(result.stdout).toContain("file=.github,line=3");+ expect(result.stdout).toContain("%250A"); expect(result.stdout).not.toContain("\n::error::boom");});it("accepts zero findings only with scan evidence", () => { const result = run(); expect(result.status).toBe(0); expect(result.report?.openCount).toBe(0); });it("fails closed on a denied security inventory", () => { const result = run({ denied: true }); expect(result.status).toBe(2); expect(result.stderr).toContain("INCOMPLETE"); });