Browser-based graphical shell and control plane for a Linux server you own — real terminal, file manager, live metrics and BYOK AI in one mobile-first workspace. Next.js 16 · React 19 · node-pty · Tailwind v4 · shadcn/ui. Public alpha, self-hosted.
TypeScript browser-shellcontrol-planefile-managerhomelabmobile-firstnextjsptyreactself-hostedserver-managementshadcn-uisysadmintailwindcssterminaltypescriptvpsweb-desktopweb-terminal
fix(workflows): separate runtime input from graph secret guards
Rahmane83291a45d68
diff --git a/app/api/v1/workflows/webhook/[...hook]/route.ts b/app/api/v1/workflows/webhook/[...hook]/route.tsindex f80c9900..cf76aba8 100644--- a/app/api/v1/workflows/webhook/[...hook]/route.ts+++ b/app/api/v1/workflows/webhook/[...hook]/route.ts@@ -8,7 +8,7 @@ import { startWorkflowGraph, workflowGraphRunStatus } from "@/lib/workflow/graphimport { workflowVariableValues } from "@/lib/workflow/variables";export const runtime="nodejs";export const dynamic="force-dynamic";function same(a:string,b:string){const x=Buffer.from(a),y=Buffer.from(b);return x.length===y.length&&timingSafeEqual(x,y);}-async function payload(req:NextRequest){const length=Number(req.headers.get("content-length")||0);if(length>64*1024)throw new Error("webhook body too large");let body:unknown=null;if(!["GET","HEAD"].includes(req.method)){const text=await req.text();if(Buffer.byteLength(text)>64*1024)throw new Error("webhook body too large");try{body=text?JSON.parse(text):null;}catch{body=text;}}return{method:req.method,query:Object.fromEntries(req.nextUrl.searchParams),headers:{"content-type":req.headers.get("content-type")||undefined,"user-agent":req.headers.get("user-agent")||undefined,"x-request-id":req.headers.get("x-request-id")||undefined},body};}+async function payload(req:NextRequest){const length=Number(req.headers.get("content-length")||0);if(length>64*1024)throw new Error("webhook body too large");let body:unknown=null;if(!["GET","HEAD"].includes(req.method)){const text=await req.text();if(Buffer.byteLength(text)>64*1024)throw new Error("webhook body too large");try{body=text?JSON.parse(text):null;}catch{body=text;}}return{method:req.method,query:Object.fromEntries(req.nextUrl.searchParams),httpHeaders:{"content-type":req.headers.get("content-type")||undefined,"user-agent":req.headers.get("user-agent")||undefined,"x-request-id":req.headers.get("x-request-id")||undefined},body};}async function handle(req:NextRequest,ctx:{params:Promise<{hook:string[]}>}){try{const {hook}=await ctx.params;if(hook.length!==2)return NextResponse.json({error:"webhook_not_found"},{status:404});const source=await findActiveWebhookSource(hook[0]!,hook[1]!);if(!source)return NextResponse.json({error:"webhook_not_found"},{status:404});const methods=Array.isArray(source.node.config.methods)?source.node.config.methods.map(String):["POST"];if(!methods.includes(req.method))return NextResponse.json({error:"method_not_allowed"},{status:405,headers:{Allow:methods.join(", ")}});if(rateLimited(`workflow-webhook:${source.graph.id}:${source.node.id}`,120,60_000))return NextResponse.json({error:"rate_limited"},{status:429});const authVar=typeof source.node.config.authVariable==="string"?source.node.config.authVariable:"";if(authVar){const vars=await workflowVariableValues(source.principal),expected=vars[authVar];if(typeof expected!=="string")return NextResponse.json({error:"webhook_auth_not_configured"},{status:503});const raw=req.headers.get("authorization")?.replace(/^Bearer\s+/i,"")??req.headers.get("x-webhook-token")??"";if(!same(raw,expected))return NextResponse.json({error:"unauthorized"},{status:401});}const input=await payload(req),session=await createAgentSession(source.principal,"cli",{title:`Webhook: ${source.graph.name}`,titleSource:"auto"}),{TOOLS_BY_NAME}=await import("@/lib/mcp/tools"),key=(req.headers.get("idempotency-key")||`webhook-${crypto.randomUUID()}`).slice(0,128),context={principal:source.principal,actor:source.principal,sessionId:session.id,scope:maxScope()} as const;const started=await startWorkflowGraph(source.graph,input,key,context,(name)=>TOOLS_BY_NAME.get(name),source.principal,{type:"webhook",nodeId:source.node.id,receivedAt:new Date().toISOString()});if(source.node.config.responseMode!=="lastNode")return NextResponse.json({runId:started.id,state:started.state},{status:202});const done=await workflowGraphRunStatus(source.principal,started.id,25_000),output=[...done.nodes].reverse().find((node)=>node.type==="output"&&node.output!==undefined)?.output;return NextResponse.json({runId:done.id,state:done.state,output},{status:done.state==="failed"?500:200});}catch(error){return NextResponse.json({error:error instanceof Error?error.message.slice(0,300):"webhook_failed"},{status:400});}}export const GET=handle;export const POST=handle;export const PUT=handle;export const PATCH=handle;export const DELETE=handle;diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.mdindex ae6e3a98..4e23effc 100644--- a/docs/CHANGELOG.md+++ b/docs/CHANGELOG.md@@ -13,6 +13,7 @@ this is the *what*, and it is what Settings → About shows as “What's new”.**Fixed**+- `workflows` separate runtime input from graph secret guards- `workflows` allow inbound webhook trigger boundary- `workflows` honor responsive shell modal policy- `workflows` compact graph mcp surfacediff --git a/lib/workflow/graph-engine.test.ts b/lib/workflow/graph-engine.test.tsindex ec949b18..6969d7f3 100644--- a/lib/workflow/graph-engine.test.ts+++ b/lib/workflow/graph-engine.test.ts@@ -100,4 +100,15 @@ describe("workflow graph engine", () => {const recursive = await startWorkflowGraph(parent, {}, "subflow-recursive", context, () => undefined), recursiveDone = await workflowGraphRunStatus("graph-owner", recursive.id, 5000);expect(recursiveDone.state).toBe("failed"); expect(recursiveDone.nodes.find((node) => node.id === "child")?.error).toContain("recursive");});+ it("accepts secret-shaped runtime input but redacts it from persisted trigger receipts", async () => {+ const graph = await createWorkflowGraph("graph-owner", { name: "Runtime input", description: "", status: "draft", inputs: {}, metadata: {}, nodes: [+ { id: "start-runtime", name: "Webhook", type: "webhook", position: { x: 0, y: 0 }, config: {} },+ { id: "runtime-out", name: "Out", type: "output", position: { x: 100, y: 0 }, config: { value: { ok: true } } },+ ], edges: [{ id: "runtime-e", source: "start-runtime", target: "runtime-out" }] });+ const started = await startWorkflowGraph(graph, { headers: { authorization: "Bearer abc" }, body: { token: "incoming-token", safe: "visible" } }, "runtime-secret-input", context, () => undefined, "graph-owner", { type: "webhook", nodeId: "start-runtime", receivedAt: new Date().toISOString() });+ const done = await workflowGraphRunStatus("graph-owner", started.id, 5000), receipt = JSON.stringify(done);+ expect(done.state).toBe("completed");+ expect(receipt).not.toContain("Bearer abc"); expect(receipt).not.toContain("incoming-token"); expect(receipt).toContain("[REDACTED]"); expect(receipt).toContain("visible");+ });+});diff --git a/lib/workflow/graph-engine.ts b/lib/workflow/graph-engine.tsindex f2236c6a..3aaec468 100644--- a/lib/workflow/graph-engine.ts+++ b/lib/workflow/graph-engine.ts@@ -2,7 +2,7 @@ import { createHash, randomUUID } from "node:crypto";import type { CapabilityRunContext, CapabilityTool } from "@/lib/capabilities/tool";import type { WorkflowGraph, WorkflowGraphRun } from "@/lib/contracts/workflow-graph";import { redactText } from "@/lib/security/redact-text";-import { assertWorkflowMetadataOnly, graphObject } from "./graph-schema";+import { graphObject } from "./graph-schema";import { workflowGraphOwner } from "./graph-store";import { compact, executeNode } from "./graph-runtime";import { lockWorkflowGraphRun, pruneWorkflowGraphRuns, publicWorkflowGraphRun, readWorkflowGraphRun, writeWorkflowGraphRun } from "./graph-run-store";@@ -15,11 +15,21 @@ type Resolver = (name: string) => CapabilityTool | undefined;export type WorkflowRunTrigger = WorkflowGraphRun["trigger"];function hash(value: string): string { return createHash("sha256").update(value).digest("hex"); }function canonical(value: unknown): string { if (Array.isArray(value)) return `[${value.map(canonical).join(",")}]`; if (value && typeof value === "object") return `{${Object.entries(value).sort(([a],[b])=>a.localeCompare(b)).map(([k,v])=>`${JSON.stringify(k)}:${canonical(v)}`).join(",")}}`; return JSON.stringify(value); }-function inputObject(raw: unknown): Record<string, unknown> { if (!graphObject(raw) || Buffer.byteLength(JSON.stringify(raw)) > 64 * 1024) throw new Error("workflow graph input must be an object up to 64 KiB"); assertWorkflowMetadataOnly(raw); return structuredClone(raw); }+function assertRuntimeInput(value: unknown, depth = 0): void {+ if (depth > 14) throw new Error("workflow runtime input too deep");+ if (Array.isArray(value)) { value.forEach((item) => assertRuntimeInput(item, depth + 1)); return; }+ if (!graphObject(value)) return;+ for (const [key, child] of Object.entries(value)) {+ if (["__proto__", "constructor", "prototype"].includes(key)) throw new Error("workflow runtime input contains an unsafe key");+ assertRuntimeInput(child, depth + 1);+ }+}+function inputObject(raw: unknown): Record<string, unknown> { if (!graphObject(raw) || Buffer.byteLength(JSON.stringify(raw)) > 64 * 1024) throw new Error("workflow graph input must be an object up to 64 KiB"); assertRuntimeInput(raw); return structuredClone(raw); }function retryPolicy(node: WorkflowGraph["nodes"][number]) { const raw = graphObject(node.config.retry) ? node.config.retry : {}; return { maxAttempts: Math.max(1, Math.min(5, Math.trunc(Number(raw.maxAttempts) || 1))), backoffMs: Math.max(0, Math.min(30_000, Math.trunc(Number(raw.backoffMs) || 0))) }; }function sleep(ms:number){return ms?new Promise((resolve)=>setTimeout(resolve,ms)):Promise.resolve();}function secretText(text:string,secrets:string[]){let out=text;for(const value of secrets)out=out.split(value).join("[REDACTED]");return out;}-function secretValue(value:unknown,secrets:string[],depth=0):unknown{if(depth>14)return "[TRUNCATED]";if(typeof value==="string")return secretText(value,secrets);if(Array.isArray(value))return value.map((item)=>secretValue(item,secrets,depth+1));if(value&&typeof value==="object")return Object.fromEntries(Object.entries(value).map(([key,child])=>[key,secretValue(child,secrets,depth+1)]));return value;}+const RECEIPT_SECRET_KEY = /^(secrets?|secretValue|password|passphrase|token|apiKey|apiToken|accessToken|refreshToken|authorization|headers|cookie|cookies)$/i;+function secretValue(value:unknown,secrets:string[],depth=0):unknown{if(depth>14)return "[TRUNCATED]";if(typeof value==="string")return secretText(value,secrets);if(Array.isArray(value))return value.map((item)=>secretValue(item,secrets,depth+1));if(value&&typeof value==="object")return Object.fromEntries(Object.entries(value).map(([key,child])=>[key,RECEIPT_SECRET_KEY.test(key)?"[REDACTED]":secretValue(child,secrets,depth+1)]));return value;}async function execute(run: WorkflowGraphRun, graph: WorkflowGraph, input: Record<string, unknown>, context: CapabilityRunContext, resolve: Resolver): Promise<void> {const rows = new Map(run.nodes.map((row) => [row.id, row])), outputs: Record<string, unknown> = {}, secrets = await workflowSecretValues(context.principal ?? context.actor ?? ""), edgeState = new Map(graph.edges.map((edge) => [edge.id, "pending" as "pending"|"enabled"|"disabled"]));