Skip to content

armgit / mso

Public Imported from GitHub
0

Browser-based graphical shell and control plane for a Linux server you own — real terminal, file manager, live metrics and BYOK AI in one mobile-first workspace. Next.js 16 · React 19 · node-pty · Tailwind v4 · shadcn/ui. Public alpha, self-hosted.

fix(ci): stop the CodeQL analysis job from gating on open alerts

Abdurrahman Fakhrulede443913751
diff --git a/.github/workflows/codeql.yml b/.github/workflows/codeql.yml
index cadc5aee..a848b888 100644
--- a/.github/workflows/codeql.yml
+++ b/.github/workflows/codeql.yml
@@ -43,8 +43,12 @@ jobs:
- name: Report every result from this exact CodeQL analysis
run: node scripts/codeql-report.mjs "$RUNNER_TEMP/mso-codeql-results"
+ # Report-only here on purpose. The failing gate for open findings is security-alerts.yml, and
+ # having this step fail too made a closed loop: one open alert turned the analysis run red,
+ # Scorecard then counted that commit as not SAST-checked, and its SASTID alert stayed open --
+ # which kept this step red. The analysis job's output is SARIF; the gate belongs in one place.
- name: Inspect actual CodeQL branch findings after SARIF processing
if: github.event_name == 'push'
- run: node scripts/security-alerts.mjs --tool CodeQL --include-closed --ref "$GITHUB_REF" --commit "$GITHUB_SHA" --wait-seconds 60
+ run: node scripts/security-alerts.mjs --inventory --tool CodeQL --include-closed --ref "$GITHUB_REF" --commit "$GITHUB_SHA" --wait-seconds 60
env:
GITHUB_TOKEN: ${{ github.token }}
diff --git a/scripts/security-alerts.test.ts b/scripts/security-alerts.test.ts
index 87d89d74..4b2879cf 100644
--- a/scripts/security-alerts.test.ts
+++ b/scripts/security-alerts.test.ts
@@ -110,14 +110,20 @@ it("keeps hosted inventories strict, bounded and pinned to the checkout SHA", ()
for (const command of commands) {
expect(command).toContain('--commit "$GITHUB_SHA"');
expect(command).toMatch(/--wait-seconds (60|360)$/);
- expect(command).not.toContain("--inventory"); expect(command).not.toContain("|| true");
+ expect(command).not.toContain("|| true");
}
expect(source).not.toContain("continue-on-error: true");
if (file === "security-alerts.yml") {
+ // This file is the gate: it must fail when findings remain.
+ expect(commands.every(command => !command.includes("--inventory"))).toBe(true);
expect(commands.every(command => !command.includes("--tool"))).toBe(true);
expect(source).toContain("${{ github.event_name }}-${{ github.event.workflow_run.name || 'direct' }}");
} else {
+ // CodeQL's analysis job only reports. It used to gate as well, which made a closed loop: one
+ // open alert turned the analysis red, Scorecard then counted that commit as not SAST-checked,
+ // and its SASTID alert stayed open, keeping this step red. The gate lives in one place.
expect(commands.every(command => command.includes("--tool CodeQL"))).toBe(true);
+ expect(commands.every(command => command.includes("--inventory"))).toBe(true);
}
}
});