Skip to content

armgit / mso

Public Imported from GitHub
0

Browser-based graphical shell and control plane for a Linux server you own — real terminal, file manager, live metrics and BYOK AI in one mobile-first workspace. Next.js 16 · React 19 · node-pty · Tailwind v4 · shadcn/ui. Public alpha, self-hosted.

fix(plugin): bind ChatGPT app by stable app id only

Rahmanf30b77d5b9c3
diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md
index aadc667c..e73138f7 100644
--- a/docs/CHANGELOG.md
+++ b/docs/CHANGELOG.md
@@ -14,6 +14,7 @@ this is the *what*, and it is what Settings → About shows as “What's new”.
**Fixed**
+- `plugin` bind ChatGPT app by stable app id only
- `cli` keep candidate command parser strict
- `plugin` keep OpenAI app binding private per install
- `security` keep remote-authority test shell path trusted
diff --git a/docs/CHATGPT-PLUGIN.md b/docs/CHATGPT-PLUGIN.md
index 506b331f..f9b366d8 100644
--- a/docs/CHATGPT-PLUGIN.md
+++ b/docs/CHATGPT-PLUGIN.md
@@ -236,6 +236,6 @@ The live diagnostic `GET /mcp` returns both `toolset` (full MSO) and `chatgptToo
The source repository intentionally keeps `.app.json` free of maintainer-specific App IDs. Each installation can create an **OpenAI / ChatGPT App** connection in MSO Integrations. The registered App ID is stored only in the owner-private integration store and is redacted from model/tool responses.
-To obtain the ID, enable ChatGPT developer mode, register the installation's remote `/mcp` endpoint, complete **Scan Tools** and OAuth, then copy the **App ID** from the registered app details. A browser URL may expose the equivalent technical `plugin_asdk_app_...` identifier; MSO normalizes that to canonical `asdk_app_...`. A Version ID is optional operator metadata and is never used as the plugin binding.
+To obtain the ID, enable ChatGPT developer mode, register the installation's remote `/mcp` endpoint, complete **Scan Tools** and OAuth, then copy the **App ID** from the registered app details. A browser URL may expose the equivalent technical `plugin_asdk_app_...` identifier; MSO normalizes that to canonical `asdk_app_...`. The Version ID shown by ChatGPT is version-scoped metadata and is intentionally not stored or used by MSO.
Use `bun run plugin:stage-private` to create an owner-private plugin package at `~/.mso/private/plugin-packages/mso`. Its generated `.app.json` contains the selected installation's binding, while the Git checkout remains portable. `bun run plugin:link-app` without an explicit ID resolves the default private Integrations connection and redacts the ID from stdout. Explicit ID arguments remain only for compatibility/tests and should not be used for personal IDs in shell history.
diff --git a/docs/integrations/CHATGPT-UI.md b/docs/integrations/CHATGPT-UI.md
index abb9f7e1..26ccf061 100644
--- a/docs/integrations/CHATGPT-UI.md
+++ b/docs/integrations/CHATGPT-UI.md
@@ -111,4 +111,4 @@ Official references:
Native MSO UI must be invoked through the registered ChatGPT MCP App rather than a nested function wrapper. Each MSO installation therefore keeps its registered OpenAI App ID in the owner-private **OpenAI / ChatGPT App** Integrations connection. The public source repository does not contain the maintainer's App ID.
-Users get their own ID by enabling ChatGPT developer mode, registering their MSO remote MCP endpoint, completing tool scan/OAuth, and copying the App ID from app details (or the equivalent `plugin_asdk_app_...` technical ID from the browser URL). The private staging command writes canonical `asdk_app_...` only into the owner-private package. Version IDs are not valid substitutes for App IDs.
+Users get their own ID by enabling ChatGPT developer mode, registering their MSO remote MCP endpoint, completing tool scan/OAuth, and copying the App ID from app details (or the equivalent `plugin_asdk_app_...` technical ID from the browser URL). The private staging command writes canonical `asdk_app_...` only into the owner-private package. Version IDs are version-scoped metadata; MSO intentionally does not store or use them.
diff --git a/lib/infra/additional-doctor.ts b/lib/infra/additional-doctor.ts
index f422eb4e..af451125 100644
--- a/lib/infra/additional-doctor.ts
+++ b/lib/infra/additional-doctor.ts
@@ -78,7 +78,6 @@ export async function doctorAdditionalProvider(id: string, values: Record<string
case "openai-app": {
if (!present(values.appId)) return null;
if (!/^asdk_app_[A-Za-z0-9][A-Za-z0-9_-]*$/.test(values.appId)) throw new Error("OpenAI registered App ID format is invalid");
- if (present(values.versionId) && !/^asdk_app_v_[A-Za-z0-9][A-Za-z0-9_-]*$/.test(values.versionId)) throw new Error("OpenAI Version ID format is invalid");
return "private registered-app binding configured; format verified locally; ChatGPT remains authoritative for registration/review status";
}
case "github": {
diff --git a/lib/infra/additional-providers.ts b/lib/infra/additional-providers.ts
index f325d682..2244981f 100644
--- a/lib/infra/additional-providers.ts
+++ b/lib/infra/additional-providers.ts
@@ -106,7 +106,6 @@ export const ADDITIONAL_PROVIDERS = {
feature: false,
fields: [
{ key: "appId", label: "Registered App ID", secret: true, required: true, description: "Private per-installation OpenAI App ID used only to generate .app.json for personal/plugin packaging. Canonical form starts with asdk_app_; plugin_asdk_app_ copied from a browser URL is normalized automatically." },
- { key: "versionId", label: "Version ID", secret: true, required: false, description: "Optional private development-version reference for operator diagnostics. It is never written into .app.json and is not required for MCP Apps UI binding." },
],
},
} as const satisfies Record<string, AdditionalProvider>;
diff --git a/lib/infra/catalog.ts b/lib/infra/catalog.ts
index 9e651718..8de8b65a 100644
--- a/lib/infra/catalog.ts
+++ b/lib/infra/catalog.ts
@@ -114,7 +114,6 @@ export function normalizeInfraValues(id: InfraProviderId, raw: Record<string, un
if (normalized.startsWith("asdk_app_v_") || !/^asdk_app_[A-Za-z0-9][A-Za-z0-9_-]*$/.test(normalized)) throw new Error("OpenAI App ID must be canonical asdk_app_… or browser URL form plugin_asdk_app_…");
out.appId = normalized;
}
- if (out.versionId && !/^asdk_app_v_[A-Za-z0-9][A-Za-z0-9_-]*$/.test(out.versionId)) throw new Error("OpenAI Version ID must start with asdk_app_v_");
}
if (id === "hostinger") {
if (out.apiToken && out.apiToken.length < 24) throw new Error("Hostinger API token is too short");
diff --git a/lib/infra/openai-app-integration.test.ts b/lib/infra/openai-app-integration.test.ts
index cd2938d6..e0a13944 100644
--- a/lib/infra/openai-app-integration.test.ts
+++ b/lib/infra/openai-app-integration.test.ts
@@ -8,14 +8,13 @@ describe("OpenAI registered app integration", () => {
const def=getInfraProviderDefinition("openai-app");
expect(def.fields).toEqual(expect.arrayContaining([
expect.objectContaining({key:"appId",secret:true,required:true}),
- expect.objectContaining({key:"versionId",secret:true,required:false}),
]));
expect(connectionMethods("openai-app","direct")[0].guidance.steps.join(" ")).toContain("App ID");
});
- it("normalizes browser plugin ids and keeps version ids separate", () => {
+ it("normalizes browser plugin ids and ignores version-scoped metadata", () => {
expect(normalizeInfraValues("openai-app",{appId:"plugin_asdk_app_example123",versionId:"asdk_app_v_example456"})).toEqual({
- appId:"asdk_app_example123",versionId:"asdk_app_v_example456",
+ appId:"asdk_app_example123",
});
expect(()=>normalizeInfraValues("openai-app",{appId:"asdk_app_v_wrong"})).toThrow();
});