Skip to content

an open-source alternative to the dots, bots and muses of the world, run an office of claude code/codex like agents on your laptop, sandboxes or anywhere, uses your existing subscriptions

fix(control): cap the per-agent steer queue so a stalled agent cannot accumulate unbounded notes

Zhen Luo0feb47b495c4
diff --git a/src/main/control.ts b/src/main/control.ts
index fcb47a4e..93ec49f3 100644
--- a/src/main/control.ts
+++ b/src/main/control.ts
@@ -17,6 +17,13 @@
* Runs in the Electron main process; no electron import (unit-testable).
*/
+/** Max steer notes queued per agent before the OLDEST is dropped. Each note
+ * rides the next hook's additionalContext; a stalled/halted agent never drains
+ * the queue, so without a cap a burst of steers (closing-time loop, a stuck
+ * caller) would grow memory forever. The latest instruction wins: when full we
+ * drop from the front (FIFO) so a busy agent still hears the most recent note. */
+const MAX_PENDING_STEERS = 20;
+
export interface AgentControlSnapshot {
paused: boolean;
halted: boolean;
@@ -70,7 +77,10 @@ export class ControlRegistry {
}
steer(id: string, text: string): void {
const t = text.trim();
- if (t) this.ensure(id).steerQueue.push(t.slice(0, 10000)); // hook additionalContext cap
+ if (!t) return;
+ const q = this.ensure(id).steerQueue;
+ if (q.length >= MAX_PENDING_STEERS) q.shift(); // keep the newest note, drop the oldest
+ q.push(t.slice(0, 10000)); // hook additionalContext cap
}
/** Request a graceful stop at the next hook boundary. */
halt(id: string): void { this.ensure(id).halted = true; }
diff --git a/test/control.test.cjs b/test/control.test.cjs
index d9758ddf..36765479 100644
--- a/test/control.test.cjs
+++ b/test/control.test.cjs
@@ -30,3 +30,28 @@ test('persisted delivery pauses replace stale in-memory state', () => {
assert.equal(control.isAutoDeliveryPaused('dev2'), true);
assert.equal(control.isAutoDeliveryPaused('dev3'), true);
});
+
+test('steer queue is capped so a stalled agent cannot accumulate unbounded notes', () => {
+ const control = new ControlRegistry();
+ for (let i = 1; i <= 25; i++) control.steer('dev9', `note ${i}`);
+
+ // Only the cap is retained, never all 25.
+ assert.equal(control.snapshot('dev9').pendingSteers, 20);
+
+ // FIFO + drop-oldest: the oldest notes are shed, so the survivors start at
+ // note 6 and the newest (note 25) is the last one delivered.
+ assert.equal(control.takeSteer('dev9'), 'note 6');
+ let last = '';
+ for (let i = 0; i < 19; i++) last = control.takeSteer('dev9'); // notes 7..25
+ assert.equal(last, 'note 25');
+ assert.equal(control.takeSteer('dev9'), undefined, 'queue fully drained');
+});
+
+test('whitespace-only steers are ignored and never fill the queue', () => {
+ const control = new ControlRegistry();
+ control.steer('dev9', ' ');
+ control.steer('dev9', '');
+ control.steer('dev9', 'real guidance');
+ assert.equal(control.snapshot('dev9').pendingSteers, 1);
+ assert.equal(control.takeSteer('dev9'), 'real guidance');
+});