Skip to content

an open-source alternative to the dots, bots and muses of the world, run an office of claude code/codex like agents on your laptop, sandboxes or anywhere, uses your existing subscriptions

review: drop duplicated rt.run cancel block + texture-lifetime note + mug-clamp warning

Gulum80c7d4ae87ce
diff --git a/src/renderer/src/scene/office/OfficeFloor.tsx b/src/renderer/src/scene/office/OfficeFloor.tsx
index b572cd74..89244860 100644
--- a/src/renderer/src/scene/office/OfficeFloor.tsx
+++ b/src/renderer/src/scene/office/OfficeFloor.tsx
@@ -898,6 +898,10 @@ export function OfficeFloor() {
// Facilities collects an abandoned mug (carried or parked on the desk)
// back onto the sideboard, so the finite cup stock can never leak away.
if (rt.character.isCarryingCup() || rt.character.hasCupOnDesk()) {
+ // The clamp guarantees "never leak", but a clamp that actually FIRES
+ // means the accounting double-counted somewhere — surface it instead
+ // of silently pinning the stock at the cap.
+ if (cleanCups >= MAX_CUPS) console.warn('[office] mug reclaim over cap — cup accounting drifted');
cleanCups = Math.min(MAX_CUPS, cleanCups + 1);
drawTray();
}
@@ -966,15 +970,6 @@ export function OfficeFloor() {
}
releaseRun(rt);
}
- // And for a coffee run: real work cancels it mid-stride — a mug already
- // in hand simply rides along to the desk (cupCarryHome parks it there).
- if (rt.run) {
- if (agent.status === 'idle' || agent.status === 'success') {
- c.setStatusGlyph(agent.status === 'success' ? 'success' : 'none');
- return;
- }
- releaseRun(rt);
- }
// A thought cloud above the head shows what the agent is doing RIGHT NOW
// (its live `action`, e.g. "edit App.tsx"). Working → sit at the desk;
diff --git a/src/renderer/src/scene/office/TiledMapRenderer.ts b/src/renderer/src/scene/office/TiledMapRenderer.ts
index 8ced244a..35e7e538 100644
--- a/src/renderer/src/scene/office/TiledMapRenderer.ts
+++ b/src/renderer/src/scene/office/TiledMapRenderer.ts
@@ -111,7 +111,10 @@ export class TiledMapRenderer {
/** A sub-texture for one tileset tile, addressed by gid — for dynamic props
* that reuse map art (e.g. the lit monitor variant overlaid when an agent
- * sits down). Returns undefined for gid 0 / out-of-range. */
+ * sits down). Returns undefined for gid 0 / out-of-range.
+ * NOTE: allocates a fresh Texture per call and the CALLER owns its lifetime
+ * (fine for constructor-time use, kept alive by sprites; do NOT call this
+ * per frame or the textures leak). */
textureForGid(gid: number): Texture | undefined {
const tileId = gid & TILE_ID_MASK;
if (tileId === 0) return undefined;