An open source, non-profit web search engine
Add endpoints to cancel and uncancel a membership
Claude69de68948915
diff --git a/mwmbl/platform/api.py b/mwmbl/platform/api.pyindex 5804320..bf09599 100644--- a/mwmbl/platform/api.py+++ b/mwmbl/platform/api.py@@ -1387,6 +1387,65 @@ def create_membership_checkout(request, body: MembershipCheckoutRequest):return CheckoutResponse(checkout_url=result.url)+ "/membership/cancel",+ auth=JWTAuth(),+ response=MembershipResponse,+ summary="Cancel membership at period end",+ description="Schedules the membership to cancel at the end of the current billing period. "+ "The membership and its perks remain active until then.",+ tags=["Membership"],+)+def cancel_membership(request):+ check_email_verified(request)+ user_membership = Membership.objects.filter(user=request.user).first()+ if user_membership is None:+ raise InvalidRequest("Not a member.", status=404)+ if user_membership.cancel_at_period_end:+ raise InvalidRequest("Membership is already scheduled to cancel.", status=409)+ try:+ with Polar(access_token=settings.POLAR_ACCESS_TOKEN, server=settings.POLAR_SERVER) as polar:+ result = polar.subscriptions.update(+ id=user_membership.polar_subscription_id,+ subscription_update=SubscriptionCancel(cancel_at_period_end=True),+ )+ except polar_models.AlreadyCanceledSubscription:+ raise InvalidRequest("Membership is already canceled.", status=409)+ user_membership.current_period_end = result.current_period_end+ user_membership.cancel_at_period_end = True+ user_membership.save()+ return user_membership+++ "/membership/uncancel",+ auth=JWTAuth(),+ response=MembershipResponse,+ summary="Uncancel a pending membership cancellation",+ description="Removes a scheduled cancellation, so the membership renews at the end of the current period.",+ tags=["Membership"],+)+def uncancel_membership(request):+ check_email_verified(request)+ user_membership = Membership.objects.filter(user=request.user).first()+ if user_membership is None:+ raise InvalidRequest("Not a member.", status=404)+ if not user_membership.cancel_at_period_end:+ raise InvalidRequest("Membership is not scheduled to cancel.", status=409)+ try:+ with Polar(access_token=settings.POLAR_ACCESS_TOKEN, server=settings.POLAR_SERVER) as polar:+ result = polar.subscriptions.update(+ id=user_membership.polar_subscription_id,+ subscription_update=SubscriptionCancel(cancel_at_period_end=False),+ )+ except polar_models.AlreadyCanceledSubscription:+ raise InvalidRequest("Membership has already ended.", status=409)+ user_membership.current_period_end = result.current_period_end+ user_membership.cancel_at_period_end = False+ user_membership.save()+ return user_membership++def _sync_membership(subscription):"""Bring the user's Membership row in line with their live membership subscriptions in Polar.diff --git a/test/test_membership.py b/test/test_membership.pyindex 7bd90f3..9a726cc 100644--- a/test/test_membership.py+++ b/test/test_membership.py@@ -5,6 +5,7 @@ Covers:- GET /api/v1/platform/membership/tiers- GET /api/v1/platform/membership- POST /api/v1/platform/membership/checkout+- POST /api/v1/platform/membership/cancel and /uncancel- Membership subscription events on POST /api/v1/platform/billing/webhook"""@@ -16,6 +17,7 @@ from allauth.account.models import EmailAddressfrom django.contrib.auth import get_user_modelfrom django.test import Client, override_settingsfrom ninja_jwt.tokens import RefreshToken+from polar_sdk.models import AlreadyCanceledSubscriptionfrom mwmbl.membership import MembershipTierfrom mwmbl.models import Membership, UserBilling@@ -250,6 +252,142 @@ def test_checkout_requires_verified_email(api_client, user):assert response.status_code == 403+# ---------------------------------------------------------------------------+# Cancel and uncancel+# ---------------------------------------------------------------------------+++def _post_membership_action(api_client, user, action, polar_update_result=None, polar_update_error=None):+ with patch("mwmbl.platform.api.Polar") as MockPolar:+ mock_polar = MockPolar.return_value.__enter__.return_value+ mock_polar.subscriptions.update.return_value = polar_update_result+ mock_polar.subscriptions.update.side_effect = polar_update_error+ response = api_client.post(f"/api/v1/platform/membership/{action}", **auth_headers(user))+ return response, mock_polar+++def _already_canceled_error():+ raw_response = Mock(status_code=403, text="Subscription is already canceled")+ return AlreadyCanceledSubscription(data=Mock(detail="Subscription is already canceled"), raw_response=raw_response)+++def test_cancel_membership_schedules_cancellation(api_client, user):+ Membership.objects.create(user=user, tier=MembershipTier.SAPLING, polar_subscription_id="sub_member")+ period_end = datetime(2026, 11, 1, tzinfo=timezone.utc)++ response, mock_polar = _post_membership_action(+ api_client, user, "cancel", polar_update_result=_polar_subscription(current_period_end=period_end)+ )++ assert response.status_code == 200+ assert response.json()["cancel_at_period_end"] is True+ assert response.json()["tier"] == "sapling"+ update_params = mock_polar.subscriptions.update.call_args[1]+ assert update_params["id"] == "sub_member"+ assert update_params["subscription_update"].cancel_at_period_end is True+ member = Membership.objects.get(user=user)+ assert member.cancel_at_period_end is True+ assert member.current_period_end == period_end+++def test_cancel_membership_not_a_member_returns_404(api_client, user):+ response, mock_polar = _post_membership_action(api_client, user, "cancel")++ assert response.status_code == 404+ mock_polar.subscriptions.update.assert_not_called()+++def test_cancel_membership_already_cancelling_returns_409(api_client, user):+ Membership.objects.create(+ user=user, tier=MembershipTier.SAPLING, polar_subscription_id="sub_member", cancel_at_period_end=True+ )++ response, mock_polar = _post_membership_action(api_client, user, "cancel")++ assert response.status_code == 409+ mock_polar.subscriptions.update.assert_not_called()+++def test_cancel_membership_already_canceled_in_polar_returns_409(api_client, user):+ Membership.objects.create(user=user, tier=MembershipTier.SAPLING, polar_subscription_id="sub_member")++ response, _ = _post_membership_action(api_client, user, "cancel", polar_update_error=_already_canceled_error())++ assert response.status_code == 409+ assert Membership.objects.get(user=user).cancel_at_period_end is False+++def test_cancel_membership_requires_verified_email(api_client, user):+ Membership.objects.create(user=user, tier=MembershipTier.SAPLING, polar_subscription_id="sub_member")+ EmailAddress.objects.filter(user=user).update(verified=False)++ response, _ = _post_membership_action(api_client, user, "cancel")++ assert response.status_code == 403+++def test_cancel_membership_unauthenticated(api_client):+ response = api_client.post("/api/v1/platform/membership/cancel")++ assert response.status_code == 401+++def test_uncancel_membership_removes_scheduled_cancellation(api_client, user):+ Membership.objects.create(+ user=user, tier=MembershipTier.CANOPY, polar_subscription_id="sub_member", cancel_at_period_end=True+ )+ period_end = datetime(2026, 11, 1, tzinfo=timezone.utc)++ response, mock_polar = _post_membership_action(+ api_client, user, "uncancel", polar_update_result=_polar_subscription(current_period_end=period_end)+ )++ assert response.status_code == 200+ assert response.json()["cancel_at_period_end"] is False+ update_params = mock_polar.subscriptions.update.call_args[1]+ assert update_params["id"] == "sub_member"+ assert update_params["subscription_update"].cancel_at_period_end is False+ member = Membership.objects.get(user=user)+ assert member.cancel_at_period_end is False+ assert member.current_period_end == period_end+++def test_uncancel_membership_not_a_member_returns_404(api_client, user):+ response, _ = _post_membership_action(api_client, user, "uncancel")++ assert response.status_code == 404+++def test_uncancel_membership_not_cancelling_returns_409(api_client, user):+ Membership.objects.create(user=user, tier=MembershipTier.CANOPY, polar_subscription_id="sub_member")++ response, mock_polar = _post_membership_action(api_client, user, "uncancel")++ assert response.status_code == 409+ mock_polar.subscriptions.update.assert_not_called()+++def test_uncancel_membership_already_ended_in_polar_returns_409(api_client, user):+ Membership.objects.create(+ user=user, tier=MembershipTier.CANOPY, polar_subscription_id="sub_member", cancel_at_period_end=True+ )++ response, _ = _post_membership_action(api_client, user, "uncancel", polar_update_error=_already_canceled_error())++ assert response.status_code == 409+ assert Membership.objects.get(user=user).cancel_at_period_end is True++# ---------------------------------------------------------------------------# Webhook# ---------------------------------------------------------------------------