Skip to content

Your lightweight open-source personal agent.

4.4 KB
Raw Blame
from __future__ import annotations

import pytest

from nanobot.agent.tools.shell import ExecTool


def test_deny_patterns_block_rm_rf():
    tool = ExecTool()
    result = tool._guard_command("rm -rf /tmp/build", "/tmp")
    assert result is not None
    assert "deny pattern filter" in result.lower()


@pytest.mark.parametrize(
    "command, allow_pattern",
    [
        pytest.param("rm -rf /tmp/build", "rm\\s+-rf\\s+/tmp/.*", id="allow_patterns_bypass_deny"),
        pytest.param(
            "echo allowlisted 2>&1",
            "echo\\s+allowlisted\\s+2>&1",
            id="guard_allow_patterns_keep_fd_redirection_ampersand",
        ),
        pytest.param(
            "rm -rf /tmp/build",
            "rm\\s+-rf\\s+/tmp/build",
            id="allow_patterns_fullmatch_allows_exact_command",
        ),
        pytest.param(
            "echo allowlisted",
            "\\becho\\s+allowlisted\\b",
            id="guard_allow_patterns_allow_single_matching_segment",
        ),
        pytest.param(
            "echo allowlisted",
            "^echo\\s+allowlisted$",
            id="guard_allow_patterns_keep_fullmatch_style_compatibility",
        ),
    ],
)
def test_allow_patterns_accept_matching_commands(command, allow_pattern):
    tool = ExecTool(allow_patterns=[allow_pattern])
    result = tool._guard_command(command, "/tmp")
    assert result is None


@pytest.mark.parametrize(
    "command, reason, allow_pattern",
    [
        pytest.param(
            "rm -rf /tmp/build",
            "deny pattern filter",
            "rm\\s+-rf\\s+/opt/",
            id="allow_patterns_must_match_to_bypass",
        ),
        pytest.param(
            "echo allowlisted && touch /tmp/evil",
            "allowlist",
            "\\becho\\s+allowlisted\\b",
            id="guard_allow_patterns_block_non_matching_chained_segment",
        ),
        pytest.param(
            "echo allowlisted & touch /tmp/evil",
            "allowlist",
            "echo\\s+allowlisted.*",
            id="guard_allow_patterns_block_single_ampersand_chained_segment",
        ),
        pytest.param(
            "echo allowlisted\ntouch /tmp/evil",
            "allowlist",
            "echo\\s+allowlisted\\s*.*",
            id="guard_allow_patterns_block_newline_chained_segment",
        ),
        pytest.param(
            "echo allowlisted\nrm -rf /",
            "deny pattern filter",
            "echo\\s+allowlisted\\s*.*",
            id="guard_newline_chained_segment_still_hits_deny_patterns",
        ),
        pytest.param(
            "echo allowlisted &",
            "allowlist",
            "echo\\s+allowlisted",
            id="guard_allow_patterns_preserve_trailing_background_operator",
        ),
    ],
)
def test_allow_patterns_do_not_bypass_rejected_commands(command, reason, allow_pattern):
    tool = ExecTool(allow_patterns=[allow_pattern])
    result = tool._guard_command(command, "/tmp")
    assert result is not None
    assert reason in result.lower()


def test_extra_deny_patterns_from_config():
    tool = ExecTool(deny_patterns=[r"\bping\b"])
    assert tool._guard_command("ping example.com", "/tmp") is not None
    assert tool._guard_command("rm -rf /tmp/x", "/tmp") is not None


def test_allow_patterns_bypass_extra_deny():
    tool = ExecTool(
        deny_patterns=[r"\bping\b"],
        allow_patterns=[r"\bping\s+example\.com\b"],
    )
    result = tool._guard_command("ping example.com", "/tmp")
    assert result is None


def test_allow_patterns_is_whitelist_only():
    tool = ExecTool(allow_patterns=[r"echo\s+hello"])
    assert tool._guard_command("echo hello", "/tmp") is None
    result = tool._guard_command("ls /tmp", "/tmp")
    assert result is not None
    assert "allowlist" in result.lower()


def test_split_shell_segments_keep_line_continuation_intact():
    assert ExecTool._split_shell_segments("echo allowlisted \\\nextra") == [
        "echo allowlisted \\\nextra"
    ]


def test_deny_patterns_search_original_command_with_quoted_hash():
    tool = ExecTool(deny_patterns=[r"\brm\s+-rf\s+/"])
    result = tool._guard_command('echo "#"; rm -rf /', "/tmp")
    assert result is not None
    assert "deny pattern filter" in result.lower()


def test_guard_allow_patterns_allow_multiple_matching_segments():
    tool = ExecTool(
        allow_patterns=[
            r"\becho\s+allowlisted\b",
            r"\becho\s+also_allowed\b",
        ]
    )

    result = tool._guard_command("echo allowlisted && echo also_allowed", "/tmp")

    assert result is None