Skip to content

Your lightweight open-source personal agent.

docs(pairing): address reviewer comments — comments, error msg, __all__ test

chengyongru199a1bb8fa4a
diff --git a/nanobot/channels/base.py b/nanobot/channels/base.py
index ed5c54232..a578e9971 100644
--- a/nanobot/channels/base.py
+++ b/nanobot/channels/base.py
@@ -202,6 +202,7 @@ class BaseChannel(ABC):
allow_list = getattr(self.config, "allow_from", []) or []
if "*" in allow_list:
return True
+ # allowFrom entries are opaque tokens — must match exactly.
if str(sender_id) in allow_list:
return True
if is_approved(self.name, str(sender_id)):
diff --git a/nanobot/channels/feishu.py b/nanobot/channels/feishu.py
index 5a6b32885..c5e085972 100644
--- a/nanobot/channels/feishu.py
+++ b/nanobot/channels/feishu.py
@@ -1716,6 +1716,8 @@ class FeishuChannel(BaseChannel):
# Group chats are silently ignored; DMs get a pairing code.
if not self.is_allowed(sender_id):
if chat_type == "p2p":
+ # content="" because the pairing reply is generated by
+ # BaseChannel._handle_message, not from the original message.
await self._handle_message(
sender_id=sender_id,
chat_id=sender_id,
diff --git a/nanobot/channels/manager.py b/nanobot/channels/manager.py
index de0ed0c01..b63510fae 100644
--- a/nanobot/channels/manager.py
+++ b/nanobot/channels/manager.py
@@ -145,7 +145,7 @@ class ChannelManager:
allow = getattr(cfg, "allow_from", None)
if allow is None:
raise SystemExit(
- f'Error: "{name}" is missing allowFrom. '
+ f'Error: "{name}" is missing or null allowFrom. '
f'Set ["*"] to allow everyone, or add specific user IDs.'
)
diff --git a/nanobot/pairing/store.py b/nanobot/pairing/store.py
index 340a85b3b..78e041612 100644
--- a/nanobot/pairing/store.py
+++ b/nanobot/pairing/store.py
@@ -82,6 +82,8 @@ def generate_code(
with _LOCK:
data = _load()
_gc_pending(data)
+ # Collision probability is negligible (~1e-12 with 20 pending codes),
+ # so we skip an existence check for simplicity.
raw = "".join(secrets.choice(_ALPHABET) for _ in range(_CODE_LENGTH))
code = f"{raw[:4]}-{raw[4:]}"
diff --git a/tests/pairing/test_store.py b/tests/pairing/test_store.py
index 1c06cc554..25c8ec7c7 100644
--- a/tests/pairing/test_store.py
+++ b/tests/pairing/test_store.py
@@ -2,9 +2,18 @@ import time
import pytest
+from nanobot.pairing import __all__ as pairing_all
from nanobot.pairing import store
+def test_all_exports_are_importable():
+ """Every name in __all__ must actually be importable from nanobot.pairing."""
+ import nanobot.pairing as pkg
+
+ for name in pairing_all:
+ assert hasattr(pkg, name), f"{name} is in __all__ but not exported"
+
+
@pytest.fixture(autouse=True)
def _tmp_store(tmp_path, monkeypatch):
path = tmp_path / "pairing.json"