Your lightweight open-source personal agent.
Python agent-frameworkai-agentai-agentschatbotchatopsdiscord-botllm-agentsllmslocal-llmmcpmodel-context-protocolmulti-agentopenai-compatibleopenclawpersonal-ai-assistantpythonself-hostedtelegram-bot-ai-assistantwebuiworkflow-automation
fix(providers): prevent image retries from bypassing required compaction (#6548)
chengyongru58a05ea3e00e
diff --git a/nanobot/providers/base.py b/nanobot/providers/base.pyindex fb92118c2..d84b49bb2 100644--- a/nanobot/providers/base.py+++ b/nanobot/providers/base.py@@ -10,7 +10,7 @@ from abc import ABC, abstractmethodfrom collections.abc import Awaitable, Callablefrom contextlib import suppressfrom copy import deepcopy-from dataclasses import dataclass, field+from dataclasses import dataclass, field, replacefrom datetime import datetime, timezonefrom email.utils import parsedate_to_datetimefrom typing import TYPE_CHECKING, Any, Literal, cast@@ -1721,8 +1721,14 @@ class LLMProvider(ABC):or self.is_arrearage_response(response)):return response- stripped = self._strip_image_content(kw["messages"])provider_context = kw.get("provider_context")+ if (+ isinstance(provider_context, ProviderCallContext)+ and provider_context.compaction_input_budget is not None+ ):+ # Stateless image repair cannot satisfy required native compaction.+ return response+ stripped = self._strip_image_content(kw["messages"])stripped_context: ProviderCallContext | None = Noneif isinstance(provider_context, ProviderCallContext):state = provider_context.conversation_state@@ -1732,13 +1738,7 @@ class LLMProvider(ABC):or self._contains_image_content(state.payload)):# Native payloads may retain images: rebuild from the public transcript.- stripped_context = ProviderCallContext(- context_window_tokens=provider_context.context_window_tokens,- session_id=provider_context.session_id,- events=provider_context.events,- response_preset=provider_context.response_preset,- response_is_fallback=provider_context.response_is_fallback,- )+ stripped_context = replace(provider_context, conversation_state=None)if stripped is None and stripped_context is None:return responselogger.warning("Non-transient LLM error with image content, retrying without images")diff --git a/tests/providers/test_openai_codex_provider.py b/tests/providers/test_openai_codex_provider.pyindex f43d56f53..8d4d28602 100644--- a/tests/providers/test_openai_codex_provider.py+++ b/tests/providers/test_openai_codex_provider.py@@ -11,9 +11,10 @@ import pytestfrom loguru import loggerimport nanobot.providers.base as provider_base-from nanobot.config.schema import Config+from nanobot.config.schema import Config, ModelPresetConfigfrom nanobot.events import ContextCompactionEvent, EventSinkfrom nanobot.providers.factory import make_provider+from nanobot.providers.fallback_provider import FallbackProviderfrom nanobot.providers.openai_codex_provider import (OpenAICodexProvider,_build_codex_http_error,@@ -40,6 +41,89 @@ def _mock_codex_token(monkeypatch: pytest.MonkeyPatch) -> None:)[email protected]("stream", [False, True])+ ("input_budget", "fail_after_compaction", "with_fallback"),+ [(None, False, False), (1000, False, False), (1000, True, False), (1000, False, True)],+ ids=["optional", "compaction-error", "generation-error", "persistent-fallback"],+)+async def test_image_retry_cannot_bypass_required_compaction(+ monkeypatch, stream, input_budget, fail_after_compaction, with_fallback,+) -> None:+ _mock_codex_token(monkeypatch)+ provider = OpenAICodexProvider(default_model="gpt-5.6-sol")+ history = {"role": "user", "content": "earlier discussion " * (10 if fail_after_compaction else 1000)}+ question = {"role": "user", "content": [+ {"type": "text", "text": "Describe this image."},+ {"type": "image_url", "image_url": {"url": "data:image/png;base64,abc"}},+ ]}+ state = build_responses_state(+ provider=provider._responses_state_provider(), model="gpt-5.6-sol",+ input_items=[history], output_items=[],+ ).with_pending_messages([question])+ submitted = []+ bodies = []+ notices: list[ContextCompactionEvent] = []+ compact_item = {"type": "compaction", "encrypted_content": "synthetic compacted state"}++ async def observe(event):+ if isinstance(event, ContextCompactionEvent):+ notices.append(event)++ async def request(_url, _headers, body, **_kwargs):+ compacting = body["input"][-1].get("type") == "compaction_trigger"+ submitted.append("compaction" if compacting else "generation")+ bodies.append(body)+ if compacting and fail_after_compaction:+ return provider_base.LLMResponse(content=None, provider_state=build_responses_state(+ provider=provider._responses_state_provider(), model="gpt-5.6-sol",+ input_items=body["input"], output_items=[compact_item],+ ))+ if len(submitted) == (2 if fail_after_compaction else 1):+ raise _CodexHTTPError("fixture rejection", status_code=400, error_code="unsupported_value")+ return provider_base.LLMResponse(content="accepted without images")++ monkeypatch.setattr("nanobot.providers.openai_codex_provider._request_codex", request)+ caller = FallbackProvider(+ primary=provider,+ fallback_presets=[ModelPresetConfig(model="openai-codex/gpt-5.6-sol", provider="openai_codex")],+ provider_factory=lambda _preset: provider,+ ) if with_fallback else provider+ invoke = caller.chat_stream_with_retry if stream else caller.chat_with_retry+ try:+ response = await invoke(+ [history, question], max_tokens=64,+ retry_mode="persistent" if with_fallback else "standard",+ provider_context=provider_base.ProviderCallContext(+ conversation_state=state, context_window_tokens=10000,+ compaction_input_budget=input_budget, events=EventSink(observe),+ ),+ )+ if input_budget is not None:+ assert submitted == (["compaction", "generation"] if fail_after_compaction else ["compaction"])+ assert response.finish_reason == "error"+ assert response.error_status_code == 400+ assert response.error_code == "unsupported_value"+ assert question["content"][1]["type"] == "image_url"+ if fail_after_compaction:+ assert response.provider_compaction_applied is True+ assert response.provider_compaction_state is not None+ assert responses_state_items(response.provider_compaction_state) == [compact_item]+ assert response.provider_compaction_scope == "prior_context"+ assert [notice.phase for notice in notices] == ["started", "succeeded"]+ assert response.provider_compaction_event_id == notices[0].compaction_id == notices[1].compaction_id+ else:+ assert response.preserve_provider_state_on_error is True+ else:+ assert submitted == ["generation", "generation"]+ assert response.content == "accepted without images"+ assert "data:image/png;base64,abc" not in str(bodies[-1])+ assert question["content"][1]["type"] == "text"+ finally:+ await provider.aclose()++def test_codex_default_model_matches_curated_flagship() -> None:spec = find_by_name("openai_codex")