Your lightweight open-source personal agent.
Python agent-frameworkai-agentai-agentschatbotchatopsdiscord-botllm-agentsllmslocal-llmmcpmodel-context-protocolmulti-agentopenai-compatibleopenclawpersonal-ai-assistantpythonself-hostedtelegram-bot-ai-assistantwebuiworkflow-automation
fix: drop redundant reasoning_effort for Kimi thinking models
A.G. Bocsardi9b2f452b6e4b
diff --git a/nanobot/providers/openai_compat_provider.py b/nanobot/providers/openai_compat_provider.pyindex 3c1bf9b8f..8281d7d20 100644--- a/nanobot/providers/openai_compat_provider.py+++ b/nanobot/providers/openai_compat_provider.py@@ -633,6 +633,14 @@ class OpenAICompatProvider(LLMProvider):if extra:kwargs.setdefault("extra_body", {}).update(extra)+ # Moonshot rejects requests that carry both 'reasoning_effort'+ # and the native 'thinking' param. We already expressed the+ # user's intent via the provider-native shape, so drop the+ # redundant wire-level kwarg. Only kimi models need this —+ # Xiaomi's API accepts both params.+ if _model_slug(model_name) in _KIMI_THINKING_MODELS:+ kwargs.pop("reasoning_effort", None)+if tools:kwargs["tools"] = toolskwargs["tool_choice"] = tool_choice or "auto"diff --git a/tests/providers/test_litellm_kwargs.py b/tests/providers/test_litellm_kwargs.pyindex dddc70054..924ee0060 100644--- a/tests/providers/test_litellm_kwargs.py+++ b/tests/providers/test_litellm_kwargs.py@@ -1420,12 +1420,15 @@ def test_kimi_k25_thinking_enabled() -> None:"""kimi-k2.5 with reasoning_effort set should opt in to thinking."""kw = _build_kwargs_for("moonshot", "kimi-k2.5", reasoning_effort="medium")assert kw.get("extra_body") == {"thinking": {"type": "enabled"}}+ # Moonshot rejects both 'reasoning_effort' and 'thinking' (#3939)+ assert "reasoning_effort" not in kwdef test_kimi_k25_thinking_disabled_for_minimal() -> None:"""reasoning_effort='minimal' maps to thinking disabled for kimi-k2.5."""kw = _build_kwargs_for("moonshot", "kimi-k2.5", reasoning_effort="minimal")assert kw.get("extra_body") == {"thinking": {"type": "disabled"}}+ assert "reasoning_effort" not in kwdef test_kimi_k25_no_extra_body_when_reasoning_effort_none() -> None:@@ -1445,12 +1448,15 @@ def test_kimi_k25_thinking_enabled_with_openrouter_prefix() -> None:"thinking": {"type": "enabled"},"reasoning": {"effort": "medium"},}+ # Even via OR, reasoning_effort wire kwarg is dropped for kimi models+ assert "reasoning_effort" not in kwdef test_kimi_k26_thinking_enabled() -> None:"""kimi-k2.6 with reasoning_effort set should opt in to thinking."""kw = _build_kwargs_for("moonshot", "kimi-k2.6", reasoning_effort="medium")assert kw.get("extra_body") == {"thinking": {"type": "enabled"}}+ assert "reasoning_effort" not in kwdef test_kimi_k26_thinking_enabled_with_openrouter_prefix() -> None:@@ -1461,6 +1467,7 @@ def test_kimi_k26_thinking_enabled_with_openrouter_prefix() -> None:"thinking": {"type": "enabled"},"reasoning": {"effort": "medium"},}+ assert "reasoning_effort" not in kwdef test_moonshot_kimi_k26_temperature_override() -> None:@@ -1479,6 +1486,7 @@ def test_kimi_k26_code_preview_thinking_enabled() -> None:"""k2.6-code-preview also supports thinking; should behave like k2.5."""kw = _build_kwargs_for("moonshot", "k2.6-code-preview", reasoning_effort="high")assert kw.get("extra_body") == {"thinking": {"type": "enabled"}}+ assert "reasoning_effort" not in kwdef test_kimi_k2_series_no_thinking_injection() -> None:@@ -1508,6 +1516,7 @@ def test_kimi_k25_thinking_disabled_for_none_string() -> None:"""reasoning_effort='none' maps to thinking disabled for kimi-k2.5."""kw = _build_kwargs_for("moonshot", "kimi-k2.5", reasoning_effort="none")assert kw.get("extra_body") == {"thinking": {"type": "disabled"}}+ assert "reasoning_effort" not in kwdef test_dashscope_thinking_disabled_for_none_string() -> None: