Your lightweight open-source personal agent.
Python agent-frameworkai-agentai-agentschatbotchatopsdiscord-botllm-agentsllmslocal-llmmcpmodel-context-protocolmulti-agentopenai-compatibleopenclawpersonal-ai-assistantpythonself-hostedtelegram-bot-ai-assistantwebuiworkflow-automation
fix(webui): allow custom context window token budgets (#5901)
chengyongrueb3fc0708707
diff --git a/nanobot/webui/settings_models.py b/nanobot/webui/settings_models.pyindex f39c86831..d224171dd 100644--- a/nanobot/webui/settings_models.py+++ b/nanobot/webui/settings_models.py@@ -85,7 +85,6 @@ class ModelSettingsPayload(TypedDict):providers: list[dict[str, Any]]-_CONTEXT_WINDOW_TOKEN_OPTIONS = {65_536, 200_000, 262_144, 500_000, 1_048_576}_OAUTH_PROXY_PROVIDERS = {"openai_codex", "xai_grok"}_WEBUI_OAUTH_TIMEOUT_S = 600_MODEL_CONFIGURATION_SLUG_RE = re.compile(r"[^a-z0-9_-]+")@@ -758,20 +757,6 @@ def provider_models_payload(}-def _parse_context_window_tokens(value: str | None) -> int | None:- if value is None:- return None- try:- parsed = int(value)- except ValueError:- raise WebUISettingsError("context_window_tokens must be an integer") from None- if parsed not in _CONTEXT_WINDOW_TOKEN_OPTIONS:- raise WebUISettingsError(- "context_window_tokens must be 65536, 200000, 262144, 500000, or 1048576"- )- return parsed--def _parse_positive_int(value: str | None, field: str) -> int | None:if value is None:return None@@ -1162,8 +1147,9 @@ def update_agent_model_settings(defaults.provider = providerchanged = True- context_window_tokens = _parse_context_window_tokens(- query_first_alias(query, "context_window_tokens", "contextWindowTokens")+ context_window_tokens = _parse_positive_int(+ query_first_alias(query, "context_window_tokens", "contextWindowTokens"),+ "context_window_tokens",)if (context_window_tokens is not Nonediff --git a/tests/webui/test_settings_api.py b/tests/webui/test_settings_api.pyindex 9c9471989..57f565a2e 100644--- a/tests/webui/test_settings_api.py+++ b/tests/webui/test_settings_api.py@@ -1066,7 +1066,7 @@ def test_update_model_configuration_preserves_custom_context_windows(assert saved.model_presets["codex"].context_window_tokens == 128000-def test_update_context_window_rejects_unknown_values(+def test_update_context_window_persists_custom_value(tmp_path,monkeypatch: pytest.MonkeyPatch,) -> None:@@ -1074,11 +1074,9 @@ def test_update_context_window_rejects_unknown_values(save_config(Config(), config_path)monkeypatch.setattr("nanobot.config.loader._current_config_path", config_path)- with pytest.raises(- WebUISettingsError,- match="context_window_tokens must be 65536, 200000, 262144, 500000, or 1048576",- ):- update_agent_settings({"context_window_tokens": ["128000"]})+ payload = update_agent_settings({"context_window_tokens": ["128000"]})+ assert payload["agent"]["context_window_tokens"] == 128000+ assert load_config(config_path).agents.defaults.context_window_tokens == 128000def test_update_model_configuration_rejects_default_preset(diff --git a/tests/webui/test_settings_models.py b/tests/webui/test_settings_models.pyindex d70c2b473..e81e9af68 100644--- a/tests/webui/test_settings_models.py+++ b/tests/webui/test_settings_models.py@@ -2,8 +2,11 @@ from __future__ import annotationsfrom typing import Any+import pytest+from nanobot.config.schema import Configfrom nanobot.webui.settings_models import (+ WebUISettingsError,model_settings_payload,update_agent_model_settings,update_provider_settings,@@ -57,3 +60,23 @@ def test_model_domain_owns_dto_and_config_updates() -> None:"providers",}assert payload["agent"]["model"] == "openai/gpt-5.4"++[email protected]("tokens", [128_000, 131_072, 1_000_000])+def test_default_context_window_accepts_custom_tokens(tokens: int) -> None:+ config = Config()+ assert update_agent_model_settings(+ config, {"context_window_tokens": [str(tokens)]}, oauth_status=_oauth_status,+ )+ assert config.agents.defaults.context_window_tokens == tokens+ assert model_settings_payload(config, oauth_status=_oauth_status)["agent"]["context_window_tokens"] == tokens++[email protected]("value", ["", "0", "-1", "1.5", "abc"])+def test_default_context_window_rejects_invalid_tokens(value: str) -> None:+ config = Config()+ with pytest.raises(WebUISettingsError, match="context_window_tokens must"):+ update_agent_model_settings(+ config, {"context_window_tokens": [value]}, oauth_status=_oauth_status,+ )+ assert config.agents.defaults.context_window_tokens == 200_000diff --git a/webui/src/components/settings/models/ModelsSettings.tsx b/webui/src/components/settings/models/ModelsSettings.tsxindex af0049ad3..8b988429f 100644--- a/webui/src/components/settings/models/ModelsSettings.tsx+++ b/webui/src/components/settings/models/ModelsSettings.tsx@@ -18,6 +18,8 @@ import {ProviderPicker,ProviderPickerIcon,formatContextWindow,+ formatContextWindowInput,+ parseContextWindowTokens,formatModelContextWindow,normalizeContextWindowTokens,settingsProviderConfigured,@@ -39,7 +41,6 @@ import {DialogTitle,} from "@/components/ui/dialog";import { Input } from "@/components/ui/input";-import { SegmentedControl } from "@/components/ui/segmented-control";import { cn } from "@/lib/utils";import type { SettingsPayload } from "@/lib/types";@@ -55,8 +56,6 @@ export interface AgentSettingsDraft {toolHintMaxLength: number;}-const CONTEXT_WINDOW_TOKEN_OPTIONS = [65_536, 200_000, 262_144, 500_000, 1_048_576] as const;-function modelPresetValue(payload: SettingsPayload): string {return (payload.model_call_order?.[0] ??@@ -517,7 +516,7 @@ export function ModelsSettings({"settings.models.advancedSummary","Context {{context}} · Max {{max}} tokens",{- context: formatModelContextWindow(form.contextWindowTokens),+ context: Number.isFinite(form.contextWindowTokens) ? formatModelContextWindow(form.contextWindowTokens) : "—",max: formatContextWindow(form.maxTokens),},)}@@ -897,9 +896,10 @@ function ModelAdvancedFields({}) {const { t } = useTranslation();const tx = (key: string, fallback: string) => t(key, { defaultValue: fallback });- const contextWindowOptions = Array.from(- new Set([...CONTEXT_WINDOW_TOKEN_OPTIONS, contextWindowTokens]),- ).sort((left, right) => left - right);+ const [contextDraft, setContextDraft] = useState<{ text: string; tokens: number } | null>(null);+ const contextWindowInputId = useId();+ const contextWindowHintId = `${contextWindowInputId}-hint`;+ const contextWindowValid = Number.isSafeInteger(contextWindowTokens) && contextWindowTokens > 0;return (<div className="space-y-4"><div className="grid gap-4 sm:grid-cols-2">@@ -938,20 +938,32 @@ function ModelAdvancedFields({</label></div><div>- <span className="mb-2 block text-[12px] font-medium text-muted-foreground">+ <label htmlFor={contextWindowInputId} className="mb-1.5 block text-[12px] font-medium text-muted-foreground">{tx("settings.rows.contextWindow", "Context window")}- </span>- <SegmentedControl- value={String(contextWindowTokens)}- animateIndicator={false}- options={contextWindowOptions.map((tokens) => ({- value: String(tokens),- label: formatModelContextWindow(tokens),- }))}- onChange={(value) =>- onChange({ contextWindowTokens: normalizeContextWindowTokens(Number(value)) })- }+ </label>+ <Input+ id={contextWindowInputId}+ type="text"+ autoCapitalize="none"+ spellCheck={false}+ required+ value={contextDraft && Object.is(contextDraft.tokens, contextWindowTokens)+ ? contextDraft.text : formatContextWindowInput(contextWindowTokens)}+ onChange={(event) => {+ const text = event.target.value;+ const tokens = parseContextWindowTokens(text);+ setContextDraft({ text, tokens });+ onChange({ contextWindowTokens: tokens });+ }}+ aria-invalid={!contextWindowValid}+ aria-describedby={contextWindowHintId}+ className="h-9 text-[13px]"/>+ <p id={contextWindowHintId} className={cn("mt-1.5 text-[12px]", contextWindowValid ? "text-muted-foreground" : "text-destructive")}>+ {contextWindowValid+ ? t("settings.models.contextWindowHint", { tokens: contextWindowTokens.toLocaleString(), defaultValue: "{{tokens}} tokens" })+ : tx("settings.models.contextWindowError", "Enter a positive token count, such as 200k, 1m, or 131072.")}+ </p></div><label className="block"><span className="mb-1.5 block text-[12px] font-medium text-muted-foreground">diff --git a/webui/src/components/settings/models/useModelSettingsActions.ts b/webui/src/components/settings/models/useModelSettingsActions.tsindex 0c97a2a51..4dba28b20 100644--- a/webui/src/components/settings/models/useModelSettingsActions.ts+++ b/webui/src/components/settings/models/useModelSettingsActions.ts@@ -159,7 +159,9 @@ export function useModelSettingsActions({!settings ||saving ||modelCallOrderSaving ||- modelConfigurationSaving+ modelConfigurationSaving ||+ !Number.isSafeInteger(form.contextWindowTokens) ||+ form.contextWindowTokens <= 0) {return;}@@ -173,7 +175,6 @@ export function useModelSettingsActions({!provider ||!model ||form.maxTokens <= 0 ||- form.contextWindowTokens <= 0 ||form.temperature < 0 ||form.temperature > 2) {diff --git a/webui/src/components/settings/shared/ModelControls.tsx b/webui/src/components/settings/shared/ModelControls.tsxindex b2beccea9..dc2eecb71 100644--- a/webui/src/components/settings/shared/ModelControls.tsx+++ b/webui/src/components/settings/shared/ModelControls.tsx@@ -60,6 +60,21 @@ export function normalizeContextWindowTokens(value: number | null | undefined):return typeof value === "number" && Number.isFinite(value) && value > 0 ? value : 200_000;}+export function parseContextWindowTokens(value: string): number {+ const match = /^(\d+(?:\.\d+)?)\s*([km]?)$/i.exec(value.trim());+ if (!match) return NaN;+ const exponent = { k: 3, m: 6 }[match[2].toLowerCase()] ?? 0;+ const tokens = Number(`${match[1]}e${exponent}`);+ return Number.isSafeInteger(tokens) && tokens > 0 ? tokens : NaN;+}++export function formatContextWindowInput(tokens: number): string {+ if (!Number.isFinite(tokens)) return "";+ if (tokens % 1_000_000 === 0) return `${tokens / 1_000_000}m`;+ if (tokens % 1_000 === 0) return `${tokens / 1_000}k`;+ return String(tokens);+}+function settingsProviderRow(payload: SettingsPayload,provider: string | null | undefined,diff --git a/webui/src/i18n/locales/en/common.json b/webui/src/i18n/locales/en/common.jsonindex 2625033a1..c03ecbd08 100644--- a/webui/src/i18n/locales/en/common.json+++ b/webui/src/i18n/locales/en/common.json@@ -465,6 +465,8 @@"presetNamePlaceholder": "e.g. Fast writing","advancedOptions": "Advanced options","advancedSummary": "Context {{context}} · Max {{max}} tokens",+ "contextWindowHint": "{{tokens}} tokens",+ "contextWindowError": "Enter a positive token count, such as 200k, 1m, or 131072.","maxTokens": "Max output tokens","temperature": "Temperature","reasoningEffort": "Reasoning effort",diff --git a/webui/src/i18n/locales/es/common.json b/webui/src/i18n/locales/es/common.jsonindex 670e78c83..30615b4c2 100644--- a/webui/src/i18n/locales/es/common.json+++ b/webui/src/i18n/locales/es/common.json@@ -581,6 +581,8 @@"presetNamePlaceholder": "p. ej., Escritura rápida","advancedOptions": "Opciones avanzadas","advancedSummary": "Contexto {{context}} · Máx. {{max}} tokens",+ "contextWindowHint": "{{tokens}} tokens",+ "contextWindowError": "Introduce una cantidad positiva de tokens, como 200k, 1m o 131072.","maxTokens": "Máx. tokens de salida","temperature": "Temperatura","reasoningEffort": "Esfuerzo de razonamiento",diff --git a/webui/src/i18n/locales/fr/common.json b/webui/src/i18n/locales/fr/common.jsonindex 623f68e81..0d2199a48 100644--- a/webui/src/i18n/locales/fr/common.json+++ b/webui/src/i18n/locales/fr/common.json@@ -581,6 +581,8 @@"presetNamePlaceholder": "p. ex. Rédaction rapide","advancedOptions": "Options avancées","advancedSummary": "Contexte {{context}} · Max. {{max}} tokens",+ "contextWindowHint": "{{tokens}} tokens",+ "contextWindowError": "Saisissez un nombre positif de tokens, par exemple 200k, 1m ou 131072.","maxTokens": "Tokens de sortie max.","temperature": "Température","reasoningEffort": "Effort de raisonnement",diff --git a/webui/src/i18n/locales/id/common.json b/webui/src/i18n/locales/id/common.jsonindex 4d00616a4..62c2d9d00 100644--- a/webui/src/i18n/locales/id/common.json+++ b/webui/src/i18n/locales/id/common.json@@ -581,6 +581,8 @@"presetNamePlaceholder": "mis. Menulis cepat","advancedOptions": "Opsi lanjutan","advancedSummary": "Konteks {{context}} · Maks. {{max}} token",+ "contextWindowHint": "{{tokens}} token",+ "contextWindowError": "Masukkan jumlah token positif, seperti 200k, 1m, atau 131072.","maxTokens": "Maks. token keluaran","temperature": "Temperatur","reasoningEffort": "Upaya penalaran",diff --git a/webui/src/i18n/locales/ja/common.json b/webui/src/i18n/locales/ja/common.jsonindex 73321583b..31cacfe0c 100644--- a/webui/src/i18n/locales/ja/common.json+++ b/webui/src/i18n/locales/ja/common.json@@ -581,6 +581,8 @@"presetNamePlaceholder": "例:文章作成用","advancedOptions": "詳細オプション","advancedSummary": "コンテキスト {{context}} · 最大 {{max}} トークン",+ "contextWindowHint": "{{tokens}} トークン",+ "contextWindowError": "200k、1m、131072 など、正のトークン数を入力してください。","maxTokens": "最大出力トークン","temperature": "温度","reasoningEffort": "推論の強度",diff --git a/webui/src/i18n/locales/ko/common.json b/webui/src/i18n/locales/ko/common.jsonindex e8782c3fc..148ea45a8 100644--- a/webui/src/i18n/locales/ko/common.json+++ b/webui/src/i18n/locales/ko/common.json@@ -581,6 +581,8 @@"presetNamePlaceholder": "예: 빠른 작성","advancedOptions": "고급 옵션","advancedSummary": "컨텍스트 {{context}} · 최대 {{max}} 토큰",+ "contextWindowHint": "{{tokens}} 토큰",+ "contextWindowError": "200k, 1m, 131072처럼 양수 토큰 수를 입력하세요.","maxTokens": "최대 출력 토큰","temperature": "온도","reasoningEffort": "추론 강도",diff --git a/webui/src/i18n/locales/pt-BR/common.json b/webui/src/i18n/locales/pt-BR/common.jsonindex 3203d6769..de42a17c1 100644--- a/webui/src/i18n/locales/pt-BR/common.json+++ b/webui/src/i18n/locales/pt-BR/common.json@@ -279,6 +279,8 @@"presetNamePlaceholder": "ex.: Escrita rápida","advancedOptions": "Opções avançadas","advancedSummary": "Contexto {{context}} · Máx. {{max}} tokens",+ "contextWindowHint": "{{tokens}} tokens",+ "contextWindowError": "Insira uma quantidade positiva de tokens, como 200k, 1m ou 131072.","maxTokens": "Máx. de tokens de saída","temperature": "Temperatura","reasoningEffort": "Esforço de raciocínio",diff --git a/webui/src/i18n/locales/vi/common.json b/webui/src/i18n/locales/vi/common.jsonindex 93d346c81..bd2207b79 100644--- a/webui/src/i18n/locales/vi/common.json+++ b/webui/src/i18n/locales/vi/common.json@@ -581,6 +581,8 @@"presetNamePlaceholder": "ví dụ: Viết nhanh","advancedOptions": "Tùy chọn nâng cao","advancedSummary": "Ngữ cảnh {{context}} · Tối đa {{max}} token",+ "contextWindowHint": "{{tokens}} token",+ "contextWindowError": "Nhập số lượng token dương, chẳng hạn 200k, 1m hoặc 131072.","maxTokens": "Token đầu ra tối đa","temperature": "Nhiệt độ","reasoningEffort": "Mức suy luận",diff --git a/webui/src/i18n/locales/zh-CN/common.json b/webui/src/i18n/locales/zh-CN/common.jsonindex 0e3b9d086..7a8680463 100644--- a/webui/src/i18n/locales/zh-CN/common.json+++ b/webui/src/i18n/locales/zh-CN/common.json@@ -465,6 +465,8 @@"presetNamePlaceholder": "例如:快速写作","advancedOptions": "高级选项","advancedSummary": "上下文 {{context}} · 输出上限 {{max}} Token",+ "contextWindowHint": "{{tokens}} Token",+ "contextWindowError": "请输入正数 Token 数量,例如 200k、1m 或 131072。","maxTokens": "输出 Token 上限","temperature": "温度","reasoningEffort": "推理强度",diff --git a/webui/src/i18n/locales/zh-TW/common.json b/webui/src/i18n/locales/zh-TW/common.jsonindex 32b82fc4a..8a8d38be5 100644--- a/webui/src/i18n/locales/zh-TW/common.json+++ b/webui/src/i18n/locales/zh-TW/common.json@@ -581,6 +581,8 @@"presetNamePlaceholder": "例如:快速寫作","advancedOptions": "進階選項","advancedSummary": "上下文 {{context}} · 輸出上限 {{max}} Token",+ "contextWindowHint": "{{tokens}} Token",+ "contextWindowError": "請輸入正數 Token 數量,例如 200k、1m 或 131072。","maxTokens": "輸出 Token 上限","temperature": "溫度","reasoningEffort": "推理強度",diff --git a/webui/src/tests/settings-models.test.tsx b/webui/src/tests/settings-models.test.tsxindex 73535a766..dbca288f3 100644--- a/webui/src/tests/settings-models.test.tsx+++ b/webui/src/tests/settings-models.test.tsx@@ -283,17 +283,48 @@ describe("Settings models", () => {expect(await screen.findByText("Context window")).toBeInTheDocument();expect(screen.getByText("Temperature")).toBeInTheDocument();- expect(screen.getByRole("button", { name: "64K" })).toBeInTheDocument();- expect(screen.getByRole("button", { name: "200K" })).toBeInTheDocument();- expect(screen.getByRole("button", { name: "256K" })).toBeInTheDocument();- expect(screen.getByRole("button", { name: "500K" })).toBeInTheDocument();- expect(screen.getByRole("button", { name: "1M" })).toBeInTheDocument();+ expect(screen.getByRole("textbox", { name: "Context window" })).toHaveValue("200k");const reasoningEffort = screen.getByLabelText("Reasoning effort");expect(reasoningEffort).toHaveProperty("type", "text");fireEvent.change(reasoningEffort, { target: { value: "provider-native-mode" } });expect(reasoningEffort).toHaveValue("provider-native-mode");});+ it.each([["128000", 128000], ["131072", 131072], ["272k", 272000], ["256K", 256000], ["1.5m", 1500000], ["1.001k", 1001]] as const)("saves a custom context budget (%s)", async (input, tokens) => {+ const payload = settingsPayload();+ vi.stubGlobal("fetch", vi.fn(() => new Promise<Response>(() => {})));+ requestMutationMock.mockResolvedValue({+ ...payload,+ model_presets: payload.model_presets.map((preset) => ({ ...preset, context_window_tokens: tokens })),+ });+ renderSettingsView({ initialSection: "models", initialSettings: payload });+ await togglePresetEditor();+ fireEvent.click(screen.getByRole("button", { name: /Advanced options/ }));+ fireEvent.change(screen.getByRole("textbox", { name: "Context window" }), {+ target: { value: input },+ });+ fireEvent.click(screen.getByRole("button", { name: "Save" }));+ await waitFor(() => expect(requestMutationMock).toHaveBeenCalledWith(+ "settings.model_configuration.update", expect.objectContaining({ context_window_tokens: tokens }), expect.any(Number),+ ));+ expect(screen.getByRole("textbox", { name: "Context window" })).toHaveValue(input);+ });++ it.each(["", "0", "-1", "1.5", "abc", "2ki", "0.0001k", "9007199254740992"])("keeps invalid context input unsaved (%s)", async (value) => {+ vi.stubGlobal("fetch", vi.fn(() => new Promise<Response>(() => {})));+ renderSettingsView({ initialSection: "models", initialSettings: settingsPayload() });+ await togglePresetEditor();+ fireEvent.click(screen.getByRole("button", { name: /Advanced options/ }));+ const input = screen.getByRole("textbox", { name: "Context window" });+ fireEvent.change(input, { target: { value } });+ fireEvent.click(screen.getByRole("button", { name: "Save" }));+ expect(input).toHaveAttribute("aria-invalid", "true");+ expect(input).toHaveAccessibleDescription("Enter a positive token count, such as 200k, 1m, or 131072.");+ await new Promise((resolve) => setTimeout(resolve, 750));+ expect(requestMutationMock).not.toHaveBeenCalled();+ expect(input).toHaveValue(value);+ });+it("opens the preset editor in a dialog and protects the primary preset", async () => {vi.stubGlobal("fetch",