🎧 Your Personal Streaming Service
Go airsonicmadsonicmedia-servermusicmusic-servernavidromeopensubsonicraspberry-piself-hostedstreamerstreaming-apistreaming-audiosubsonicsubsonic-server
fix(plugins): don't recording metrics for not implemented plugin calls
Deluan2068e7d413c9
diff --git a/plugins/manager_call.go b/plugins/manager_call.goindex 834f45425..b5c7536b6 100644--- a/plugins/manager_call.go+++ b/plugins/manager_call.go@@ -73,7 +73,8 @@ func callPluginFunction[I any, O any](ctx context.Context, plugin *plugin, funcNif exit != 0 {if exit == notImplementedCode {log.Trace(ctx, "Plugin function not implemented", "plugin", plugin.name, "function", funcName, "pluginDuration", elapsed, "navidromeDuration", startCall.Sub(start))- plugin.metrics.RecordPluginRequest(ctx, plugin.name, funcName, true, elapsed.Milliseconds())+ // TODO Should we record metrics for not implemented calls?+ //plugin.metrics.RecordPluginRequest(ctx, plugin.name, funcName, true, elapsed.Milliseconds())return result, fmt.Errorf("%w: %s", errNotImplemented, funcName)}plugin.metrics.RecordPluginRequest(ctx, plugin.name, funcName, false, elapsed.Milliseconds())diff --git a/plugins/manager_call_test.go b/plugins/manager_call_test.goindex 32e9df99f..8865e1266 100644--- a/plugins/manager_call_test.go+++ b/plugins/manager_call_test.go@@ -106,7 +106,7 @@ var _ = Describe("callPluginFunction metrics", Ordered, func() {Expect(calls[0].ok).To(BeFalse())})- It("records metrics for not-implemented functions", func() {+ It("does not record metrics for not-implemented functions", func() {// Use partial metadata agent that doesn't implement GetArtistMBIDpartialRecorder := &mockMetricsRecorder{}partialManager, _ := createTestManagerWithPluginsAndMetrics(@@ -123,9 +123,6 @@ var _ = Describe("callPluginFunction metrics", Ordered, func() {Expect(err).To(MatchError(errNotImplemented))calls := partialRecorder.getCalls()- Expect(calls).To(HaveLen(1))- Expect(calls[0].plugin).To(Equal("partial-metadata-agent"))- Expect(calls[0].method).To(Equal(FuncGetArtistMBID))- Expect(calls[0].ok).To(BeTrue())+ Expect(calls).To(HaveLen(0))})})