🎧 Your Personal Streaming Service
Go airsonicmadsonicmedia-servermusicmusic-servernavidromeopensubsonicraspberry-piself-hostedstreamerstreaming-apistreaming-audiosubsonicsubsonic-server
refactor(migrations): propagate context.Context through all DB calls
Deluan32ac53dc9f72
diff --git a/.golangci.yml b/.golangci.ymlindex 28eb375a5..76eb882ca 100644--- a/.golangci.yml+++ b/.golangci.yml@@ -13,6 +13,7 @@ linters:- dogsled- durationcheck- errorlint+ - forbidigo- gocritic- gocyclo- goprintffuncname@@ -36,6 +37,14 @@ linters:- G401- G505- G115+ forbidigo:+ forbid:+ - pattern: 'tx\.Exec$'+ msg: "use tx.ExecContext(ctx, ...) in migrations to propagate context"+ - pattern: 'tx\.Query$'+ msg: "use tx.QueryContext(ctx, ...) in migrations to propagate context"+ - pattern: 'tx\.QueryRow$'+ msg: "use tx.QueryRowContext(ctx, ...) in migrations to propagate context"govet:enable:- nilness@@ -45,6 +54,9 @@ linters:- gosecpath: _test\.gotext: "G703"+ - path-except: 'db/migrations/'+ linters:+ - forbidigogenerated: laxpresets:- commentsdiff --git a/db/migrations/20200130083147_create_schema.go b/db/migrations/20200130083147_create_schema.goindex 2fae4f57d..250fb00a5 100644--- a/db/migrations/20200130083147_create_schema.go+++ b/db/migrations/20200130083147_create_schema.go@@ -12,9 +12,9 @@ func init() {goose.AddMigrationContext(Up20200130083147, Down20200130083147)}-func Up20200130083147(_ context.Context, tx *sql.Tx) error {+func Up20200130083147(ctx context.Context, tx *sql.Tx) error {log.Info("Creating DB Schema")- _, err := tx.Exec(`+ _, err := tx.ExecContext(ctx, `create table if not exists album(id varchar(255) not null@@ -179,6 +179,6 @@ create table if not exists userreturn err}-func Down20200130083147(_ context.Context, tx *sql.Tx) error {+func Down20200130083147(_ context.Context, _ *sql.Tx) error {return nil}diff --git a/db/migrations/20200131183653_standardize_item_type.go b/db/migrations/20200131183653_standardize_item_type.goindex 471dc8002..bf7d9d5f7 100644--- a/db/migrations/20200131183653_standardize_item_type.go+++ b/db/migrations/20200131183653_standardize_item_type.go@@ -11,8 +11,8 @@ func init() {goose.AddMigrationContext(Up20200131183653, Down20200131183653)}-func Up20200131183653(_ context.Context, tx *sql.Tx) error {- _, err := tx.Exec(`+func Up20200131183653(ctx context.Context, tx *sql.Tx) error {+ _, err := tx.ExecContext(ctx, `create table search_dg_tmp(id varchar(255) not null@@ -37,8 +37,8 @@ update annotation set item_type = 'media_file' where item_type = 'mediaFile';return err}-func Down20200131183653(_ context.Context, tx *sql.Tx) error {- _, err := tx.Exec(`+func Down20200131183653(ctx context.Context, tx *sql.Tx) error {+ _, err := tx.ExecContext(ctx, `create table search_dg_tmp(id varchar(255) not nulldiff --git a/db/migrations/20200208222418_add_defaults_to_annotations.go b/db/migrations/20200208222418_add_defaults_to_annotations.goindex d058b02c3..6807c8ad2 100644--- a/db/migrations/20200208222418_add_defaults_to_annotations.go+++ b/db/migrations/20200208222418_add_defaults_to_annotations.go@@ -11,8 +11,8 @@ func init() {goose.AddMigrationContext(Up20200208222418, Down20200208222418)}-func Up20200208222418(_ context.Context, tx *sql.Tx) error {- _, err := tx.Exec(`+func Up20200208222418(ctx context.Context, tx *sql.Tx) error {+ _, err := tx.ExecContext(ctx, `update annotation set play_count = 0 where play_count is null;update annotation set rating = 0 where rating is null;create table annotation_dg_tmp@@ -51,6 +51,6 @@ create index annotation_starredreturn err}-func Down20200208222418(_ context.Context, tx *sql.Tx) error {+func Down20200208222418(_ context.Context, _ *sql.Tx) error {return nil}diff --git a/db/migrations/20200220143731_change_duration_to_float.go b/db/migrations/20200220143731_change_duration_to_float.goindex 72b785ef8..ea5465ade 100644--- a/db/migrations/20200220143731_change_duration_to_float.go+++ b/db/migrations/20200220143731_change_duration_to_float.go@@ -11,9 +11,9 @@ func init() {goose.AddMigrationContext(Up20200220143731, Down20200220143731)}-func Up20200220143731(_ context.Context, tx *sql.Tx) error {- notice(tx, "This migration will force the next scan to be a full rescan!")- _, err := tx.Exec(`+func Up20200220143731(ctx context.Context, tx *sql.Tx) error {+ notice(ctx, tx, "This migration will force the next scan to be a full rescan!")+ _, err := tx.ExecContext(ctx, `create table media_file_dg_tmp(id varchar(255) not null@@ -125,6 +125,6 @@ update media_file set updated_at = '0001-01-01';return err}-func Down20200220143731(_ context.Context, tx *sql.Tx) error {+func Down20200220143731(_ context.Context, _ *sql.Tx) error {return nil}diff --git a/db/migrations/20200310171621_enable_search_by_albumartist.go b/db/migrations/20200310171621_enable_search_by_albumartist.goindex 373e0a475..73436c890 100644--- a/db/migrations/20200310171621_enable_search_by_albumartist.go+++ b/db/migrations/20200310171621_enable_search_by_albumartist.go@@ -11,11 +11,11 @@ func init() {goose.AddMigrationContext(Up20200310171621, Down20200310171621)}-func Up20200310171621(_ context.Context, tx *sql.Tx) error {- notice(tx, "A full rescan will be performed to enable search by Album Artist!")- return forceFullRescan(tx)+func Up20200310171621(ctx context.Context, tx *sql.Tx) error {+ notice(ctx, tx, "A full rescan will be performed to enable search by Album Artist!")+ return forceFullRescan(ctx, tx)}-func Down20200310171621(_ context.Context, tx *sql.Tx) error {+func Down20200310171621(_ context.Context, _ *sql.Tx) error {return nil}diff --git a/db/migrations/20200310181627_add_transcoding_and_player_tables.go b/db/migrations/20200310181627_add_transcoding_and_player_tables.goindex 3be91ac35..ef872c4ae 100644--- a/db/migrations/20200310181627_add_transcoding_and_player_tables.go+++ b/db/migrations/20200310181627_add_transcoding_and_player_tables.go@@ -11,8 +11,8 @@ func init() {goose.AddMigrationContext(Up20200310181627, Down20200310181627)}-func Up20200310181627(_ context.Context, tx *sql.Tx) error {- _, err := tx.Exec(`+func Up20200310181627(ctx context.Context, tx *sql.Tx) error {+ _, err := tx.ExecContext(ctx, `create table transcoding(id varchar(255) not null primary key,@@ -45,8 +45,8 @@ create table playerreturn err}-func Down20200310181627(_ context.Context, tx *sql.Tx) error {- _, err := tx.Exec(`+func Down20200310181627(ctx context.Context, tx *sql.Tx) error {+ _, err := tx.ExecContext(ctx, `drop table transcoding;drop table player;`)diff --git a/db/migrations/20200319211049_merge_search_into_main_tables.go b/db/migrations/20200319211049_merge_search_into_main_tables.goindex f888cdd4c..a7a6ff0f9 100644--- a/db/migrations/20200319211049_merge_search_into_main_tables.go+++ b/db/migrations/20200319211049_merge_search_into_main_tables.go@@ -11,8 +11,8 @@ func init() {goose.AddMigrationContext(Up20200319211049, Down20200319211049)}-func Up20200319211049(_ context.Context, tx *sql.Tx) error {- _, err := tx.Exec(`+func Up20200319211049(ctx context.Context, tx *sql.Tx) error {+ _, err := tx.ExecContext(ctx, `alter table media_fileadd full_text varchar(255) default '';create index if not exists media_file_full_text@@ -33,10 +33,10 @@ drop table if exists search;if err != nil {return err}- notice(tx, "A full rescan will be performed!")- return forceFullRescan(tx)+ notice(ctx, tx, "A full rescan will be performed!")+ return forceFullRescan(ctx, tx)}-func Down20200319211049(_ context.Context, tx *sql.Tx) error {+func Down20200319211049(_ context.Context, _ *sql.Tx) error {return nil}diff --git a/db/migrations/20200325185135_add_album_artist_id.go b/db/migrations/20200325185135_add_album_artist_id.goindex f01f2c558..01537f886 100644--- a/db/migrations/20200325185135_add_album_artist_id.go+++ b/db/migrations/20200325185135_add_album_artist_id.go@@ -11,8 +11,8 @@ func init() {goose.AddMigrationContext(Up20200325185135, Down20200325185135)}-func Up20200325185135(_ context.Context, tx *sql.Tx) error {- _, err := tx.Exec(`+func Up20200325185135(ctx context.Context, tx *sql.Tx) error {+ _, err := tx.ExecContext(ctx, `alter table albumadd album_artist_id varchar(255) default '';create index album_artist_album_id@@ -26,10 +26,10 @@ create index media_file_artist_album_idif err != nil {return err}- notice(tx, "A full rescan will be performed!")- return forceFullRescan(tx)+ notice(ctx, tx, "A full rescan will be performed!")+ return forceFullRescan(ctx, tx)}-func Down20200325185135(_ context.Context, tx *sql.Tx) error {+func Down20200325185135(_ context.Context, _ *sql.Tx) error {return nil}diff --git a/db/migrations/20200326090707_fix_album_artists_importing.go b/db/migrations/20200326090707_fix_album_artists_importing.goindex c42e8c327..17afe37fe 100644--- a/db/migrations/20200326090707_fix_album_artists_importing.go+++ b/db/migrations/20200326090707_fix_album_artists_importing.go@@ -11,11 +11,11 @@ func init() {goose.AddMigrationContext(Up20200326090707, Down20200326090707)}-func Up20200326090707(_ context.Context, tx *sql.Tx) error {- notice(tx, "A full rescan will be performed!")- return forceFullRescan(tx)+func Up20200326090707(ctx context.Context, tx *sql.Tx) error {+ notice(ctx, tx, "A full rescan will be performed!")+ return forceFullRescan(ctx, tx)}-func Down20200326090707(_ context.Context, tx *sql.Tx) error {+func Down20200326090707(_ context.Context, _ *sql.Tx) error {return nil}diff --git a/db/migrations/20200327193744_add_year_range_to_album.go b/db/migrations/20200327193744_add_year_range_to_album.goindex 66f2b23e8..d9b048e22 100644--- a/db/migrations/20200327193744_add_year_range_to_album.go+++ b/db/migrations/20200327193744_add_year_range_to_album.go@@ -11,8 +11,8 @@ func init() {goose.AddMigrationContext(Up20200327193744, Down20200327193744)}-func Up20200327193744(_ context.Context, tx *sql.Tx) error {- _, err := tx.Exec(`+func Up20200327193744(ctx context.Context, tx *sql.Tx) error {+ _, err := tx.ExecContext(ctx, `create table album_dg_tmp(id varchar(255) not null@@ -72,10 +72,10 @@ create index album_max_yearif err != nil {return err}- notice(tx, "A full rescan will be performed!")- return forceFullRescan(tx)+ notice(ctx, tx, "A full rescan will be performed!")+ return forceFullRescan(ctx, tx)}-func Down20200327193744(_ context.Context, tx *sql.Tx) error {+func Down20200327193744(_ context.Context, _ *sql.Tx) error {return nil}diff --git a/db/migrations/20200404214704_add_indexes.go b/db/migrations/20200404214704_add_indexes.goindex 6207b0a3d..8b8d8607e 100644--- a/db/migrations/20200404214704_add_indexes.go+++ b/db/migrations/20200404214704_add_indexes.go@@ -11,8 +11,8 @@ func init() {goose.AddMigrationContext(Up20200404214704, Down20200404214704)}-func Up20200404214704(_ context.Context, tx *sql.Tx) error {- _, err := tx.Exec(`+func Up20200404214704(ctx context.Context, tx *sql.Tx) error {+ _, err := tx.ExecContext(ctx, `create index if not exists media_file_yearon media_file (year);@@ -25,6 +25,6 @@ create index if not exists media_file_track_numberreturn err}-func Down20200404214704(_ context.Context, tx *sql.Tx) error {+func Down20200404214704(_ context.Context, _ *sql.Tx) error {return nil}diff --git a/db/migrations/20200409002249_enable_search_by_tracks_artists.go b/db/migrations/20200409002249_enable_search_by_tracks_artists.goindex 22006c8af..482341a89 100644--- a/db/migrations/20200409002249_enable_search_by_tracks_artists.go+++ b/db/migrations/20200409002249_enable_search_by_tracks_artists.go@@ -11,11 +11,11 @@ func init() {goose.AddMigrationContext(Up20200409002249, Down20200409002249)}-func Up20200409002249(_ context.Context, tx *sql.Tx) error {- notice(tx, "A full rescan will be performed to enable search by individual Artist in an Album!")- return forceFullRescan(tx)+func Up20200409002249(ctx context.Context, tx *sql.Tx) error {+ notice(ctx, tx, "A full rescan will be performed to enable search by individual Artist in an Album!")+ return forceFullRescan(ctx, tx)}-func Down20200409002249(_ context.Context, tx *sql.Tx) error {+func Down20200409002249(_ context.Context, _ *sql.Tx) error {return nil}diff --git a/db/migrations/20200411164603_add_created_and_updated_fields_to_playlists.go b/db/migrations/20200411164603_add_created_and_updated_fields_to_playlists.goindex 266dc087d..4aa502b4b 100644--- a/db/migrations/20200411164603_add_created_and_updated_fields_to_playlists.go+++ b/db/migrations/20200411164603_add_created_and_updated_fields_to_playlists.go@@ -11,8 +11,8 @@ func init() {goose.AddMigrationContext(Up20200411164603, Down20200411164603)}-func Up20200411164603(_ context.Context, tx *sql.Tx) error {- _, err := tx.Exec(`+func Up20200411164603(ctx context.Context, tx *sql.Tx) error {+ _, err := tx.ExecContext(ctx, `alter table playlistadd created_at datetime;alter table playlist@@ -23,6 +23,6 @@ update playlistreturn err}-func Down20200411164603(_ context.Context, tx *sql.Tx) error {+func Down20200411164603(_ context.Context, _ *sql.Tx) error {return nil}diff --git a/db/migrations/20200418110522_reindex_to_fix_album_years.go b/db/migrations/20200418110522_reindex_to_fix_album_years.goindex 22b024cea..54e03f4c6 100644--- a/db/migrations/20200418110522_reindex_to_fix_album_years.go+++ b/db/migrations/20200418110522_reindex_to_fix_album_years.go@@ -11,11 +11,11 @@ func init() {goose.AddMigrationContext(Up20200418110522, Down20200418110522)}-func Up20200418110522(_ context.Context, tx *sql.Tx) error {- notice(tx, "A full rescan will be performed to fix search Albums by year")- return forceFullRescan(tx)+func Up20200418110522(ctx context.Context, tx *sql.Tx) error {+ notice(ctx, tx, "A full rescan will be performed to fix search Albums by year")+ return forceFullRescan(ctx, tx)}-func Down20200418110522(_ context.Context, tx *sql.Tx) error {+func Down20200418110522(_ context.Context, _ *sql.Tx) error {return nil}diff --git a/db/migrations/20200419222708_reindex_to_change_full_text_search.go b/db/migrations/20200419222708_reindex_to_change_full_text_search.goindex efeb1bb84..89e3ccee5 100644--- a/db/migrations/20200419222708_reindex_to_change_full_text_search.go+++ b/db/migrations/20200419222708_reindex_to_change_full_text_search.go@@ -11,11 +11,11 @@ func init() {goose.AddMigrationContext(Up20200419222708, Down20200419222708)}-func Up20200419222708(_ context.Context, tx *sql.Tx) error {- notice(tx, "A full rescan will be performed to change the search behaviour")- return forceFullRescan(tx)+func Up20200419222708(ctx context.Context, tx *sql.Tx) error {+ notice(ctx, tx, "A full rescan will be performed to change the search behaviour")+ return forceFullRescan(ctx, tx)}-func Down20200419222708(_ context.Context, tx *sql.Tx) error {+func Down20200419222708(_ context.Context, _ *sql.Tx) error {return nil}diff --git a/db/migrations/20200423204116_add_sort_fields.go b/db/migrations/20200423204116_add_sort_fields.goindex 4097a9d60..a51bb2270 100644--- a/db/migrations/20200423204116_add_sort_fields.go+++ b/db/migrations/20200423204116_add_sort_fields.go@@ -11,8 +11,8 @@ func init() {goose.AddMigrationContext(Up20200423204116, Down20200423204116)}-func Up20200423204116(_ context.Context, tx *sql.Tx) error {- _, err := tx.Exec(`+func Up20200423204116(ctx context.Context, tx *sql.Tx) error {+ _, err := tx.ExecContext(ctx, `alter table artistadd order_artist_name varchar(255) collate nocase;alter table artist@@ -57,10 +57,10 @@ create index if not exists media_file_order_artist_nameif err != nil {return err}- notice(tx, "A full rescan will be performed to change the search behaviour")- return forceFullRescan(tx)+ notice(ctx, tx, "A full rescan will be performed to change the search behaviour")+ return forceFullRescan(ctx, tx)}-func Down20200423204116(_ context.Context, tx *sql.Tx) error {+func Down20200423204116(_ context.Context, _ *sql.Tx) error {return nil}diff --git a/db/migrations/20200508093059_add_artist_song_count.go b/db/migrations/20200508093059_add_artist_song_count.goindex aac78e698..72a47bc94 100644--- a/db/migrations/20200508093059_add_artist_song_count.go+++ b/db/migrations/20200508093059_add_artist_song_count.go@@ -11,18 +11,18 @@ func init() {goose.AddMigrationContext(Up20200508093059, Down20200508093059)}-func Up20200508093059(_ context.Context, tx *sql.Tx) error {- _, err := tx.Exec(`+func Up20200508093059(ctx context.Context, tx *sql.Tx) error {+ _, err := tx.ExecContext(ctx, `alter table artistadd song_count integer default 0 not null;`)if err != nil {return err}- notice(tx, "A full rescan will be performed to calculate artists' song counts")- return forceFullRescan(tx)+ notice(ctx, tx, "A full rescan will be performed to calculate artists' song counts")+ return forceFullRescan(ctx, tx)}-func Down20200508093059(_ context.Context, tx *sql.Tx) error {+func Down20200508093059(_ context.Context, _ *sql.Tx) error {return nil}diff --git a/db/migrations/20200512104202_add_disc_subtitle.go b/db/migrations/20200512104202_add_disc_subtitle.goindex b3e907d8d..29734e0c0 100644--- a/db/migrations/20200512104202_add_disc_subtitle.go+++ b/db/migrations/20200512104202_add_disc_subtitle.go@@ -11,18 +11,18 @@ func init() {goose.AddMigrationContext(Up20200512104202, Down20200512104202)}-func Up20200512104202(_ context.Context, tx *sql.Tx) error {- _, err := tx.Exec(`+func Up20200512104202(ctx context.Context, tx *sql.Tx) error {+ _, err := tx.ExecContext(ctx, `alter table media_fileadd disc_subtitle varchar(255);`)if err != nil {return err}- notice(tx, "A full rescan will be performed to import disc subtitles")- return forceFullRescan(tx)+ notice(ctx, tx, "A full rescan will be performed to import disc subtitles")+ return forceFullRescan(ctx, tx)}-func Down20200512104202(_ context.Context, tx *sql.Tx) error {+func Down20200512104202(_ context.Context, _ *sql.Tx) error {return nil}diff --git a/db/migrations/20200516140647_add_playlist_tracks_table.go b/db/migrations/20200516140647_add_playlist_tracks_table.goindex fcaae9d8e..59265e410 100644--- a/db/migrations/20200516140647_add_playlist_tracks_table.go+++ b/db/migrations/20200516140647_add_playlist_tracks_table.go@@ -13,8 +13,8 @@ func init() {goose.AddMigrationContext(Up20200516140647, Down20200516140647)}-func Up20200516140647(_ context.Context, tx *sql.Tx) error {- _, err := tx.Exec(`+func Up20200516140647(ctx context.Context, tx *sql.Tx) error {+ _, err := tx.ExecContext(ctx, `create table if not exists playlist_tracks(id integer default 0 not null,@@ -28,7 +28,7 @@ create unique index if not exists playlist_tracks_posif err != nil {return err}- rows, err := tx.Query("select id, tracks from playlist")+ rows, err := tx.QueryContext(ctx, "select id, tracks from playlist")if err != nil {return err}@@ -49,7 +49,7 @@ create unique index if not exists playlist_tracks_posreturn err}- _, err = tx.Exec(`+ _, err = tx.ExecContext(ctx, `create table playlist_dg_tmp(id varchar(255) not null@@ -96,6 +96,6 @@ func Up20200516140647UpdatePlaylistTracks(tx *sql.Tx, id string, tracks string)return nil}-func Down20200516140647(_ context.Context, tx *sql.Tx) error {+func Down20200516140647(_ context.Context, _ *sql.Tx) error {return nil}diff --git a/db/migrations/20200608153717_referential_integrity.go b/db/migrations/20200608153717_referential_integrity.goindex 2959237fa..c9c766f7e 100644--- a/db/migrations/20200608153717_referential_integrity.go+++ b/db/migrations/20200608153717_referential_integrity.go@@ -11,46 +11,46 @@ func init() {goose.AddMigrationContext(Up20200608153717, Down20200608153717)}-func Up20200608153717(_ context.Context, tx *sql.Tx) error {+func Up20200608153717(ctx context.Context, tx *sql.Tx) error {// First delete dangling players- _, err := tx.Exec(`+ _, err := tx.ExecContext(ctx, `delete from player where user_name not in (select user_name from user)`)if err != nil {return err}// Also delete dangling players- _, err = tx.Exec(`+ _, err = tx.ExecContext(ctx, `delete from playlist where owner not in (select user_name from user)`)if err != nil {return err}// Also delete dangling playlist tracks- _, err = tx.Exec(`+ _, err = tx.ExecContext(ctx, `delete from playlist_tracks where playlist_id not in (select id from playlist)`)if err != nil {return err}// Add foreign key to player table- err = updatePlayer_20200608153717(tx)+ err = updatePlayer_20200608153717(ctx, tx)if err != nil {return err}// Add foreign key to playlist table- err = updatePlaylist_20200608153717(tx)+ err = updatePlaylist_20200608153717(ctx, tx)if err != nil {return err}// Add foreign keys to playlist_tracks table- return updatePlaylistTracks_20200608153717(tx)+ return updatePlaylistTracks_20200608153717(ctx, tx)}-func updatePlayer_20200608153717(tx *sql.Tx) error {- _, err := tx.Exec(`+func updatePlayer_20200608153717(ctx context.Context, tx *sql.Tx) error {+ _, err := tx.ExecContext(ctx, `create table player_dg_tmp(id varchar(255) not null@@ -77,8 +77,8 @@ alter table player_dg_tmp rename to player;return err}-func updatePlaylist_20200608153717(tx *sql.Tx) error {- _, err := tx.Exec(`+func updatePlaylist_20200608153717(ctx context.Context, tx *sql.Tx) error {+ _, err := tx.ExecContext(ctx, `create table playlist_dg_tmp(id varchar(255) not null@@ -108,8 +108,8 @@ create index playlist_namereturn err}-func updatePlaylistTracks_20200608153717(tx *sql.Tx) error {- _, err := tx.Exec(`+func updatePlaylistTracks_20200608153717(ctx context.Context, tx *sql.Tx) error {+ _, err := tx.ExecContext(ctx, `create table playlist_tracks_dg_tmp(id integer default 0 not null,@@ -133,6 +133,6 @@ create unique index playlist_tracks_posreturn err}-func Down20200608153717(_ context.Context, tx *sql.Tx) error {+func Down20200608153717(_ context.Context, _ *sql.Tx) error {return nil}diff --git a/db/migrations/20200706231659_add_default_transcodings.go b/db/migrations/20200706231659_add_default_transcodings.goindex a498d32b0..e87481ae1 100644--- a/db/migrations/20200706231659_add_default_transcodings.go+++ b/db/migrations/20200706231659_add_default_transcodings.go@@ -13,8 +13,8 @@ func init() {goose.AddMigrationContext(upAddDefaultTranscodings, downAddDefaultTranscodings)}-func upAddDefaultTranscodings(_ context.Context, tx *sql.Tx) error {- row := tx.QueryRow("SELECT COUNT(*) FROM transcoding")+func upAddDefaultTranscodings(ctx context.Context, tx *sql.Tx) error {+ row := tx.QueryRowContext(ctx, "SELECT COUNT(*) FROM transcoding")var count interr := row.Scan(&count)if err != nil {@@ -38,6 +38,6 @@ func upAddDefaultTranscodings(_ context.Context, tx *sql.Tx) error {return nil}-func downAddDefaultTranscodings(_ context.Context, tx *sql.Tx) error {+func downAddDefaultTranscodings(_ context.Context, _ *sql.Tx) error {return nil}diff --git a/db/migrations/20200710211442_add_playlist_path.go b/db/migrations/20200710211442_add_playlist_path.goindex 8abfed6cf..32cc8d034 100644--- a/db/migrations/20200710211442_add_playlist_path.go+++ b/db/migrations/20200710211442_add_playlist_path.go@@ -11,8 +11,8 @@ func init() {goose.AddMigrationContext(upAddPlaylistPath, downAddPlaylistPath)}-func upAddPlaylistPath(_ context.Context, tx *sql.Tx) error {- _, err := tx.Exec(`+func upAddPlaylistPath(ctx context.Context, tx *sql.Tx) error {+ _, err := tx.ExecContext(ctx, `alter table playlistadd path string default '' not null;@@ -23,6 +23,6 @@ alter table playlistreturn err}-func downAddPlaylistPath(_ context.Context, tx *sql.Tx) error {+func downAddPlaylistPath(_ context.Context, _ *sql.Tx) error {return nil}diff --git a/db/migrations/20200731095603_create_play_queues_table.go b/db/migrations/20200731095603_create_play_queues_table.goindex d63a1ecb9..7a27137bc 100644--- a/db/migrations/20200731095603_create_play_queues_table.go+++ b/db/migrations/20200731095603_create_play_queues_table.go@@ -11,8 +11,8 @@ func init() {goose.AddMigrationContext(upCreatePlayQueuesTable, downCreatePlayQueuesTable)}-func upCreatePlayQueuesTable(_ context.Context, tx *sql.Tx) error {- _, err := tx.Exec(`+func upCreatePlayQueuesTable(ctx context.Context, tx *sql.Tx) error {+ _, err := tx.ExecContext(ctx, `create table playqueue(id varchar(255) not null primary key,@@ -32,6 +32,6 @@ create table playqueuereturn err}-func downCreatePlayQueuesTable(_ context.Context, tx *sql.Tx) error {+func downCreatePlayQueuesTable(_ context.Context, _ *sql.Tx) error {return nil}diff --git a/db/migrations/20200801101355_create_bookmark_table.go b/db/migrations/20200801101355_create_bookmark_table.goindex fe68fafd7..df814d7b8 100644--- a/db/migrations/20200801101355_create_bookmark_table.go+++ b/db/migrations/20200801101355_create_bookmark_table.go@@ -11,8 +11,8 @@ func init() {goose.AddMigrationContext(upCreateBookmarkTable, downCreateBookmarkTable)}-func upCreateBookmarkTable(_ context.Context, tx *sql.Tx) error {- _, err := tx.Exec(`+func upCreateBookmarkTable(ctx context.Context, tx *sql.Tx) error {+ _, err := tx.ExecContext(ctx, `create table bookmark(user_id varchar(255) not null@@ -49,6 +49,6 @@ alter table playqueue_dg_tmp rename to playqueue;return err}-func downCreateBookmarkTable(_ context.Context, tx *sql.Tx) error {+func downCreateBookmarkTable(_ context.Context, _ *sql.Tx) error {return nil}diff --git a/db/migrations/20200819111809_drop_email_unique_constraint.go b/db/migrations/20200819111809_drop_email_unique_constraint.goindex b2dd4285c..8259ad3fe 100644--- a/db/migrations/20200819111809_drop_email_unique_constraint.go+++ b/db/migrations/20200819111809_drop_email_unique_constraint.go@@ -11,8 +11,8 @@ func init() {goose.AddMigrationContext(upDropEmailUniqueConstraint, downDropEmailUniqueConstraint)}-func upDropEmailUniqueConstraint(_ context.Context, tx *sql.Tx) error {- _, err := tx.Exec(`+func upDropEmailUniqueConstraint(ctx context.Context, tx *sql.Tx) error {+ _, err := tx.ExecContext(ctx, `create table user_dg_tmp(id varchar(255) not null@@ -38,6 +38,6 @@ alter table user_dg_tmp rename to user;return err}-func downDropEmailUniqueConstraint(_ context.Context, tx *sql.Tx) error {+func downDropEmailUniqueConstraint(_ context.Context, _ *sql.Tx) error {return nil}diff --git a/db/migrations/20201003111749_add_starred_at_index.go b/db/migrations/20201003111749_add_starred_at_index.goindex 7ee7a283f..b46430743 100644--- a/db/migrations/20201003111749_add_starred_at_index.go+++ b/db/migrations/20201003111749_add_starred_at_index.go@@ -11,14 +11,14 @@ func init() {goose.AddMigrationContext(Up20201003111749, Down20201003111749)}-func Up20201003111749(_ context.Context, tx *sql.Tx) error {- _, err := tx.Exec(`+func Up20201003111749(ctx context.Context, tx *sql.Tx) error {+ _, err := tx.ExecContext(ctx, `create index if not exists annotation_starred_aton annotation (starred_at);`)return err}-func Down20201003111749(_ context.Context, tx *sql.Tx) error {+func Down20201003111749(_ context.Context, _ *sql.Tx) error {return nil}diff --git a/db/migrations/20201010162350_add_album_size.go b/db/migrations/20201010162350_add_album_size.goindex f1182ab6c..df1fa8ca2 100644--- a/db/migrations/20201010162350_add_album_size.go+++ b/db/migrations/20201010162350_add_album_size.go@@ -11,8 +11,8 @@ func init() {goose.AddMigrationContext(Up20201010162350, Down20201010162350)}-func Up20201010162350(_ context.Context, tx *sql.Tx) error {- _, err := tx.Exec(`+func Up20201010162350(ctx context.Context, tx *sql.Tx) error {+ _, err := tx.ExecContext(ctx, `alter table albumadd size integer default 0 not null;create index if not exists album_size@@ -28,7 +28,7 @@ where id not null;`)return err}-func Down20201010162350(_ context.Context, tx *sql.Tx) error {+func Down20201010162350(ctx context.Context, tx *sql.Tx) error {// This code is executed when the migration is rolled back.return nil}diff --git a/db/migrations/20201012210022_add_artist_playlist_size.go b/db/migrations/20201012210022_add_artist_playlist_size.goindex 4eb67f14e..1c738dd1e 100644--- a/db/migrations/20201012210022_add_artist_playlist_size.go+++ b/db/migrations/20201012210022_add_artist_playlist_size.go@@ -11,8 +11,8 @@ func init() {goose.AddMigrationContext(Up20201012210022, Down20201012210022)}-func Up20201012210022(_ context.Context, tx *sql.Tx) error {- _, err := tx.Exec(`+func Up20201012210022(ctx context.Context, tx *sql.Tx) error {+ _, err := tx.ExecContext(ctx, `alter table artistadd size integer default 0 not null;create index if not exists artist_size@@ -40,6 +40,6 @@ update playlist set size = ifnull((return err}-func Down20201012210022(_ context.Context, tx *sql.Tx) error {+func Down20201012210022(_ context.Context, _ *sql.Tx) error {return nil}diff --git a/db/migrations/20201021085410_add_mbids.go b/db/migrations/20201021085410_add_mbids.goindex 624bb1a67..53001fc73 100644--- a/db/migrations/20201021085410_add_mbids.go+++ b/db/migrations/20201021085410_add_mbids.go@@ -11,8 +11,8 @@ func init() {goose.AddMigrationContext(Up20201021085410, Down20201021085410)}-func Up20201021085410(_ context.Context, tx *sql.Tx) error {- _, err := tx.Exec(`+func Up20201021085410(ctx context.Context, tx *sql.Tx) error {+ _, err := tx.ExecContext(ctx, `alter table media_fileadd mbz_track_id varchar(255);alter table media_file@@ -49,11 +49,11 @@ alter table artistif err != nil {return err}- notice(tx, "A full rescan needs to be performed to import more tags")- return forceFullRescan(tx)+ notice(ctx, tx, "A full rescan needs to be performed to import more tags")+ return forceFullRescan(ctx, tx)}-func Down20201021085410(_ context.Context, tx *sql.Tx) error {+func Down20201021085410(ctx context.Context, tx *sql.Tx) error {// This code is executed when the migration is rolled back.return nil}diff --git a/db/migrations/20201021093209_add_media_file_indexes.go b/db/migrations/20201021093209_add_media_file_indexes.goindex f3a800949..7d6ad4965 100644--- a/db/migrations/20201021093209_add_media_file_indexes.go+++ b/db/migrations/20201021093209_add_media_file_indexes.go@@ -11,8 +11,8 @@ func init() {goose.AddMigrationContext(Up20201021093209, Down20201021093209)}-func Up20201021093209(_ context.Context, tx *sql.Tx) error {- _, err := tx.Exec(`+func Up20201021093209(ctx context.Context, tx *sql.Tx) error {+ _, err := tx.ExecContext(ctx, `create index if not exists media_file_artiston media_file (artist);create index if not exists media_file_album_artist@@ -23,6 +23,6 @@ create index if not exists media_file_mbz_track_idreturn err}-func Down20201021093209(_ context.Context, tx *sql.Tx) error {+func Down20201021093209(_ context.Context, _ *sql.Tx) error {return nil}diff --git a/db/migrations/20201021135455_add_media_file_artist_index.go b/db/migrations/20201021135455_add_media_file_artist_index.goindex ca04d8a20..e8f22c3a7 100644--- a/db/migrations/20201021135455_add_media_file_artist_index.go+++ b/db/migrations/20201021135455_add_media_file_artist_index.go@@ -11,14 +11,14 @@ func init() {goose.AddMigrationContext(Up20201021135455, Down20201021135455)}-func Up20201021135455(_ context.Context, tx *sql.Tx) error {- _, err := tx.Exec(`+func Up20201021135455(ctx context.Context, tx *sql.Tx) error {+ _, err := tx.ExecContext(ctx, `create index if not exists media_file_artist_idon media_file (artist_id);`)return err}-func Down20201021135455(_ context.Context, tx *sql.Tx) error {+func Down20201021135455(_ context.Context, _ *sql.Tx) error {return nil}diff --git a/db/migrations/20201030162009_add_artist_info_table.go b/db/migrations/20201030162009_add_artist_info_table.goindex f2917ae49..e33e15c23 100644--- a/db/migrations/20201030162009_add_artist_info_table.go+++ b/db/migrations/20201030162009_add_artist_info_table.go@@ -11,8 +11,8 @@ func init() {goose.AddMigrationContext(upAddArtistImageUrl, downAddArtistImageUrl)}-func upAddArtistImageUrl(_ context.Context, tx *sql.Tx) error {- _, err := tx.Exec(`+func upAddArtistImageUrl(ctx context.Context, tx *sql.Tx) error {+ _, err := tx.ExecContext(ctx, `alter table artistadd biography varchar(255) default '' not null;alter table artist@@ -31,6 +31,6 @@ alter table artistreturn err}-func downAddArtistImageUrl(_ context.Context, tx *sql.Tx) error {+func downAddArtistImageUrl(_ context.Context, _ *sql.Tx) error {return nil}diff --git a/db/migrations/20201110205344_add_comments_and_lyrics.go b/db/migrations/20201110205344_add_comments_and_lyrics.goindex 5bb17b8d0..c60917bdd 100644--- a/db/migrations/20201110205344_add_comments_and_lyrics.go+++ b/db/migrations/20201110205344_add_comments_and_lyrics.go@@ -11,8 +11,8 @@ func init() {goose.AddMigrationContext(Up20201110205344, Down20201110205344)}-func Up20201110205344(_ context.Context, tx *sql.Tx) error {- _, err := tx.Exec(`+func Up20201110205344(ctx context.Context, tx *sql.Tx) error {+ _, err := tx.ExecContext(ctx, `alter table media_fileadd comment varchar;alter table media_file@@ -24,10 +24,10 @@ alter table albumif err != nil {return err}- notice(tx, "A full rescan will be performed to import comments and lyrics")- return forceFullRescan(tx)+ notice(ctx, tx, "A full rescan will be performed to import comments and lyrics")+ return forceFullRescan(ctx, tx)}-func Down20201110205344(_ context.Context, tx *sql.Tx) error {+func Down20201110205344(_ context.Context, _ *sql.Tx) error {return nil}diff --git a/db/migrations/20201128100726_add_real-path_option.go b/db/migrations/20201128100726_add_real-path_option.goindex db102dfa9..4b3f62128 100644--- a/db/migrations/20201128100726_add_real-path_option.go+++ b/db/migrations/20201128100726_add_real-path_option.go@@ -11,14 +11,14 @@ func init() {goose.AddMigrationContext(Up20201128100726, Down20201128100726)}-func Up20201128100726(_ context.Context, tx *sql.Tx) error {- _, err := tx.Exec(`+func Up20201128100726(ctx context.Context, tx *sql.Tx) error {+ _, err := tx.ExecContext(ctx, `alter table playeradd report_real_path bool default FALSE not null;`)return err}-func Down20201128100726(_ context.Context, tx *sql.Tx) error {+func Down20201128100726(_ context.Context, _ *sql.Tx) error {return nil}diff --git a/db/migrations/20201213124814_add_all_artist_ids_to_album.go b/db/migrations/20201213124814_add_all_artist_ids_to_album.goindex 170497f5c..81c30d611 100644--- a/db/migrations/20201213124814_add_all_artist_ids_to_album.go+++ b/db/migrations/20201213124814_add_all_artist_ids_to_album.go@@ -13,8 +13,8 @@ func init() {goose.AddMigrationContext(Up20201213124814, Down20201213124814)}-func Up20201213124814(_ context.Context, tx *sql.Tx) error {- _, err := tx.Exec(`+func Up20201213124814(ctx context.Context, tx *sql.Tx) error {+ _, err := tx.ExecContext(ctx, `alter table albumadd all_artist_ids varchar;@@ -25,11 +25,11 @@ create index if not exists album_all_artist_idsreturn err}- return updateAlbums20201213124814(tx)+ return updateAlbums20201213124814(ctx, tx)}-func updateAlbums20201213124814(tx *sql.Tx) error {- rows, err := tx.Query(`+func updateAlbums20201213124814(ctx context.Context, tx *sql.Tx) error {+ rows, err := tx.QueryContext(ctx, `select a.id, a.name, a.artist_id, a.album_artist_id, group_concat(mf.artist_id, ' ')from album a left join media_file mf on a.id = mf.album_id group by a.id`)@@ -59,6 +59,6 @@ select a.id, a.name, a.artist_id, a.album_artist_id, group_concat(mf.artist_id,return rows.Err()}-func Down20201213124814(_ context.Context, tx *sql.Tx) error {+func Down20201213124814(_ context.Context, _ *sql.Tx) error {return nil}diff --git a/db/migrations/20210322132848_add_timestamp_indexes.go b/db/migrations/20210322132848_add_timestamp_indexes.goindex 3341dd3d2..5ed250fea 100644--- a/db/migrations/20210322132848_add_timestamp_indexes.go+++ b/db/migrations/20210322132848_add_timestamp_indexes.go@@ -11,8 +11,8 @@ func init() {goose.AddMigrationContext(upAddTimestampIndexesGo, downAddTimestampIndexesGo)}-func upAddTimestampIndexesGo(_ context.Context, tx *sql.Tx) error {- _, err := tx.Exec(`+func upAddTimestampIndexesGo(ctx context.Context, tx *sql.Tx) error {+ _, err := tx.ExecContext(ctx, `create index if not exists album_updated_aton album (updated_at);create index if not exists album_created_at@@ -29,6 +29,6 @@ create index if not exists media_file_updated_atreturn err}-func downAddTimestampIndexesGo(_ context.Context, tx *sql.Tx) error {+func downAddTimestampIndexesGo(_ context.Context, _ *sql.Tx) error {return nil}diff --git a/db/migrations/20210418232815_fix_album_comments.go b/db/migrations/20210418232815_fix_album_comments.goindex 59067640a..3c7ed86c1 100644--- a/db/migrations/20210418232815_fix_album_comments.go+++ b/db/migrations/20210418232815_fix_album_comments.go@@ -14,10 +14,10 @@ func init() {goose.AddMigrationContext(upFixAlbumComments, downFixAlbumComments)}-func upFixAlbumComments(_ context.Context, tx *sql.Tx) error {+func upFixAlbumComments(ctx context.Context, tx *sql.Tx) error {//nolint:gosec- rows, err := tx.Query(`- SELECT album.id, group_concat(media_file.comment, '` + consts.Zwsp + `') FROM album, media_file WHERE media_file.album_id = album.id GROUP BY album.id;+ rows, err := tx.QueryContext(ctx, `+ SELECT album.id, group_concat(media_file.comment, '`+consts.Zwsp+`') FROM album, media_file WHERE media_file.album_id = album.id GROUP BY album.id;`)if err != nil {return err@@ -49,7 +49,7 @@ func upFixAlbumComments(_ context.Context, tx *sql.Tx) error {return rows.Err()}-func downFixAlbumComments(_ context.Context, tx *sql.Tx) error {+func downFixAlbumComments(_ context.Context, _ *sql.Tx) error {return nil}diff --git a/db/migrations/20210430212322_add_bpm_metadata.go b/db/migrations/20210430212322_add_bpm_metadata.goindex 721c9e179..00a0f1447 100644--- a/db/migrations/20210430212322_add_bpm_metadata.go+++ b/db/migrations/20210430212322_add_bpm_metadata.go@@ -11,8 +11,8 @@ func init() {goose.AddMigrationContext(upAddBpmMetadata, downAddBpmMetadata)}-func upAddBpmMetadata(_ context.Context, tx *sql.Tx) error {- _, err := tx.Exec(`+func upAddBpmMetadata(ctx context.Context, tx *sql.Tx) error {+ _, err := tx.ExecContext(ctx, `alter table media_fileadd bpm integer;@@ -22,10 +22,10 @@ create index if not exists media_file_bpmif err != nil {return err}- notice(tx, "A full rescan needs to be performed to import more tags")- return forceFullRescan(tx)+ notice(ctx, tx, "A full rescan needs to be performed to import more tags")+ return forceFullRescan(ctx, tx)}-func downAddBpmMetadata(_ context.Context, tx *sql.Tx) error {+func downAddBpmMetadata(_ context.Context, _ *sql.Tx) error {return nil}diff --git a/db/migrations/20210530121921_create_shares_table.go b/db/migrations/20210530121921_create_shares_table.goindex e9208bd69..d9e902a43 100644--- a/db/migrations/20210530121921_create_shares_table.go+++ b/db/migrations/20210530121921_create_shares_table.go@@ -11,8 +11,8 @@ func init() {goose.AddMigrationContext(upCreateSharesTable, downCreateSharesTable)}-func upCreateSharesTable(_ context.Context, tx *sql.Tx) error {- _, err := tx.Exec(`+func upCreateSharesTable(ctx context.Context, tx *sql.Tx) error {+ _, err := tx.ExecContext(ctx, `create table share(id varchar(255) not null primary key,@@ -30,6 +30,6 @@ create table sharereturn err}-func downCreateSharesTable(_ context.Context, tx *sql.Tx) error {+func downCreateSharesTable(_ context.Context, _ *sql.Tx) error {return nil}diff --git a/db/migrations/20210601231734_update_share_fieldnames.go b/db/migrations/20210601231734_update_share_fieldnames.goindex 965c0186e..5a459a34c 100644--- a/db/migrations/20210601231734_update_share_fieldnames.go+++ b/db/migrations/20210601231734_update_share_fieldnames.go@@ -11,8 +11,8 @@ func init() {goose.AddMigrationContext(upUpdateShareFieldNames, downUpdateShareFieldNames)}-func upUpdateShareFieldNames(_ context.Context, tx *sql.Tx) error {- _, err := tx.Exec(`+func upUpdateShareFieldNames(ctx context.Context, tx *sql.Tx) error {+ _, err := tx.ExecContext(ctx, `alter table share rename column expires to expires_at;alter table share rename column created to created_at;alter table share rename column last_visited to last_visited_at;@@ -21,6 +21,6 @@ alter table share rename column last_visited to last_visited_at;return err}-func downUpdateShareFieldNames(_ context.Context, tx *sql.Tx) error {+func downUpdateShareFieldNames(_ context.Context, _ *sql.Tx) error {return nil}diff --git a/db/migrations/20210616150710_encrypt_all_passwords.go b/db/migrations/20210616150710_encrypt_all_passwords.goindex f67e3fb0a..dc8a9abd4 100644--- a/db/migrations/20210616150710_encrypt_all_passwords.go+++ b/db/migrations/20210616150710_encrypt_all_passwords.go@@ -16,7 +16,7 @@ func init() {}func upEncodeAllPasswords(ctx context.Context, tx *sql.Tx) error {- rows, err := tx.Query(`SELECT id, user_name, password from user;`)+ rows, err := tx.QueryContext(ctx, `SELECT id, user_name, password from user;`)if err != nil {return err}@@ -51,6 +51,6 @@ func upEncodeAllPasswords(ctx context.Context, tx *sql.Tx) error {return rows.Err()}-func downEncodeAllPasswords(_ context.Context, tx *sql.Tx) error {+func downEncodeAllPasswords(_ context.Context, _ *sql.Tx) error {return nil}diff --git a/db/migrations/20210619231716_drop_player_name_unique_constraint.go b/db/migrations/20210619231716_drop_player_name_unique_constraint.goindex 200332156..734ffc340 100644--- a/db/migrations/20210619231716_drop_player_name_unique_constraint.go+++ b/db/migrations/20210619231716_drop_player_name_unique_constraint.go@@ -11,8 +11,8 @@ func init() {goose.AddMigrationContext(upDropPlayerNameUniqueConstraint, downDropPlayerNameUniqueConstraint)}-func upDropPlayerNameUniqueConstraint(_ context.Context, tx *sql.Tx) error {- _, err := tx.Exec(`+func upDropPlayerNameUniqueConstraint(ctx context.Context, tx *sql.Tx) error {+ _, err := tx.ExecContext(ctx, `create table player_dg_tmp(id varchar(255) not null@@ -43,6 +43,6 @@ create index if not exists player_namereturn err}-func downDropPlayerNameUniqueConstraint(_ context.Context, tx *sql.Tx) error {+func downDropPlayerNameUniqueConstraint(_ context.Context, _ *sql.Tx) error {return nil}diff --git a/db/migrations/20210623155401_add_user_prefs_player_scrobbler_enabled.go b/db/migrations/20210623155401_add_user_prefs_player_scrobbler_enabled.goindex 5257dfab3..aa5e7a8f0 100644--- a/db/migrations/20210623155401_add_user_prefs_player_scrobbler_enabled.go+++ b/db/migrations/20210623155401_add_user_prefs_player_scrobbler_enabled.go@@ -11,16 +11,16 @@ func init() {goose.AddMigrationContext(upAddUserPrefsPlayerScrobblerEnabled, downAddUserPrefsPlayerScrobblerEnabled)}-func upAddUserPrefsPlayerScrobblerEnabled(_ context.Context, tx *sql.Tx) error {- err := upAddUserPrefs(tx)+func upAddUserPrefsPlayerScrobblerEnabled(ctx context.Context, tx *sql.Tx) error {+ err := upAddUserPrefs(ctx, tx)if err != nil {return err}- return upPlayerScrobblerEnabled(tx)+ return upPlayerScrobblerEnabled(ctx, tx)}-func upAddUserPrefs(tx *sql.Tx) error {- _, err := tx.Exec(`+func upAddUserPrefs(ctx context.Context, tx *sql.Tx) error {+ _, err := tx.ExecContext(ctx, `create table user_props(user_id varchar not null,@@ -33,13 +33,13 @@ create table user_propsreturn err}-func upPlayerScrobblerEnabled(tx *sql.Tx) error {- _, err := tx.Exec(`+func upPlayerScrobblerEnabled(ctx context.Context, tx *sql.Tx) error {+ _, err := tx.ExecContext(ctx, `alter table player add scrobble_enabled bool default true;`)return err}-func downAddUserPrefsPlayerScrobblerEnabled(_ context.Context, tx *sql.Tx) error {+func downAddUserPrefsPlayerScrobblerEnabled(_ context.Context, _ *sql.Tx) error {return nil}diff --git a/db/migrations/20210625223901_add_referential_integrity_to_user_props.go b/db/migrations/20210625223901_add_referential_integrity_to_user_props.goindex 033392d93..b2f93b4e3 100644--- a/db/migrations/20210625223901_add_referential_integrity_to_user_props.go+++ b/db/migrations/20210625223901_add_referential_integrity_to_user_props.go@@ -11,8 +11,8 @@ func init() {goose.AddMigrationContext(upAddReferentialIntegrityToUserProps, downAddReferentialIntegrityToUserProps)}-func upAddReferentialIntegrityToUserProps(_ context.Context, tx *sql.Tx) error {- _, err := tx.Exec(`+func upAddReferentialIntegrityToUserProps(ctx context.Context, tx *sql.Tx) error {+ _, err := tx.ExecContext(ctx, `create table user_props_dg_tmp(user_id varchar not null@@ -34,6 +34,6 @@ alter table user_props_dg_tmp rename to user_props;return err}-func downAddReferentialIntegrityToUserProps(_ context.Context, tx *sql.Tx) error {+func downAddReferentialIntegrityToUserProps(_ context.Context, _ *sql.Tx) error {return nil}diff --git a/db/migrations/20210626213026_add_scrobble_buffer.go b/db/migrations/20210626213026_add_scrobble_buffer.goindex 1c4d0de2a..75d9d681c 100644--- a/db/migrations/20210626213026_add_scrobble_buffer.go+++ b/db/migrations/20210626213026_add_scrobble_buffer.go@@ -11,8 +11,8 @@ func init() {goose.AddMigrationContext(upAddScrobbleBuffer, downAddScrobbleBuffer)}-func upAddScrobbleBuffer(_ context.Context, tx *sql.Tx) error {- _, err := tx.Exec(`+func upAddScrobbleBuffer(ctx context.Context, tx *sql.Tx) error {+ _, err := tx.ExecContext(ctx, `create table if not exists scrobble_buffer(user_id varchar not null@@ -34,6 +34,6 @@ create table if not exists scrobble_bufferreturn err}-func downAddScrobbleBuffer(_ context.Context, tx *sql.Tx) error {+func downAddScrobbleBuffer(_ context.Context, _ *sql.Tx) error {return nil}diff --git a/db/migrations/20210715151153_add_genre_tables.go b/db/migrations/20210715151153_add_genre_tables.goindex ab2c54239..143f9c72b 100644--- a/db/migrations/20210715151153_add_genre_tables.go+++ b/db/migrations/20210715151153_add_genre_tables.go@@ -11,9 +11,9 @@ func init() {goose.AddMigrationContext(upAddGenreTables, downAddGenreTables)}-func upAddGenreTables(_ context.Context, tx *sql.Tx) error {- notice(tx, "A full rescan will be performed to import multiple genres!")- _, err := tx.Exec(`+func upAddGenreTables(ctx context.Context, tx *sql.Tx) error {+ notice(ctx, tx, "A full rescan will be performed to import multiple genres!")+ _, err := tx.ExecContext(ctx, `create table if not exists genre(id varchar not null primary key,@@ -61,9 +61,9 @@ create table if not exists artist_genresif err != nil {return err}- return forceFullRescan(tx)+ return forceFullRescan(ctx, tx)}-func downAddGenreTables(_ context.Context, tx *sql.Tx) error {+func downAddGenreTables(_ context.Context, _ *sql.Tx) error {return nil}diff --git a/db/migrations/20210821212604_add_mediafile_channels.go b/db/migrations/20210821212604_add_mediafile_channels.goindex 9a0988b17..ee18be01b 100644--- a/db/migrations/20210821212604_add_mediafile_channels.go+++ b/db/migrations/20210821212604_add_mediafile_channels.go@@ -11,8 +11,8 @@ func init() {goose.AddMigrationContext(upAddMediafileChannels, downAddMediafileChannels)}-func upAddMediafileChannels(_ context.Context, tx *sql.Tx) error {- _, err := tx.Exec(`+func upAddMediafileChannels(ctx context.Context, tx *sql.Tx) error {+ _, err := tx.ExecContext(ctx, `alter table media_fileadd channels integer;@@ -22,10 +22,10 @@ create index if not exists media_file_channelsif err != nil {return err}- notice(tx, "A full rescan needs to be performed to import more tags")- return forceFullRescan(tx)+ notice(ctx, tx, "A full rescan needs to be performed to import more tags")+ return forceFullRescan(ctx, tx)}-func downAddMediafileChannels(_ context.Context, tx *sql.Tx) error {+func downAddMediafileChannels(_ context.Context, _ *sql.Tx) error {return nil}diff --git a/db/migrations/20211008205505_add_smart_playlist.go b/db/migrations/20211008205505_add_smart_playlist.goindex c8ed67c47..0d2d1ad4e 100644--- a/db/migrations/20211008205505_add_smart_playlist.go+++ b/db/migrations/20211008205505_add_smart_playlist.go@@ -11,8 +11,8 @@ func init() {goose.AddMigrationContext(upAddSmartPlaylist, downAddSmartPlaylist)}-func upAddSmartPlaylist(_ context.Context, tx *sql.Tx) error {- _, err := tx.Exec(`+func upAddSmartPlaylist(ctx context.Context, tx *sql.Tx) error {+ _, err := tx.ExecContext(ctx, `alter table playlistadd column rules varchar null;alter table playlist@@ -33,6 +33,6 @@ create unique index playlist_fields_idxreturn err}-func downAddSmartPlaylist(_ context.Context, tx *sql.Tx) error {+func downAddSmartPlaylist(_ context.Context, _ *sql.Tx) error {return nil}diff --git a/db/migrations/20211023184825_add_order_title_to_media_file.go b/db/migrations/20211023184825_add_order_title_to_media_file.goindex ee6fc67d1..4a2ae4047 100644--- a/db/migrations/20211023184825_add_order_title_to_media_file.go+++ b/db/migrations/20211023184825_add_order_title_to_media_file.go@@ -14,8 +14,8 @@ func init() {goose.AddMigrationContext(upAddOrderTitleToMediaFile, downAddOrderTitleToMediaFile)}-func upAddOrderTitleToMediaFile(_ context.Context, tx *sql.Tx) error {- _, err := tx.Exec(`+func upAddOrderTitleToMediaFile(ctx context.Context, tx *sql.Tx) error {+ _, err := tx.ExecContext(ctx, `alter table main.media_fileadd order_title varchar null collate NOCASE;create index if not exists media_file_order_title@@ -25,12 +25,12 @@ create index if not exists media_file_order_titlereturn err}- return upAddOrderTitleToMediaFile_populateOrderTitle(tx)+ return upAddOrderTitleToMediaFile_populateOrderTitle(ctx, tx)}//goland:noinspection GoSnakeCaseUsage-func upAddOrderTitleToMediaFile_populateOrderTitle(tx *sql.Tx) error {- rows, err := tx.Query(`select id, title from media_file`)+func upAddOrderTitleToMediaFile_populateOrderTitle(ctx context.Context, tx *sql.Tx) error {+ rows, err := tx.QueryContext(ctx, `select id, title from media_file`)if err != nil {return err}@@ -57,6 +57,6 @@ func upAddOrderTitleToMediaFile_populateOrderTitle(tx *sql.Tx) error {return rows.Err()}-func downAddOrderTitleToMediaFile(_ context.Context, tx *sql.Tx) error {+func downAddOrderTitleToMediaFile(_ context.Context, _ *sql.Tx) error {return nil}diff --git a/db/migrations/20211026191915_unescape_lyrics_and_comments.go b/db/migrations/20211026191915_unescape_lyrics_and_comments.goindex d4ba5e194..a7969ffed 100644--- a/db/migrations/20211026191915_unescape_lyrics_and_comments.go+++ b/db/migrations/20211026191915_unescape_lyrics_and_comments.go@@ -13,8 +13,8 @@ func init() {goose.AddMigrationContext(upUnescapeLyricsAndComments, downUnescapeLyricsAndComments)}-func upUnescapeLyricsAndComments(_ context.Context, tx *sql.Tx) error {- rows, err := tx.Query(`select id, comment, lyrics, title from media_file`)+func upUnescapeLyricsAndComments(ctx context.Context, tx *sql.Tx) error {+ rows, err := tx.QueryContext(ctx, `select id, comment, lyrics, title from media_file`)if err != nil {return err}@@ -43,6 +43,6 @@ func upUnescapeLyricsAndComments(_ context.Context, tx *sql.Tx) error {return rows.Err()}-func downUnescapeLyricsAndComments(_ context.Context, tx *sql.Tx) error {+func downUnescapeLyricsAndComments(_ context.Context, _ *sql.Tx) error {return nil}diff --git a/db/migrations/20211029213200_add_userid_to_playlist.go b/db/migrations/20211029213200_add_userid_to_playlist.goindex e262fc205..909ea1c54 100644--- a/db/migrations/20211029213200_add_userid_to_playlist.go+++ b/db/migrations/20211029213200_add_userid_to_playlist.go@@ -11,8 +11,8 @@ func init() {goose.AddMigrationContext(upAddUseridToPlaylist, downAddUseridToPlaylist)}-func upAddUseridToPlaylist(_ context.Context, tx *sql.Tx) error {- _, err := tx.Exec(`+func upAddUseridToPlaylist(ctx context.Context, tx *sql.Tx) error {+ _, err := tx.ExecContext(ctx, `create table playlist_dg_tmp(id varchar(255) not null@@ -56,6 +56,6 @@ create index playlist_updated_atreturn err}-func downAddUseridToPlaylist(_ context.Context, tx *sql.Tx) error {+func downAddUseridToPlaylist(_ context.Context, _ *sql.Tx) error {return nil}diff --git a/db/migrations/20211102215414_add_alphabetical_by_artist_index.go b/db/migrations/20211102215414_add_alphabetical_by_artist_index.goindex 4ab4305d0..f786b69e7 100644--- a/db/migrations/20211102215414_add_alphabetical_by_artist_index.go+++ b/db/migrations/20211102215414_add_alphabetical_by_artist_index.go@@ -11,14 +11,14 @@ func init() {goose.AddMigrationContext(upAddAlphabeticalByArtistIndex, downAddAlphabeticalByArtistIndex)}-func upAddAlphabeticalByArtistIndex(_ context.Context, tx *sql.Tx) error {- _, err := tx.Exec(`+func upAddAlphabeticalByArtistIndex(ctx context.Context, tx *sql.Tx) error {+ _, err := tx.ExecContext(ctx, `create index album_alphabetical_by_artistON album(compilation, order_album_artist_name, order_album_name)`)return err}-func downAddAlphabeticalByArtistIndex(_ context.Context, tx *sql.Tx) error {+func downAddAlphabeticalByArtistIndex(_ context.Context, _ *sql.Tx) error {return nil}diff --git a/db/migrations/20211105162746_remove_invalid_artist_ids.go b/db/migrations/20211105162746_remove_invalid_artist_ids.goindex 5e078c820..8c9887dd1 100644--- a/db/migrations/20211105162746_remove_invalid_artist_ids.go+++ b/db/migrations/20211105162746_remove_invalid_artist_ids.go@@ -11,13 +11,13 @@ func init() {goose.AddMigrationContext(upRemoveInvalidArtistIds, downRemoveInvalidArtistIds)}-func upRemoveInvalidArtistIds(_ context.Context, tx *sql.Tx) error {- _, err := tx.Exec(`+func upRemoveInvalidArtistIds(ctx context.Context, tx *sql.Tx) error {+ _, err := tx.ExecContext(ctx, `update media_file set artist_id = '' where not exists(select 1 from artist where id = artist_id)`)return err}-func downRemoveInvalidArtistIds(_ context.Context, tx *sql.Tx) error {+func downRemoveInvalidArtistIds(_ context.Context, _ *sql.Tx) error {return nil}diff --git a/db/migrations/20220724231849_add_musicbrainz_release_track_id.go b/db/migrations/20220724231849_add_musicbrainz_release_track_id.goindex 481762117..42e13a1e5 100644--- a/db/migrations/20220724231849_add_musicbrainz_release_track_id.go+++ b/db/migrations/20220724231849_add_musicbrainz_release_track_id.go@@ -11,19 +11,19 @@ func init() {goose.AddMigrationContext(upAddMusicbrainzReleaseTrackId, downAddMusicbrainzReleaseTrackId)}-func upAddMusicbrainzReleaseTrackId(_ context.Context, tx *sql.Tx) error {- _, err := tx.Exec(`+func upAddMusicbrainzReleaseTrackId(ctx context.Context, tx *sql.Tx) error {+ _, err := tx.ExecContext(ctx, `alter table media_fileadd mbz_release_track_id varchar(255);`)if err != nil {return err}- notice(tx, "A full rescan needs to be performed to import more tags")- return forceFullRescan(tx)+ notice(ctx, tx, "A full rescan needs to be performed to import more tags")+ return forceFullRescan(ctx, tx)}-func downAddMusicbrainzReleaseTrackId(_ context.Context, tx *sql.Tx) error {+func downAddMusicbrainzReleaseTrackId(ctx context.Context, tx *sql.Tx) error {// This code is executed when the migration is rolled back.return nil}diff --git a/db/migrations/20221219112733_add_album_image_paths.go b/db/migrations/20221219112733_add_album_image_paths.goindex ee9c77c8a..f8ebd40e9 100644--- a/db/migrations/20221219112733_add_album_image_paths.go+++ b/db/migrations/20221219112733_add_album_image_paths.go@@ -11,17 +11,17 @@ func init() {goose.AddMigrationContext(upAddAlbumImagePaths, downAddAlbumImagePaths)}-func upAddAlbumImagePaths(_ context.Context, tx *sql.Tx) error {- _, err := tx.Exec(`+func upAddAlbumImagePaths(ctx context.Context, tx *sql.Tx) error {+ _, err := tx.ExecContext(ctx, `alter table main.album add image_files varchar;`)if err != nil {return err}- notice(tx, "A full rescan needs to be performed to import all album images")- return forceFullRescan(tx)+ notice(ctx, tx, "A full rescan needs to be performed to import all album images")+ return forceFullRescan(ctx, tx)}-func downAddAlbumImagePaths(_ context.Context, tx *sql.Tx) error {+func downAddAlbumImagePaths(_ context.Context, _ *sql.Tx) error {return nil}diff --git a/db/migrations/20221219140528_remove_cover_art_id.go b/db/migrations/20221219140528_remove_cover_art_id.goindex a1eaa89f9..30f86297a 100644--- a/db/migrations/20221219140528_remove_cover_art_id.go+++ b/db/migrations/20221219140528_remove_cover_art_id.go@@ -11,18 +11,18 @@ func init() {goose.AddMigrationContext(upRemoveCoverArtId, downRemoveCoverArtId)}-func upRemoveCoverArtId(_ context.Context, tx *sql.Tx) error {- _, err := tx.Exec(`+func upRemoveCoverArtId(ctx context.Context, tx *sql.Tx) error {+ _, err := tx.ExecContext(ctx, `alter table album drop column cover_art_id;alter table album rename column cover_art_path to embed_art_path`)if err != nil {return err}- notice(tx, "A full rescan needs to be performed to import all album images")- return forceFullRescan(tx)+ notice(ctx, tx, "A full rescan needs to be performed to import all album images")+ return forceFullRescan(ctx, tx)}-func downRemoveCoverArtId(_ context.Context, tx *sql.Tx) error {+func downRemoveCoverArtId(_ context.Context, _ *sql.Tx) error {return nil}diff --git a/db/migrations/20230112111457_add_album_paths.go b/db/migrations/20230112111457_add_album_paths.goindex 2dfb9a747..2819522a1 100644--- a/db/migrations/20230112111457_add_album_paths.go+++ b/db/migrations/20230112111457_add_album_paths.go@@ -16,15 +16,15 @@ func init() {goose.AddMigrationContext(upAddAlbumPaths, downAddAlbumPaths)}-func upAddAlbumPaths(_ context.Context, tx *sql.Tx) error {- _, err := tx.Exec(`alter table album add paths varchar;`)+func upAddAlbumPaths(ctx context.Context, tx *sql.Tx) error {+ _, err := tx.ExecContext(ctx, `alter table album add paths varchar;`)if err != nil {return err}//nolint:gosec- rows, err := tx.Query(`- select album_id, group_concat(path, '` + consts.Zwsp + `') from media_file group by album_id+ rows, err := tx.QueryContext(ctx, `+ select album_id, group_concat(path, '`+consts.Zwsp+`') from media_file group by album_id`)if err != nil {return err@@ -63,6 +63,6 @@ func upAddAlbumPathsDirs(filePaths string) string {return strings.Join(dirs, string(filepath.ListSeparator))}-func downAddAlbumPaths(_ context.Context, tx *sql.Tx) error {+func downAddAlbumPaths(_ context.Context, _ *sql.Tx) error {return nil}diff --git a/db/migrations/20230114121537_touch_playlists.go b/db/migrations/20230114121537_touch_playlists.goindex 0f10e275c..71959b0a8 100644--- a/db/migrations/20230114121537_touch_playlists.go+++ b/db/migrations/20230114121537_touch_playlists.go@@ -11,11 +11,11 @@ func init() {goose.AddMigrationContext(upTouchPlaylists, downTouchPlaylists)}-func upTouchPlaylists(_ context.Context, tx *sql.Tx) error {- _, err := tx.Exec(`update playlist set updated_at = datetime('now');`)+func upTouchPlaylists(ctx context.Context, tx *sql.Tx) error {+ _, err := tx.ExecContext(ctx, `update playlist set updated_at = datetime('now');`)return err}-func downTouchPlaylists(_ context.Context, tx *sql.Tx) error {+func downTouchPlaylists(_ context.Context, _ *sql.Tx) error {return nil}diff --git a/db/migrations/20230115103212_create_internet_radio.go b/db/migrations/20230115103212_create_internet_radio.goindex 5c014dac2..3e0da348f 100644--- a/db/migrations/20230115103212_create_internet_radio.go+++ b/db/migrations/20230115103212_create_internet_radio.go@@ -11,8 +11,8 @@ func init() {goose.AddMigrationContext(upCreateInternetRadio, downCreateInternetRadio)}-func upCreateInternetRadio(_ context.Context, tx *sql.Tx) error {- _, err := tx.Exec(`+func upCreateInternetRadio(ctx context.Context, tx *sql.Tx) error {+ _, err := tx.ExecContext(ctx, `create table if not exists radio(id varchar(255) not null primary key,@@ -26,6 +26,6 @@ create table if not exists radioreturn err}-func downCreateInternetRadio(_ context.Context, tx *sql.Tx) error {+func downCreateInternetRadio(_ context.Context, _ *sql.Tx) error {return nil}diff --git a/db/migrations/20230117155559_add_replaygain_metadata.go b/db/migrations/20230117155559_add_replaygain_metadata.goindex d6be3b313..3aad70925 100644--- a/db/migrations/20230117155559_add_replaygain_metadata.go+++ b/db/migrations/20230117155559_add_replaygain_metadata.go@@ -11,8 +11,8 @@ func init() {goose.AddMigrationContext(upAddReplaygainMetadata, downAddReplaygainMetadata)}-func upAddReplaygainMetadata(_ context.Context, tx *sql.Tx) error {- _, err := tx.Exec(`+func upAddReplaygainMetadata(ctx context.Context, tx *sql.Tx) error {+ _, err := tx.ExecContext(ctx, `alter table media_file addrg_album_gain real;alter table media_file add@@ -26,10 +26,10 @@ alter table media_file addreturn err}- notice(tx, "A full rescan needs to be performed to import more tags")- return forceFullRescan(tx)+ notice(ctx, tx, "A full rescan needs to be performed to import more tags")+ return forceFullRescan(ctx, tx)}-func downAddReplaygainMetadata(_ context.Context, tx *sql.Tx) error {+func downAddReplaygainMetadata(_ context.Context, _ *sql.Tx) error {return nil}diff --git a/db/migrations/20230117180400_add_album_info.go b/db/migrations/20230117180400_add_album_info.goindex 5d6dd8230..750d3838f 100644--- a/db/migrations/20230117180400_add_album_info.go+++ b/db/migrations/20230117180400_add_album_info.go@@ -11,8 +11,8 @@ func init() {goose.AddMigrationContext(upAddAlbumInfo, downAddAlbumInfo)}-func upAddAlbumInfo(_ context.Context, tx *sql.Tx) error {- _, err := tx.Exec(`+func upAddAlbumInfo(ctx context.Context, tx *sql.Tx) error {+ _, err := tx.ExecContext(ctx, `alter table albumadd description varchar(255) default '' not null;alter table album@@ -29,6 +29,6 @@ alter table albumreturn err}-func downAddAlbumInfo(_ context.Context, tx *sql.Tx) error {+func downAddAlbumInfo(_ context.Context, _ *sql.Tx) error {return nil}diff --git a/db/migrations/20230119152657_recreate_share_table.go b/db/migrations/20230119152657_recreate_share_table.goindex e1ae816c0..10eff31ca 100644--- a/db/migrations/20230119152657_recreate_share_table.go+++ b/db/migrations/20230119152657_recreate_share_table.go@@ -11,8 +11,8 @@ func init() {goose.AddMigrationContext(upAddMissingShareInfo, downAddMissingShareInfo)}-func upAddMissingShareInfo(_ context.Context, tx *sql.Tx) error {- _, err := tx.Exec(`+func upAddMissingShareInfo(ctx context.Context, tx *sql.Tx) error {+ _, err := tx.ExecContext(ctx, `drop table if exists share;create table share(@@ -37,6 +37,6 @@ create table sharereturn err}-func downAddMissingShareInfo(_ context.Context, tx *sql.Tx) error {+func downAddMissingShareInfo(_ context.Context, _ *sql.Tx) error {return nil}diff --git a/db/migrations/20230202143713_change_path_list_separator.go b/db/migrations/20230202143713_change_path_list_separator.goindex 78b030ae4..fb5f2be1a 100644--- a/db/migrations/20230202143713_change_path_list_separator.go+++ b/db/migrations/20230202143713_change_path_list_separator.go@@ -16,10 +16,10 @@ func init() {goose.AddMigrationContext(upChangePathListSeparator, downChangePathListSeparator)}-func upChangePathListSeparator(_ context.Context, tx *sql.Tx) error {+func upChangePathListSeparator(ctx context.Context, tx *sql.Tx) error {//nolint:gosec- rows, err := tx.Query(`- select album_id, group_concat(path, '` + consts.Zwsp + `') from media_file group by album_id+ rows, err := tx.QueryContext(ctx, `+ select album_id, group_concat(path, '`+consts.Zwsp+`') from media_file group by album_id`)if err != nil {return err@@ -58,6 +58,6 @@ func upChangePathListSeparatorDirs(filePaths string) string {return strings.Join(dirs, consts.Zwsp)}-func downChangePathListSeparator(_ context.Context, tx *sql.Tx) error {+func downChangePathListSeparator(_ context.Context, _ *sql.Tx) error {return nil}diff --git a/db/migrations/20230209181414_change_image_files_list_separator.go b/db/migrations/20230209181414_change_image_files_list_separator.goindex 7f4d4cb0e..e5dc4ab43 100644--- a/db/migrations/20230209181414_change_image_files_list_separator.go+++ b/db/migrations/20230209181414_change_image_files_list_separator.go@@ -16,8 +16,8 @@ func init() {goose.AddMigrationContext(upChangeImageFilesListSeparator, downChangeImageFilesListSeparator)}-func upChangeImageFilesListSeparator(_ context.Context, tx *sql.Tx) error {- rows, err := tx.Query(`select id, image_files from album`)+func upChangeImageFilesListSeparator(ctx context.Context, tx *sql.Tx) error {+ rows, err := tx.QueryContext(ctx, `select id, image_files from album`)if err != nil {return err}@@ -54,7 +54,7 @@ func upChangeImageFilesListSeparatorDirs(filePaths string) string {return strings.Join(allPaths, consts.Zwsp)}-func downChangeImageFilesListSeparator(_ context.Context, tx *sql.Tx) error {+func downChangeImageFilesListSeparator(ctx context.Context, tx *sql.Tx) error {// This code is executed when the migration is rolled back.return nil}diff --git a/db/migrations/20230310222612_add_download_to_share.go b/db/migrations/20230310222612_add_download_to_share.goindex ed2879ec3..3ee24cc77 100644--- a/db/migrations/20230310222612_add_download_to_share.go+++ b/db/migrations/20230310222612_add_download_to_share.go@@ -11,14 +11,14 @@ func init() {goose.AddMigrationContext(upAddDownloadToShare, downAddDownloadToShare)}-func upAddDownloadToShare(_ context.Context, tx *sql.Tx) error {- _, err := tx.Exec(`+func upAddDownloadToShare(ctx context.Context, tx *sql.Tx) error {+ _, err := tx.ExecContext(ctx, `alter table shareadd downloadable bool not null default false;`)return err}-func downAddDownloadToShare(_ context.Context, tx *sql.Tx) error {+func downAddDownloadToShare(_ context.Context, _ *sql.Tx) error {return nil}diff --git a/db/migrations/20230515184510_add_release_date.go b/db/migrations/20230515184510_add_release_date.goindex 1141a1e74..f22bdfae8 100644--- a/db/migrations/20230515184510_add_release_date.go+++ b/db/migrations/20230515184510_add_release_date.go@@ -11,8 +11,8 @@ func init() {goose.AddMigrationContext(upAddRelRecYear, downAddRelRecYear)}-func upAddRelRecYear(_ context.Context, tx *sql.Tx) error {- _, err := tx.Exec(`+func upAddRelRecYear(ctx context.Context, tx *sql.Tx) error {+ _, err := tx.ExecContext(ctx, `alter table media_fileadd date varchar(255) default '' not null;alter table media_file@@ -41,10 +41,10 @@ alter table albumreturn err}- notice(tx, "A full rescan needs to be performed to import more tags")- return forceFullRescan(tx)+ notice(ctx, tx, "A full rescan needs to be performed to import more tags")+ return forceFullRescan(ctx, tx)}-func downAddRelRecYear(_ context.Context, tx *sql.Tx) error {+func downAddRelRecYear(_ context.Context, _ *sql.Tx) error {return nil}diff --git a/db/migrations/20230616214944_rename_musicbrainz_recording_id.go b/db/migrations/20230616214944_rename_musicbrainz_recording_id.goindex 170fc264c..562a59bb5 100644--- a/db/migrations/20230616214944_rename_musicbrainz_recording_id.go+++ b/db/migrations/20230616214944_rename_musicbrainz_recording_id.go@@ -11,16 +11,16 @@ func init() {goose.AddMigrationContext(upRenameMusicbrainzRecordingId, downRenameMusicbrainzRecordingId)}-func upRenameMusicbrainzRecordingId(_ context.Context, tx *sql.Tx) error {- _, err := tx.Exec(`+func upRenameMusicbrainzRecordingId(ctx context.Context, tx *sql.Tx) error {+ _, err := tx.ExecContext(ctx, `alter table media_filerename column mbz_track_id to mbz_recording_id;`)return err}-func downRenameMusicbrainzRecordingId(_ context.Context, tx *sql.Tx) error {- _, err := tx.Exec(`+func downRenameMusicbrainzRecordingId(ctx context.Context, tx *sql.Tx) error {+ _, err := tx.ExecContext(ctx, `alter table media_filerename column mbz_recording_id to mbz_track_id;`)diff --git a/db/migrations/20231209211223_alter_lyric_column.go b/db/migrations/20231209211223_alter_lyric_column.goindex ac73fc98f..891cb9f5b 100644--- a/db/migrations/20231209211223_alter_lyric_column.go+++ b/db/migrations/20231209211223_alter_lyric_column.go@@ -29,7 +29,7 @@ func upAlterLyricColumn(ctx context.Context, tx *sql.Tx) error {return err}- rows, err := tx.Query(`select id, lyrics_old FROM media_file WHERE lyrics_old <> '';`)+ rows, err := tx.QueryContext(ctx, `select id, lyrics_old FROM media_file WHERE lyrics_old <> '';`)if err != nil {return err}@@ -72,7 +72,7 @@ func upAlterLyricColumn(ctx context.Context, tx *sql.Tx) error {return err}- notice(tx, "A full rescan should be performed to pick up additional lyrics (existing lyrics have been preserved)")+ notice(ctx, tx, "A full rescan should be performed to pick up additional lyrics (existing lyrics have been preserved)")return nil}diff --git a/db/migrations/20240122223340_add_default_values_to_null_columns.go.go b/db/migrations/20240122223340_add_default_values_to_null_columns.go.goindex a65b0aefd..518d125e4 100644--- a/db/migrations/20240122223340_add_default_values_to_null_columns.go.go+++ b/db/migrations/20240122223340_add_default_values_to_null_columns.go.go@@ -558,6 +558,6 @@ create index media_file_mbz_track_idreturn err}-func Down20240122223340(context.Context, *sql.Tx) error {+func Down20240122223340(_ context.Context, _ *sql.Tx) error {return nil}diff --git a/db/migrations/20240511210036_add_sample_rate.go b/db/migrations/20240511210036_add_sample_rate.goindex 619cdcffd..76b809c36 100644--- a/db/migrations/20240511210036_add_sample_rate.go+++ b/db/migrations/20240511210036_add_sample_rate.go@@ -19,7 +19,7 @@ alter table media_filecreate index if not exists media_file_sample_rateon media_file (sample_rate);`)- notice(tx, "A full rescan should be performed to pick up additional tags")+ notice(ctx, tx, "A full rescan should be performed to pick up additional tags")return err}diff --git a/db/migrations/20240629152843_remove_annotation_id.go b/db/migrations/20240629152843_remove_annotation_id.goindex b450b26d4..972932e10 100644--- a/db/migrations/20240629152843_remove_annotation_id.go+++ b/db/migrations/20240629152843_remove_annotation_id.go@@ -61,6 +61,6 @@ create index annotation_starred_atreturn err}-func downRemoveAnnotationId(ctx context.Context, tx *sql.Tx) error {+func downRemoveAnnotationId(_ context.Context, _ *sql.Tx) error {return nil}diff --git a/db/migrations/20241026183640_support_new_scanner.go b/db/migrations/20241026183640_support_new_scanner.goindex fcbef7e4e..f5899f08f 100644--- a/db/migrations/20241026183640_support_new_scanner.go+++ b/db/migrations/20241026183640_support_new_scanner.go@@ -97,8 +97,8 @@ insert into property (id, value) values ('PIDTrack', 'track_legacy') on conflictinsert into property (id, value) values ('PIDAlbum', 'album_legacy') on conflict do nothing;`),func() error {- notice(tx, "A full scan will be triggered to populate the new tables. This may take a while.")- return forceFullRescan(tx)+ notice(ctx, tx, "A full scan will be triggered to populate the new tables. This may take a while.")+ return forceFullRescan(ctx, tx)},)}@@ -314,6 +314,6 @@ alter table artist}}-func downSupportNewScanner(context.Context, *sql.Tx) error {+func downSupportNewScanner(_ context.Context, _ *sql.Tx) error {return nil}diff --git a/db/migrations/20250611010101_playqueue_current_to_index.go b/db/migrations/20250611010101_playqueue_current_to_index.goindex d9250eba2..1b83c0b35 100644--- a/db/migrations/20250611010101_playqueue_current_to_index.go+++ b/db/migrations/20250611010101_playqueue_current_to_index.go@@ -75,6 +75,6 @@ create table playqueue_dg_tmp(return err}-func downPlayQueueCurrentToIndex(ctx context.Context, tx *sql.Tx) error {+func downPlayQueueCurrentToIndex(_ context.Context, _ *sql.Tx) error {return nil}diff --git a/db/migrations/20250701010101_add_folder_hash.go b/db/migrations/20250701010101_add_folder_hash.goindex e82a0749f..c350d31f5 100644--- a/db/migrations/20250701010101_add_folder_hash.go+++ b/db/migrations/20250701010101_add_folder_hash.go@@ -16,6 +16,6 @@ func upAddFolderHash(ctx context.Context, tx *sql.Tx) error {return err}-func downAddFolderHash(ctx context.Context, tx *sql.Tx) error {+func downAddFolderHash(_ context.Context, _ *sql.Tx) error {return nil}diff --git a/db/migrations/20250701010103_add_library_stats.go b/db/migrations/20250701010103_add_library_stats.goindex 8025229cc..a84758a04 100644--- a/db/migrations/20250701010103_add_library_stats.go+++ b/db/migrations/20250701010103_add_library_stats.go@@ -43,6 +43,6 @@ update library setreturn err}-func downAddLibraryStats(ctx context.Context, tx *sql.Tx) error {+func downAddLibraryStats(_ context.Context, _ *sql.Tx) error {return nil}diff --git a/db/migrations/20250701010104_make_replaygain_fields_nullable.go b/db/migrations/20250701010104_make_replaygain_fields_nullable.goindex 163608d32..c6beb2a51 100644--- a/db/migrations/20250701010104_make_replaygain_fields_nullable.go+++ b/db/migrations/20250701010104_make_replaygain_fields_nullable.go@@ -39,7 +39,7 @@ ALTER TABLE media_file RENAME COLUMN rg_track_peak_new TO rg_track_peak;return err}- notice(tx, "Fetching replaygain fields properly will require a full scan")+ notice(ctx, tx, "Fetching replaygain fields properly will require a full scan")return nil}diff --git a/db/migrations/20260220173400_add_fts5_search.go b/db/migrations/20260220173400_add_fts5_search.goindex dc4cd647b..6f2bde429 100644--- a/db/migrations/20260220173400_add_fts5_search.go+++ b/db/migrations/20260220173400_add_fts5_search.go@@ -22,7 +22,7 @@ func stripPunct(col string) string {}func upAddFts5Search(ctx context.Context, tx *sql.Tx) error {- notice(tx, "Adding FTS5 full-text search indexes. This may take a moment on large libraries.")+ notice(ctx, tx, "Adding FTS5 full-text search indexes. This may take a moment on large libraries.")// Step 1: Add search_participants and search_normalized columns to media_file, album, and artist_, err := tx.ExecContext(ctx, `ALTER TABLE media_file ADD COLUMN search_participants TEXT NOT NULL DEFAULT ''`)diff --git a/db/migrations/20260307175815_add_codec_and_update_transcodings.go b/db/migrations/20260307175815_add_codec_and_update_transcodings.goindex 4e8b1b7f5..f52f48440 100644--- a/db/migrations/20260307175815_add_codec_and_update_transcodings.go+++ b/db/migrations/20260307175815_add_codec_and_update_transcodings.go@@ -12,20 +12,20 @@ func init() {goose.AddMigrationContext(upAddCodecAndUpdateTranscodings, downAddCodecAndUpdateTranscodings)}-func upAddCodecAndUpdateTranscodings(_ context.Context, tx *sql.Tx) error {+func upAddCodecAndUpdateTranscodings(ctx context.Context, tx *sql.Tx) error {// Add codec column to media_file.- _, err := tx.Exec(`ALTER TABLE media_file ADD COLUMN codec VARCHAR(255) DEFAULT '' NOT NULL`)+ _, err := tx.ExecContext(ctx, `ALTER TABLE media_file ADD COLUMN codec VARCHAR(255) DEFAULT '' NOT NULL`)if err != nil {return err}- _, err = tx.Exec(`CREATE INDEX IF NOT EXISTS media_file_codec ON media_file(codec)`)+ _, err = tx.ExecContext(ctx, `CREATE INDEX IF NOT EXISTS media_file_codec ON media_file(codec)`)if err != nil {return err}// Update old AAC default (adts) to new default (ipod with fragmented MP4).// Only affects users who still have the unmodified old default command.- _, err = tx.Exec(+ _, err = tx.ExecContext(ctx,`UPDATE transcoding SET command = ? WHERE target_format = 'aac' AND command = ?`,"ffmpeg -i %s -ss %t -map 0:a:0 -b:a %bk -v 0 -c:a aac -f ipod -movflags frag_keyframe+empty_moov -","ffmpeg -i %s -ss %t -map 0:a:0 -b:a %bk -v 0 -c:a aac -f adts -",@@ -36,12 +36,12 @@ func upAddCodecAndUpdateTranscodings(_ context.Context, tx *sql.Tx) error {// Add FLAC transcoding for existing installations that were seeded before FLAC was added.var count int- err = tx.QueryRow("SELECT COUNT(*) FROM transcoding WHERE target_format = 'flac'").Scan(&count)+ err = tx.QueryRowContext(ctx, "SELECT COUNT(*) FROM transcoding WHERE target_format = 'flac'").Scan(&count)if err != nil {return err}if count == 0 {- _, err = tx.Exec(+ _, err = tx.ExecContext(ctx,"INSERT INTO transcoding (id, name, target_format, default_bit_rate, command) VALUES (?, ?, ?, ?, ?)",id.NewRandom(), "flac audio", "flac", 0,"ffmpeg -i %s -ss %t -map 0:a:0 -v 0 -c:a flac -f flac -",@@ -52,22 +52,22 @@ func upAddCodecAndUpdateTranscodings(_ context.Context, tx *sql.Tx) error {}// Add probe_data column for caching ffprobe results.- _, err = tx.Exec(`ALTER TABLE media_file ADD COLUMN probe_data TEXT DEFAULT NULL`)+ _, err = tx.ExecContext(ctx, `ALTER TABLE media_file ADD COLUMN probe_data TEXT DEFAULT NULL`)if err != nil {return err}return nil}-func downAddCodecAndUpdateTranscodings(_ context.Context, tx *sql.Tx) error {- _, err := tx.Exec(`ALTER TABLE media_file DROP COLUMN probe_data`)+func downAddCodecAndUpdateTranscodings(ctx context.Context, tx *sql.Tx) error {+ _, err := tx.ExecContext(ctx, `ALTER TABLE media_file DROP COLUMN probe_data`)if err != nil {return err}- _, err = tx.Exec(`DROP INDEX IF EXISTS media_file_codec`)+ _, err = tx.ExecContext(ctx, `DROP INDEX IF EXISTS media_file_codec`)if err != nil {return err}- _, err = tx.Exec(`ALTER TABLE media_file DROP COLUMN codec`)+ _, err = tx.ExecContext(ctx, `ALTER TABLE media_file DROP COLUMN codec`)return err}diff --git a/db/migrations/20260309120007_fix_probe_data_null.go b/db/migrations/20260309120007_fix_probe_data_null.goindex a7e7366ed..c76d6ed1a 100644--- a/db/migrations/20260309120007_fix_probe_data_null.go+++ b/db/migrations/20260309120007_fix_probe_data_null.go@@ -11,18 +11,18 @@ func init() {goose.AddMigrationContext(upFixProbeDataNull, downFixProbeDataNull)}-func upFixProbeDataNull(_ context.Context, tx *sql.Tx) error {+func upFixProbeDataNull(ctx context.Context, tx *sql.Tx) error {// Recreate probe_data column as NOT NULL with empty string default.// The previous migration created it with DEFAULT NULL, which causes// scan errors when reading into Go string fields.- _, err := tx.Exec(`ALTER TABLE media_file DROP COLUMN probe_data`)+ _, err := tx.ExecContext(ctx, `ALTER TABLE media_file DROP COLUMN probe_data`)if err != nil {return err}- _, err = tx.Exec(`ALTER TABLE media_file ADD COLUMN probe_data TEXT DEFAULT '' NOT NULL`)+ _, err = tx.ExecContext(ctx, `ALTER TABLE media_file ADD COLUMN probe_data TEXT DEFAULT '' NOT NULL`)return err}-func downFixProbeDataNull(_ context.Context, tx *sql.Tx) error {+func downFixProbeDataNull(_ context.Context, _ *sql.Tx) error {return nil}diff --git a/db/migrations/20260309203355_ensure_default_transcodings.go b/db/migrations/20260309203355_ensure_default_transcodings.goindex ab6d24952..4df66d26d 100644--- a/db/migrations/20260309203355_ensure_default_transcodings.go+++ b/db/migrations/20260309203355_ensure_default_transcodings.go@@ -13,7 +13,7 @@ func init() {goose.AddMigrationContext(upEnsureDefaultTranscodings, downEnsureDefaultTranscodings)}-func upEnsureDefaultTranscodings(_ context.Context, tx *sql.Tx) error {+func upEnsureDefaultTranscodings(ctx context.Context, tx *sql.Tx) error {// Older installations may be missing default transcodings that were added// after the initial seeding (e.g., aac was added later than mp3/opus).// Insert any missing defaults without touching user-customized entries.@@ -22,12 +22,12 @@ func upEnsureDefaultTranscodings(_ context.Context, tx *sql.Tx) error {// but the same name.for _, t := range consts.DefaultTranscodings {var count int- err := tx.QueryRow("SELECT COUNT(*) FROM transcoding WHERE target_format = ? OR name = ?", t.TargetFormat, t.Name).Scan(&count)+ err := tx.QueryRowContext(ctx, "SELECT COUNT(*) FROM transcoding WHERE target_format = ? OR name = ?", t.TargetFormat, t.Name).Scan(&count)if err != nil {return err}if count == 0 {- _, err = tx.Exec(+ _, err = tx.ExecContext(ctx,"INSERT INTO transcoding (id, name, target_format, default_bit_rate, command) VALUES (?, ?, ?, ?, ?)",id.NewRandom(), t.Name, t.TargetFormat, t.DefaultBitRate, t.Command,)@@ -39,6 +39,6 @@ func upEnsureDefaultTranscodings(_ context.Context, tx *sql.Tx) error {return nil}-func downEnsureDefaultTranscodings(_ context.Context, tx *sql.Tx) error {+func downEnsureDefaultTranscodings(_ context.Context, _ *sql.Tx) error {return nil}diff --git a/db/migrations/20260310113858_fix_aac_transcode_command.go b/db/migrations/20260310113858_fix_aac_transcode_command.goindex 588137383..a4fa8fcc1 100644--- a/db/migrations/20260310113858_fix_aac_transcode_command.go+++ b/db/migrations/20260310113858_fix_aac_transcode_command.go@@ -11,20 +11,20 @@ func init() {goose.AddMigrationContext(upFixAacTranscodeCommand, downFixAacTranscodeCommand)}-func upFixAacTranscodeCommand(_ context.Context, tx *sql.Tx) error {+func upFixAacTranscodeCommand(ctx context.Context, tx *sql.Tx) error {// The old AAC command used `-f ipod -movflags frag_keyframe+empty_moov` which produces// corrupt/silent audio when ffmpeg pipes to stdout (confirmed in ffmpeg 8.0+).// Switch to `-f adts` (raw AAC framing) which works reliably via pipe.// Only update rows that still have the old default command.const oldCommand = "ffmpeg -i %s -ss %t -map 0:a:0 -b:a %bk -v 0 -c:a aac -f ipod -movflags frag_keyframe+empty_moov -"const newCommand = "ffmpeg -i %s -ss %t -map 0:a:0 -b:a %bk -v 0 -c:a aac -f adts -"- _, err := tx.Exec(+ _, err := tx.ExecContext(ctx,"UPDATE transcoding SET command = ? WHERE target_format = 'aac' AND command = ?",newCommand, oldCommand,)return err}-func downFixAacTranscodeCommand(_ context.Context, tx *sql.Tx) error {+func downFixAacTranscodeCommand(_ context.Context, _ *sql.Tx) error {return nil}diff --git a/db/migrations/20260513173954_move_ss_before_input.go b/db/migrations/20260513173954_move_ss_before_input.goindex c16583aa0..472ae7b43 100644--- a/db/migrations/20260513173954_move_ss_before_input.go+++ b/db/migrations/20260513173954_move_ss_before_input.go@@ -36,18 +36,18 @@ var ssSeekPairs = [][2]string{},}-func upMoveSsBeforeInput(_ context.Context, tx *sql.Tx) error {+func upMoveSsBeforeInput(ctx context.Context, tx *sql.Tx) error {for _, p := range ssSeekPairs {- if _, err := tx.Exec(`UPDATE transcoding SET command = ? WHERE command = ?`, p[1], p[0]); err != nil {+ if _, err := tx.ExecContext(ctx, `UPDATE transcoding SET command = ? WHERE command = ?`, p[1], p[0]); err != nil {return err}}return nil}-func downMoveSsBeforeInput(_ context.Context, tx *sql.Tx) error {+func downMoveSsBeforeInput(ctx context.Context, tx *sql.Tx) error {for _, p := range ssSeekPairs {- if _, err := tx.Exec(`UPDATE transcoding SET command = ? WHERE command = ?`, p[0], p[1]); err != nil {+ if _, err := tx.ExecContext(ctx, `UPDATE transcoding SET command = ? WHERE command = ?`, p[0], p[1]); err != nil {return err}}diff --git a/db/migrations/migration.go b/db/migrations/migration.goindex fde6f5817..9b1098af1 100644--- a/db/migrations/migration.go+++ b/db/migrations/migration.go@@ -12,23 +12,23 @@ import ()// Use this in migrations that need to communicate something important (breaking changes, forced reindexes, etc...)-func notice(tx *sql.Tx, msg string) {- if isDBInitialized(tx) {+func notice(ctx context.Context, tx *sql.Tx, msg string) {+ if isDBInitialized(ctx, tx) {line := strings.Repeat("*", len(msg)+8)fmt.Printf("\n%s\nNOTICE: %s\n%s\n\n", line, msg, line)}}// Call this in migrations that requires a full rescan-func forceFullRescan(tx *sql.Tx) error {+func forceFullRescan(ctx context.Context, tx *sql.Tx) error {// If a full scan is required, most probably the query optimizer is outdated, so we run `analyze`.if conf.Server.DevOptimizeDB {- _, err := tx.Exec(`ANALYZE;`)+ _, err := tx.ExecContext(ctx, `ANALYZE;`)if err != nil {return err}}- _, err := tx.Exec(fmt.Sprintf(`+ _, err := tx.ExecContext(ctx, fmt.Sprintf(`INSERT OR REPLACE into property (id, value) values ('%s', '1');`, consts.FullScanAfterMigrationFlagKey))return err@@ -44,9 +44,9 @@ var (initialized bool)-func isDBInitialized(tx *sql.Tx) bool {+func isDBInitialized(ctx context.Context, tx *sql.Tx) bool {once.Do(func() {- rows, err := tx.Query("select count(*) from property where id=?", consts.InitialSetupFlagKey)+ rows, err := tx.QueryContext(ctx, "select count(*) from property where id=?", consts.InitialSetupFlagKey)checkErr(err)initialized = checkCount(rows) > 0})