Skip to content

🎧 Your Personal Streaming Service

feat(sharing): enable sharing by default (#5714)

Deluan Quintão37e75c435402
diff --git a/conf/configuration.go b/conf/configuration.go
index 17abfe400..8646bf075 100644
--- a/conf/configuration.go
+++ b/conf/configuration.go
@@ -794,7 +794,7 @@ func setViperDefaults() {
viper.SetDefault("uiplaybackreportinterval", consts.DefaultUIPlaybackReportInterval)
viper.SetDefault("enableartworkupload", true)
viper.SetDefault("maximageuploadsize", consts.DefaultMaxImageUploadSize)
- viper.SetDefault("enablesharing", false)
+ viper.SetDefault("enablesharing", true)
viper.SetDefault("shareurl", "")
viper.SetDefault("defaultshareexpiration", 8760*time.Hour)
viper.SetDefault("defaultdownloadableshare", false)
diff --git a/server/nativeapi/config_test.go b/server/nativeapi/config_test.go
index 4e6e9e89b..107b01e01 100644
--- a/server/nativeapi/config_test.go
+++ b/server/nativeapi/config_test.go
@@ -25,6 +25,7 @@ var _ = Describe("Config API", func() {
BeforeEach(func() {
DeferCleanup(configtest.SetupConfig())
+ conf.Server.EnableSharing = false
conf.Server.DevUIShowConfig = true // Enable config endpoint for tests
ds = &tests.MockDataStore{}
auth.Init(ds)
diff --git a/server/nativeapi/library_test.go b/server/nativeapi/library_test.go
index ed5564a41..9b7061845 100644
--- a/server/nativeapi/library_test.go
+++ b/server/nativeapi/library_test.go
@@ -9,6 +9,7 @@ import (
"net/http/httptest"
"strings"
+ "github.com/navidrome/navidrome/conf"
"github.com/navidrome/navidrome/conf/configtest"
"github.com/navidrome/navidrome/consts"
"github.com/navidrome/navidrome/core/auth"
@@ -27,6 +28,7 @@ var _ = Describe("Library API", func() {
BeforeEach(func() {
DeferCleanup(configtest.SetupConfig())
+ conf.Server.EnableSharing = false
ds = &tests.MockDataStore{}
auth.Init(ds)
nativeRouter := New(ds, nil, nil, nil, tests.NewMockLibraryService(), tests.NewMockUserService(), nil, nil, nil)
diff --git a/server/nativeapi/native_api_song_test.go b/server/nativeapi/native_api_song_test.go
index f0ee50ebb..b1ed09d65 100644
--- a/server/nativeapi/native_api_song_test.go
+++ b/server/nativeapi/native_api_song_test.go
@@ -32,6 +32,7 @@ var _ = Describe("Song Endpoints", func() {
BeforeEach(func() {
DeferCleanup(configtest.SetupConfig())
+ conf.Server.EnableSharing = false
conf.Server.SessionTimeout = time.Minute
// Setup mock repositories
diff --git a/server/nativeapi/playlists_test.go b/server/nativeapi/playlists_test.go
index e1c933709..9bf502687 100644
--- a/server/nativeapi/playlists_test.go
+++ b/server/nativeapi/playlists_test.go
@@ -76,6 +76,7 @@ var _ = Describe("Playlist Tracks Endpoint", func() {
BeforeEach(func() {
DeferCleanup(configtest.SetupConfig())
+ conf.Server.EnableSharing = false
conf.Server.SessionTimeout = time.Minute
plsSvc = &mockPlaylistsService{}
diff --git a/server/nativeapi/plugin_test.go b/server/nativeapi/plugin_test.go
index 8fc88e09c..aa91a7951 100644
--- a/server/nativeapi/plugin_test.go
+++ b/server/nativeapi/plugin_test.go
@@ -29,6 +29,7 @@ var _ = Describe("Plugin API", func() {
BeforeEach(func() {
DeferCleanup(configtest.SetupConfig())
+ conf.Server.EnableSharing = false
conf.Server.Plugins.Enabled = true
ds = &tests.MockDataStore{}
mockManager = &tests.MockPluginManager{}