🎧 Your Personal Streaming Service
Go airsonicmadsonicmedia-servermusicmusic-servernavidromeopensubsonicraspberry-piself-hostedstreamerstreaming-apistreaming-audiosubsonicsubsonic-server
fix(scanner): optimize missing flag update logic for artists
Deluan6bf642486416
diff --git a/persistence/artist_repository.go b/persistence/artist_repository.goindex b6b1aba44..eb87ed006 100644--- a/persistence/artist_repository.go+++ b/persistence/artist_repository.go@@ -244,24 +244,23 @@ func (r *artistRepository) purgeEmpty() error {return nil}-// markMissing sets the Missing flag based on album data.-func (r *artistRepository) markMissing() (int64, error) {+// markMissing marks artists as missing if all their albums are missing.+func (r *artistRepository) markMissing() error {q := Expr(`- update artist- set missing = not exists (- select 1 from album_artists aa- join album a on aa.album_id = a.id- where aa.artist_id = artist.id and a.missing = false- )+with artists_with_non_missing_albums as (+ select distinct aa.artist_id+ from album_artists aa+ join album a on aa.album_id = a.id+ where a.missing = false+)+update artist+set missing = (artist.id not in (select artist_id from artists_with_non_missing_albums));`)- c, err := r.executeSQL(q)+ _, err := r.executeSQL(q)if err != nil {- return 0, fmt.Errorf("marking missing artists: %w", err)- }- if c > 0 {- log.Debug(r.ctx, "Marked missing artists", "totalUpdated", c)+ return fmt.Errorf("marking missing artists: %w", err)}- return c, nil+ return nil}// RefreshPlayCounts updates the play count and last play date annotations for all artists, baseddiff --git a/persistence/persistence.go b/persistence/persistence.goindex 31e03db61..2536b9c35 100644--- a/persistence/persistence.go+++ b/persistence/persistence.go@@ -170,7 +170,7 @@ func (s *SQLStore) GC(ctx context.Context) error {err := chain.RunSequentially(trace(ctx, "purge empty albums", func() error { return s.Album(ctx).(*albumRepository).purgeEmpty() }),trace(ctx, "purge empty artists", func() error { return s.Artist(ctx).(*artistRepository).purgeEmpty() }),- trace(ctx, "mark missing artists", func() error { _, err := s.Artist(ctx).(*artistRepository).markMissing(); return err }),+ trace(ctx, "mark missing artists", func() error { return s.Artist(ctx).(*artistRepository).markMissing() }),trace(ctx, "purge empty folders", func() error { return s.Folder(ctx).(*folderRepository).purgeEmpty() }),trace(ctx, "clean album annotations", func() error { return s.Album(ctx).(*albumRepository).cleanAnnotations() }),trace(ctx, "clean artist annotations", func() error { return s.Artist(ctx).(*artistRepository).cleanAnnotations() }),