Automation foundation model for tiny devices: 2-bit, 8-29 MB, tool calls, ASR, structured extraction and embeddings on phones, wearables, smart homes, robots, cars and microcontrollers.
fix: carry the agent's system facts and generation into agent.extract (#143)
Raj Ojhac11ccba41e0b
diff --git a/needle/__init__.py b/needle/__init__.pyindex 11c012e..fcf84b7 100644--- a/needle/__init__.py+++ b/needle/__init__.py@@ -362,8 +362,9 @@ class Needle:def extract(self, text: str, schema: type | dict, max_new_tokens: int = 512,strict: bool = True) -> object:- return extract(text, schema, max_new_tokens=max_new_tokens,- weights=self._weights, strict=strict)+ return extract(text, schema, system=self._system_text or None,+ max_new_tokens=max_new_tokens, weights=self._weights,+ strict=strict, generation=self._generation)def reset(self):self._bind()diff --git a/tests/test_weights.py b/tests/test_weights.pyindex 7c703cf..b41935b 100644--- a/tests/test_weights.py+++ b/tests/test_weights.py@@ -337,3 +337,66 @@ def test_tool_result_turns_do_not_count_as_queries(engine):warnings.simplefilter("error")for _ in range(needle.UNRESET_TURNS):agent.run("go")+++def test_agent_extract_carries_its_own_system_facts(engine, monkeypatch):+ import needle++ seen = {}++ def spy(text, schema, system=None, max_new_tokens=512, weights=None, strict=True, generation=None):+ seen.update(text=text, system=system, weights=weights, strict=strict, generation=generation)+ return None++ monkeypatch.setattr(needle, "extract", spy)+ facts = "date: 2026-07-21 Tue 14:30; locale: en-US"+ agent = needle.Needle(tools="[]", system=facts)++ assert agent.extract("dinner tomorrow at 7", {"type": "object"}) is None+ assert seen["system"] == facts+ assert seen["text"] == "dinner tomorrow at 7"+++def test_agent_extract_without_system_facts_sends_none_when_autodate_disabled(engine, monkeypatch):+ import needle++ seen = {}+ monkeypatch.setattr(+ needle, "extract",+ lambda text, schema, system=None, **kwargs: seen.update(system=system))+ needle.Needle(tools="[]", auto_date=False).extract("anything", {"type": "object"})++ assert seen["system"] is None+++def test_agent_extract_without_system_facts_carries_date_line(engine, monkeypatch):+ import needle++ seen = {}+ monkeypatch.setattr(+ needle, "extract",+ lambda text, schema, system=None, **kwargs: seen.update(system=system))+ needle.Needle(tools="[]").extract("anything", {"type": "object"})++ assert seen["system"] is not None+ assert seen["system"].startswith("date: ")+++def test_agent_extract_still_carries_weights_strict_and_generation(engine, tuned, monkeypatch):+ import needle++ seen = {}+ monkeypatch.setattr(+ needle, "extract",+ lambda text, schema, system=None, max_new_tokens=512, weights=None, strict=True, generation=None:+ seen.update(system=system, weights=weights, strict=strict, generation=generation))+ with warnings.catch_warnings():+ warnings.simplefilter("ignore")+ agent = needle.Needle(tools="[]", weights=tuned, system="device: phone", generation=3)+ agent.extract("anything", {"type": "object"}, strict=False)++ assert seen["weights"] == tuned+ assert seen["strict"] is False+ assert seen["generation"] == agent._generation+ assert "device: phone" in seen["system"]+ assert seen["system"].startswith("date: ")