Skip to content

Node-based terminal manager for AI coding agents — tmux-backed terminals and parallel agent sessions as draggable nodes on an infinite pan/zoom canvas. macOS, Linux, and a browser Server Edition.

test(renderer): pin the transport's once-only close in both orders, and no session on a dead role question

review08bcf2857051
diff --git a/src/renderer/bridge/frame-transport.test.ts b/src/renderer/bridge/frame-transport.test.ts
index 50126385b..6556389e6 100644
--- a/src/renderer/bridge/frame-transport.test.ts
+++ b/src/renderer/bridge/frame-transport.test.ts
@@ -126,6 +126,15 @@ describe('RelayFrameTransport: a close is a close, whoever made it', () => {
expect(cb).toHaveBeenCalledTimes(1)
})
+ it('fires once in the other order too (our own close, then main noticing the socket is gone)', () => {
+ const r = relay()
+ const cb = vi.fn()
+ new RelayFrameTransport('conn-rev', r.api).onClose(cb)
+ emitLocalRelayClose('conn-rev')
+ r.mainClose.get('conn-rev')!()
+ expect(cb).toHaveBeenCalledTimes(1)
+ })
+
it('an RpcClient over it fails its in-flight requests on a local close', async () => {
const r = relay()
const client = new RpcClient(new RelayFrameTransport('conn-rpc', r.api))
diff --git a/src/renderer/session/relay-tab.local-close.test.ts b/src/renderer/session/relay-tab.local-close.test.ts
index 671942b43..a60d172fe 100644
--- a/src/renderer/session/relay-tab.local-close.test.ts
+++ b/src/renderer/session/relay-tab.local-close.test.ts
@@ -82,6 +82,9 @@ describe('openRelayTab — a hosted connection closed from this side while the t
expect(sessionCount()).toBe(1) // only the local session
expect(f.disconnect).toHaveBeenCalledWith('conn-self')
expect(useHostedTeams.getState().bySession).toEqual({})
+ // No session was ever created for it (not created-then-disposed): a dead role question is not
+ // answered with a Viewer guess. The next relay session is the first one.
+ expect(createSession('relay', { marker: 'next' } as unknown as NodeTerminalApi, 'next').id).toBe('relay-1')
})
it('during the workspace load: the tab rejects and disposes the session it had created (presence too)', async () => {