Skip to content

Node-based terminal manager for AI coding agents — tmux-backed terminals and parallel agent sessions as draggable nodes on an infinite pan/zoom canvas. macOS, Linux, and a browser Server Edition.

ci(windows): release-win ships dist:win:release and a latest.yml notice feed

review0a3920e450c6
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
index 44fd7d34d..f51dbc782 100644
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -197,11 +197,13 @@ jobs:
dist/latest-linux.yml
# Windows build: UNSIGNED BETA (#454), on a plain GitHub runner. Publishes the NSIS
- # installer + zip as assets on the same tag's GitHub Release — and NOTHING to the update
- # feed: `dist:win` stamps the package `nodeTermUpdates=disabled` (see src/main/updater.ts),
- # so the shipped app's updater is cleanly off — no latest.yml is uploaded anywhere, no 404
- # polling in the field. Auto-update arrives with code signing; an unsigned auto-update is a
- # trust downgrade. Users update by downloading the next installer.
+ # installer + zip + latest.yml as assets on the same tag's GitHub Release. latest.yml is a
+ # PASSIVE notice feed only: `dist:win:release` stamps the package `nodeTermUpdates=manual`
+ # (see src/shared/update-platform.ts), so the shipped app checks the feed and shows a
+ # "new version available — Download" card linking the releases page, but never downloads or
+ # installs (quitAndInstall is refused in main). Self-install arrives with code signing; an
+ # unsigned auto-update is a trust downgrade. The nodeterm.dev/updates mirror must serve
+ # latest.yml the way it serves latest-mac.yml / latest-linux.yml (hosted outside this repo).
#
# BEST-EFFORT by design: the `publish` promote gate below deliberately does NOT wait on
# this job, so a Windows failure never strands the mac+linux release as a prerelease. A
@@ -223,10 +225,11 @@ jobs:
- name: Install dependencies
run: npm ci
- # make-icon + electron-vite build + electron-builder --win --x64 --publish never.
- # Unsigned: no signing secrets exist for Windows yet; SmartScreen will warn.
+ # make-icon + electron-vite build + electron-builder --win --x64 --publish never, stamped
+ # nodeTermUpdates=manual (plain `dist:win` stays `disabled` for local packages that must
+ # never poll). Unsigned: no signing secrets exist for Windows yet; SmartScreen will warn.
- name: Build Windows packages (NSIS installer + zip, unsigned)
- run: npm run dist:win
+ run: npm run dist:win:release
# The artifact names are the contract (same check as win-package-smoke.yml): a silent
# target/artifactName regression must fail here, before the upload step lies about it.
@@ -237,10 +240,12 @@ jobs:
version=$(node -p "require('./package.json').version")
test -f "dist/nodeterm-Setup-${version}.exe" || { echo "::error::NSIS installer missing"; exit 1; }
ls dist/nodeterm-*-win.zip >/dev/null 2>&1 || { echo "::error::win zip missing"; exit 1; }
+ test -f dist/latest.yml || { echo "::error::latest.yml (update notice feed) missing"; exit 1; }
- # Deliberately narrow globs: only the installer + zip. No *.yml (that would be the
- # update-feed leg this job must not have) and no *.blockmap (differential updates are
- # part of the same auto-update story that waits on signing).
+ # Deliberately narrow globs: the installer + zip + latest.yml (the passive notice feed).
+ # No *.blockmap: differential downloads belong to the self-install story that waits on
+ # signing. The feed may briefly name this version before `publish` promotes it — harmless,
+ # the card only links the releases page and never downloads a file.
- name: Upload to GitHub Release
env:
GH_TOKEN: ${{ github.token }}
@@ -253,7 +258,7 @@ jobs:
gh release view "$tag" --repo "$GITHUB_REPOSITORY" >/dev/null 2>&1 || \
gh release create "$tag" --repo "$GITHUB_REPOSITORY" --title "$tag" --verify-tag --prerelease --notes "" || true
n=1
- until gh release upload "$tag" dist/nodeterm-Setup-*.exe dist/nodeterm-*-win.zip --clobber --repo "$GITHUB_REPOSITORY"; do
+ until gh release upload "$tag" dist/nodeterm-Setup-*.exe dist/nodeterm-*-win.zip dist/latest.yml --clobber --repo "$GITHUB_REPOSITORY"; do
if [ "$n" -ge 5 ]; then
echo "::error::asset upload failed after $n attempts"
exit 1
@@ -268,8 +273,8 @@ jobs:
# feeds) keeps serving the previous complete release — a mac-runner sleep or an upload
# failure can no longer put a partial release in front of users. If one platform job
# fails, fix/rerun it; this job then runs on the rerun and publishes.
- # release-win is deliberately NOT in `needs`: the Windows asset is an unsigned beta with no
- # update feed behind it, and its failure must never hold the mac+linux release hostage.
+ # release-win is deliberately NOT in `needs`: the Windows asset is an unsigned beta whose feed
+ # is a passive notice only, and its failure must never hold the mac+linux release hostage.
publish:
runs-on: ubuntu-latest
needs: [release-mac, release-linux]
diff --git a/.github/workflows/win-package-smoke.yml b/.github/workflows/win-package-smoke.yml
index 1e0cb9645..aab325d76 100644
--- a/.github/workflows/win-package-smoke.yml
+++ b/.github/workflows/win-package-smoke.yml
@@ -8,9 +8,10 @@ name: Windows package smoke
# BUILD ONLY — this workflow must NEVER publish. `dist:win` passes `--publish never`, nothing
# here uploads to the update feed or creates a release, and the produced installer is unsigned.
# The session-host phase (#305) has merged and release.yml's `release-win` job now ships this
-# same build as an UNSIGNED BETA on every version tag (#454). Still deliberate follow-ups:
-# code signing, and — gated on it — the auto-update leg (latest.yml on nodeterm.dev/updates);
-# an unsigned auto-update is a trust downgrade, so the beta ships with its updater disabled.
+# same build as an UNSIGNED BETA on every version tag (#454), via `dist:win:release`, which adds a
+# passive update-notice feed (latest.yml, `nodeTermUpdates=manual`: check only, never install).
+# Still deliberate follow-ups: code signing, and — gated on it — Windows self-install;
+# an unsigned auto-update is a trust downgrade, and this smoke build (`dist:win`) never polls.
on:
workflow_dispatch:
diff --git a/package.json b/package.json
index 21b304f5c..37328f616 100644
--- a/package.json
+++ b/package.json
@@ -32,6 +32,7 @@
"dist": "npm run make-icon && npm run build && electron-builder --mac --arm64 --publish never -c.mac.identity=null -c.mac.notarize=false -c.extraMetadata.nodeTermUpdates=disabled",
"dist:linux": "npm run make-icon && npm run build && electron-builder --linux --publish never -c.extraMetadata.nodeTermUpdates=disabled",
"dist:win": "npm run make-icon && npm run build && electron-builder --win --x64 --publish never -c.extraMetadata.nodeTermUpdates=disabled",
+ "dist:win:release": "npm run make-icon && npm run build && electron-builder --win --x64 --publish never -c.extraMetadata.nodeTermUpdates=manual",
"release": "npm run make-icon && npm run build && sh -c 'electron-builder --mac --arm64 --x64 --publish never; s=$?; npm run rebuild; exit $s'",
"postinstall": "node scripts/patch-node-pty.mjs && electron-rebuild -f -w node-pty,smart-whisper"
},
diff --git a/src/main/release-win-workflow.test.ts b/src/main/release-win-workflow.test.ts
new file mode 100644
index 000000000..adc9af004
--- /dev/null
+++ b/src/main/release-win-workflow.test.ts
@@ -0,0 +1,62 @@
+import { describe, expect, it } from 'vitest'
+import fs from 'fs'
+import path from 'path'
+
+/**
+ * Release guard for the unsigned Windows beta's update notice. `release-win` must build with the
+ * `manual` marker (`dist:win:release`) and upload `latest.yml` — without it the shipped app can
+ * never learn a new version exists — and must NOT upload blockmaps: differential downloads belong
+ * to the self-install story that waits on code signing. Text-level, like the job's own
+ * artifact-contract step; no YAML parser needed for a job block this regular.
+ */
+const WORKFLOW = path.resolve(__dirname, '../../.github/workflows/release.yml')
+
+function jobBlock(text: string, job: string): string {
+ const start = text.indexOf(`\n ${job}:\n`)
+ expect(start, `job ${job} not found in release.yml`).toBeGreaterThanOrEqual(0)
+ const rest = text.slice(start + 1)
+ // The next top-level job: a line indented exactly two spaces that names a key.
+ const next = rest.slice(1).search(/\n {2}[a-z][\w-]*:\n/)
+ return next < 0 ? rest : rest.slice(0, next + 1)
+}
+
+/** Only the shell lines — comments explain the omissions and would match the negative checks. */
+function commands(block: string): string {
+ return block
+ .split('\n')
+ .filter((l) => !l.trim().startsWith('#'))
+ .join('\n')
+}
+
+describe('release.yml release-win', () => {
+ const text = fs.readFileSync(WORKFLOW, 'utf8')
+ const job = commands(jobBlock(text, 'release-win'))
+
+ it('builds the manual-marker package, not the local never-polling one', () => {
+ expect(job).toMatch(/run: npm run dist:win:release\s*\n/)
+ expect(job).not.toMatch(/run: npm run dist:win\s*\n/)
+ })
+
+ it('fails the job when latest.yml was not produced', () => {
+ expect(job).toContain('test -f dist/latest.yml')
+ })
+
+ it('uploads latest.yml beside the installer and zip', () => {
+ const upload = job.split('\n').find((l) => l.includes('gh release upload'))
+ expect(upload).toBeDefined()
+ expect(upload).toContain('dist/nodeterm-Setup-*.exe')
+ expect(upload).toContain('dist/nodeterm-*-win.zip')
+ expect(upload).toContain('dist/latest.yml')
+ })
+
+ it('uploads no blockmap and no broad yml glob', () => {
+ expect(job).not.toContain('blockmap')
+ expect(job).not.toContain('dist/*.yml')
+ })
+
+ it('is still not a gate on the mac+linux publish', () => {
+ const publish = commands(jobBlock(text, 'publish'))
+ expect(publish).toMatch(/needs: \[release-mac, release-linux\]/)
+ expect(publish).not.toContain('release-win')
+ })
+})