Node-based terminal manager for AI coding agents — tmux-backed terminals and parallel agent sessions as draggable nodes on an infinite pan/zoom canvas. macOS, Linux, and a browser Server Edition.
TypeScript adhdagent-orchestrationai-agentscanvasclaude-codecodexcoding-agentsdeveloper-toolselectrongeminilinuxmacosmultiplexeropencodeparallel-agentsterminalterminal-emulatorterminal-multiplexertmuxworkspace-manager
fix(diagnostics): verify current workspace and process
Darren Kattan195f826a2576
diff --git a/scripts/agent-session-scan.mjs b/scripts/agent-session-scan.mjsindex 7e415cf91..2ed75dd7e 100644--- a/scripts/agent-session-scan.mjs+++ b/scripts/agent-session-scan.mjs@@ -1,7 +1,8 @@#!/usr/bin/env node/**- * Local, read-only field diagnostic for Nodeterm agent sessions.+ * Local field diagnostic for Nodeterm agent sessions. Scanning does not mutate Nodeterm state;+ * the explicit `--append` option writes the metadata-only report chosen by the caller.** It joins four independently useful facts:* - the node's persisted launch record (workspace/project files),@@ -60,6 +61,11 @@ const SHELL_NAMES = new Set(['zsh'])+// Interpreters whose next non-option argv slot is the executable script. Keep this narrow: an+// arbitrary argument named `claude` (for example `rg claude README.md`) is not proof that Claude+// owns the foreground process group.+const INTERPRETERS = new Set(['node', 'nodejs', 'bun', 'deno', 'python', 'python3', 'ruby', 'perl'])+const SCREEN_SIGNALS = [['awaiting-confirmation', /ready to code\?|would you like to proceed\?|do you want to proceed/i],['permission-prompt', /allow .*\?|approve|bypass permissions|manual(?:ly)? approve/i],@@ -147,9 +153,12 @@ function processScore(row, expected) {const argv = tokens(row.args)if (baseName(row.command) === want) return 100if (baseName(argv[0]) === want) return 90- if (baseName(argv[1]) === want) return 80- if (argv.some((part) => baseName(part) === want)) return 70- if (new RegExp(`(?:^|[/\\\\])${want}(?:\\.(?:js|mjs|cjs))?(?:$|\\s)`, 'i').test(row.args)) return 60+ const head = baseName(argv[0])+ const script = argv[1]+ if (INTERPRETERS.has(head) && script && !script.startsWith('-')) {+ const scriptName = baseName(script).replace(/\.(?:js|mjs|cjs)$/i, '')+ if (scriptName === want) return 80+ }return 0}@@ -244,6 +253,12 @@ function readJson(file) {}}+// Mirrors `isInlineProjectFileId` in core/workspace-files.ts. workspace.json is hand-editable, so+// an inline-project id must cross the same path jail before it names a file under userData.+function isInlineProjectFileId(id) {+ return typeof id === 'string' && /^[A-Za-z0-9][A-Za-z0-9._-]{0,79}$/.test(id) && !id.includes('..')+}+/** Read only the launch metadata needed by the scan; never mutates or migrates workspace files. */export function loadWorkspaceNodes(userDataDir) {const indexPath = path.join(userDataDir, 'workspace.json')@@ -254,8 +269,23 @@ export function loadWorkspaceNodes(userDataDir) {const errors = []const entries = Array.isArray(indexRead.value.entries) ? indexRead.value.entries : []for (const entry of entries) {- let project = entry.project+ let projectlet source = indexPath+ // A cwd-less v3 project stores its authoritative content in+ // `userData/inline-projects/<id>.json`; `entry.project` is only the one-release compatibility+ // cache. Match WorkspaceStore.loadV3: a valid data file wins, and a missing/corrupt one falls+ // back to that cache. Never let a hand-edited id escape the inline-projects directory.+ if (entry.dataFile === true && !entry.cwd && !entry.ssh && isInlineProjectFileId(entry.id)) {+ const dataFile = path.join(userDataDir, 'inline-projects', `${entry.id}.json`)+ const dataRead = readJson(dataFile)+ if (dataRead.value?.version === 1 && Array.isArray(dataRead.value.nodes)) {+ project = dataRead.value+ source = dataFile+ } else {+ errors.push(`${dataFile}: ${dataRead.error || 'invalid project file'}`)+ }+ }+ if (!project) project = entry.projectif (!project && entry.cwd) {source = path.join(entry.cwd, '.nodeterm', 'project.json')const projectRead = readJson(source)@@ -599,12 +629,13 @@ export function parseCliArgs(argv) {const HELP = `Usage: npm run diagnose:agents -- [options]-Read-only scan of Nodeterm-owned tmux agent panes.+Scan Nodeterm-owned tmux agent panes without mutating Nodeterm state.+Process inspection requires POSIX ps and is not supported on native Windows.--node <id[,id]> scan only these node ids--screens include recent terminal screen text on stdout (never in appended logs)--screen-lines <n> lines captured per screen (default 80)- --append <path> append a metadata-only scan header and one JSONL record per session+ --append <path> write by appending a metadata-only header and one JSONL record per session--watch <seconds> repeat until interrupted--count <n> stop a watch after n scans--json print JSON (includes screens only with --screens)diff --git a/src/core/agent-session-scan-script.test.ts b/src/core/agent-session-scan-script.test.tsindex 46f78812e..9c82f80ce 100644--- a/src/core/agent-session-scan-script.test.ts+++ b/src/core/agent-session-scan-script.test.ts@@ -1,6 +1,9 @@import { describe, expect, it } from 'vitest'+import fs from 'node:fs'+import os from 'node:os'+import path from 'node:path'// @ts-expect-error The field scanner intentionally runs as dependency-free native ESM.-import { auditSession, classifyProcesses, cleanScreen, extractModelArg, parseCliArgs, parsePaneList, parseProcessList, parseScreenContextWindow, reportLogLines, screenSignals } from '../../scripts/agent-session-scan.mjs'+import { auditSession, classifyProcesses, cleanScreen, extractModelArg, loadWorkspaceNodes, parseCliArgs, parsePaneList, parseProcessList, parseScreenContextWindow, reportLogLines, screenSignals } from '../../scripts/agent-session-scan.mjs'describe('agent session scanner', () => {it('keeps the pane shell pid separate from the foreground agent pid', () => {@@ -30,6 +33,28 @@ describe('agent session scanner', () => {})})+ it('does not mistake an unrelated command argument for the expected agent', () => {+ const rows = parseProcessList(`+ 79108 79108 Ss -zsh -zsh+ 79141 79141 S+ rg rg claude README.md+ `)+ expect(classifyProcesses(rows, 79108, 'claude')).toMatchObject({+ state: 'unexpected-foreground',+ agentPid: undefined+ })+ })++ it('recognizes an agent launched through an interpreter wrapper', () => {+ const rows = parseProcessList(`+ 79108 79108 Ss -zsh -zsh+ 79141 79141 S+ node node /opt/homebrew/bin/claude --resume session+ `)+ expect(classifyProcesses(rows, 79108, 'claude')).toMatchObject({+ state: 'agent-running',+ agentPid: 79141+ })+ })+it('parses pane records without conflating the session id and node id', () => {const sep = '\u001f'expect(@@ -52,6 +77,93 @@ describe('agent session scanner', () => {expect(extractModelArg('claude --model="model with spaces"')).toBe('model with spaces')})+ it('loads an inline project from its authoritative data file instead of the compatibility cache', () => {+ const userDataDir = fs.mkdtempSync(path.join(os.tmpdir(), 'nodeterm-agent-scan-'))+ try {+ fs.mkdirSync(path.join(userDataDir, 'inline-projects'))+ fs.writeFileSync(+ path.join(userDataDir, 'workspace.json'),+ JSON.stringify({+ version: 3,+ entries: [{+ id: 'project-inline-1',+ name: 'Inline',+ dataFile: true,+ project: { nodes: [{ id: 'stale-node', agentId: 'claude' }] }+ }]+ })+ )+ fs.writeFileSync(+ path.join(userDataDir, 'inline-projects', 'project-inline-1.json'),+ JSON.stringify({+ version: 1,+ nodes: [{ id: 'fresh-node', agentId: 'codex', agentLaunchModel: 'gpt-5.6' }]+ })+ )++ const workspace = loadWorkspaceNodes(userDataDir)+ expect([...workspace.nodes.keys()]).toEqual(['fresh-node'])+ expect(workspace.nodes.get('fresh-node')).toMatchObject({+ agentId: 'codex',+ agentLaunchModel: 'gpt-5.6',+ source: path.join(userDataDir, 'inline-projects', 'project-inline-1.json')+ })+ } finally {+ fs.rmSync(userDataDir, { recursive: true, force: true })+ }+ })++ it('jails inline data-file ids and falls back to the compatibility cache', () => {+ const userDataDir = fs.mkdtempSync(path.join(os.tmpdir(), 'nodeterm-agent-scan-'))+ try {+ fs.writeFileSync(+ path.join(userDataDir, 'workspace.json'),+ JSON.stringify({+ version: 3,+ entries: [{+ id: '../outside',+ name: 'Unsafe inline id',+ dataFile: true,+ project: { nodes: [{ id: 'cached-node', agentId: 'claude' }] }+ }]+ })+ )++ const workspace = loadWorkspaceNodes(userDataDir)+ expect([...workspace.nodes.keys()]).toEqual(['cached-node'])+ expect(workspace.nodes.get('cached-node')?.source).toBe(path.join(userDataDir, 'workspace.json'))+ } finally {+ fs.rmSync(userDataDir, { recursive: true, force: true })+ }+ })++ it('falls back to the compatibility cache when an authoritative inline data file is unreadable', () => {+ const userDataDir = fs.mkdtempSync(path.join(os.tmpdir(), 'nodeterm-agent-scan-'))+ try {+ fs.writeFileSync(+ path.join(userDataDir, 'workspace.json'),+ JSON.stringify({+ version: 3,+ entries: [{+ id: 'project-inline-1',+ name: 'Inline fallback',+ dataFile: true,+ project: { nodes: [{ id: 'cached-node', agentId: 'claude' }] }+ }]+ })+ )++ const workspace = loadWorkspaceNodes(userDataDir)+ expect([...workspace.nodes.keys()]).toEqual(['cached-node'])+ expect(workspace.nodes.get('cached-node')?.source).toBe(path.join(userDataDir, 'workspace.json'))+ expect(workspace.errors[0]).toContain(+ path.join(userDataDir, 'inline-projects', 'project-inline-1.json')+ )+ } finally {+ fs.rmSync(userDataDir, { recursive: true, force: true })+ }+ })+it('flags the shell-only and stale autocompact cases independently', () => {const audited = auditSession({pane: { nodeId: 'term-1' },