Skip to content

Node-based terminal manager for AI coding agents — tmux-backed terminals and parallel agent sessions as draggable nodes on an infinite pan/zoom canvas. macOS, Linux, and a browser Server Edition.

feat(settings): label mobileLiveActivities 'Live updates on phone' (key unchanged)

review6a31c049a94c
diff --git a/src/renderer/components/settings/sections/NotificationsSection.tsx b/src/renderer/components/settings/sections/NotificationsSection.tsx
index d0856f21c..278e39fec 100644
--- a/src/renderer/components/settings/sections/NotificationsSection.tsx
+++ b/src/renderer/components/settings/sections/NotificationsSection.tsx
@@ -28,7 +28,7 @@ const ROWS = {
},
mobilePush: {
title: 'Send push notifications to your paired phone',
- keywords: ['push', 'phone', 'mobile', 'apns', 'ios', 'notification', 'approval', 'question', 'done', 'completed', 'needs you', 'live activity', 'live activities', 'dynamic island', 'lock screen', 'presence', 'idle', 'hold', 'defer', 'at this computer']
+ keywords: ['push', 'phone', 'mobile', 'apns', 'fcm', 'ios', 'android', 'notification', 'approval', 'question', 'done', 'completed', 'needs you', 'live update', 'live updates', 'live activity', 'live activities', 'ongoing notification', 'dynamic island', 'lock screen', 'presence', 'idle', 'hold', 'defer', 'at this computer']
}
}
const ENTRIES = Object.values(ROWS)
@@ -294,19 +294,19 @@ export function NotificationsSection({ isActive }: { isActive: boolean }): React
}
/>
<FieldRow
- label="Live Activities"
- description="Keep a Lock Screen / Dynamic Island activity updated as a session works, needs you, or finishes."
+ label="Live updates on phone"
+ description="Keep a live status on your phone's lock screen updated as a session works, needs you, or finishes."
control={
<Switch
checked={mobileLiveActivities}
- ariaLabel="Live Activities on your phone"
+ ariaLabel="Live updates on your phone"
onChange={(on) => update({ mobileLiveActivities: on })}
/>
}
/>
<FieldRow
label="Hold phone alerts while you're at this computer"
- description="Defer approval, question, and completed alerts while you're active here, then send them the moment you go idle or lock the screen. Live Activities are never held."
+ description="Defer approval, question, and completed alerts while you're active here, then send them the moment you go idle or lock the screen. Live updates are never held."
control={
<Switch
checked={mobilePushPresenceAware}
diff --git a/src/renderer/lib/mobileStore.guard.test.ts b/src/renderer/lib/mobileStore.guard.test.ts
index 0b7767cfc..c9203bcaa 100644
--- a/src/renderer/lib/mobileStore.guard.test.ts
+++ b/src/renderer/lib/mobileStore.guard.test.ts
@@ -52,6 +52,12 @@ const BANNED_COPY: Record<string, string[]> = {
'src/renderer/components/onboarding/OnboardingFlow.tsx': [
'Get the iOS app',
'Grab it from the App Store'
+ ],
+ 'src/renderer/components/settings/sections/NotificationsSection.tsx': [
+ 'label="Live Activities"',
+ 'ariaLabel="Live Activities',
+ 'Live Activities are never held',
+ 'Lock Screen / Dynamic Island'
]
}
@@ -82,4 +88,13 @@ describe('mobile store guard', () => {
}
expect(offenders).toEqual([])
})
+
+ it('renames the label but keeps the persisted mobileLiveActivities key', () => {
+ const src = readFileSync(
+ join(REPO_ROOT, 'src/renderer/components/settings/sections/NotificationsSection.tsx'),
+ 'utf8'
+ )
+ expect(src).toContain('label="Live updates on phone"')
+ expect(src).toContain('update({ mobileLiveActivities: on })')
+ })
})
diff --git a/src/shared/types.ts b/src/shared/types.ts
index dbb4520fa..8a142ef96 100644
--- a/src/shared/types.ts
+++ b/src/shared/types.ts
@@ -2184,9 +2184,12 @@ export interface Settings {
/** Push when an agent finishes a turn (the `done` kind). Default on. Sub-gate under
* `mobilePushEnabled` (the master switch). Toggle in Settings → Notifications. */
mobilePushDone: boolean
- /** Stream Live Activity updates (Lock Screen / Dynamic Island) to paired phones as a session's
- * state + activity + context% change (spec: interactive-push-live-activities). Default on.
- * Sub-gate under `mobilePushEnabled` (the master switch). Toggle in Settings → Notifications. */
+ /** Stream live status updates to paired phones as a session's state + activity + context%
+ * change — an iOS Live Activity (Lock Screen / Dynamic Island) or an Android ongoing
+ * notification (spec: interactive-push-live-activities). Default on. The KEY keeps its
+ * iOS-era name because it is persisted in settings.json; the UI calls it "Live updates on
+ * phone". Sub-gate under `mobilePushEnabled` (the master switch). Toggle in Settings →
+ * Notifications. */
mobileLiveActivities: boolean
/** Hold phone ALERTS while you're actively at this computer, releasing them when you go idle or
* lock the screen (spec: presence-aware-push). Default on. Desktop-only (the Server Edition is