Skip to content

Node-based terminal manager for AI coding agents — tmux-backed terminals and parallel agent sessions as draggable nodes on an infinite pan/zoom canvas. macOS, Linux, and a browser Server Edition.

Merge remote-tracking branch 'origin/main' into fix/test-tmux-socket-isolation

enes762d10c929b3
diff --cc CONTRIBUTING.md
index 2028901f8,42857010f..03032f1ab
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@@ -310,16 -320,16 +320,26 @@@ Where a behaviour can only be verified
GPU), say so explicitly rather than implying coverage. Several docs carry numbered device
checklists for exactly this.
+ **A test that reads a checked-in file must not care how git checked it out.** `.gitattributes`
+ declares `* text=auto eol=lf`, so every working tree is LF — but attributes only take effect on a
+ re-checkout, so if you cloned before it landed, run `git add --renormalize .` (or re-clone) and your
+ tree catches up. Windows is where this bites: Git for Windows defaults to `core.autocrlf=true`, so
+ without the attributes file a fresh clone had CRLF working files and `CSS.indexOf('}\n}')` matched
+ nothing — two suites failed on a checkout with zero local changes, and one of them reported 25 theme
+ tokens missing that were all present. Normalize at the read
+ (`readFileSync(f, 'utf8').replace(/\r\n/g, '\n')`); `src/shared/line-endings.guard.test.ts` fails on
+ a read that slices a `\n`-bearing literal without it.
+
+**A test never touches a live tmux server.** You will most likely run `npm test` from inside a
+nodeterm terminal, where `-L node-terminal` and `-L nodeterm-rmt` are the servers holding every
+node you have open — one stray `kill-server` there ends your whole canvas, not your test. Every run
+therefore gets a private `TMUX_TMPDIR` (`test/setup/tmux-sandbox.ts`), which re-points every socket
+name at once. Write real-tmux suites the normal way — pick your own socket name, and use
+`makeTmuxTmpdir` if you also want your own directory — and do not build an `env` object for a real
+tmux without carrying `TMUX_TMPDIR` into it, which is the one way left to escape the sandbox.
+`src/core/tmux-socket-isolation.guard.test.ts` holds the short allowlist of suites that name a
+production socket on purpose; adding a third is a review conversation, not a checkbox.
+
## Pull requests
- Branch from `main`. CI runs `quality`, `CodeQL` and `Dependency review`; all three are required.