Skip to content

Node-based terminal manager for AI coding agents — tmux-backed terminals and parallel agent sessions as draggable nodes on an infinite pan/zoom canvas. macOS, Linux, and a browser Server Edition.

docs(pairing): state the unelevated revoke residual for administrators_authorized_keys

enesad59e99412b0
diff --git a/src/main/pairing-service.ts b/src/main/pairing-service.ts
index bdaa7f8fe..f81a2be4f 100644
--- a/src/main/pairing-service.ts
+++ b/src/main/pairing-service.ts
@@ -537,9 +537,14 @@ export function createPairingService(
*
* Rewritten IN PLACE, deliberately not temp + rename: the file's ACL must stay Administrators +
* SYSTEM only, and a temp file inherits the directory's ACL instead, which sshd then refuses —
- * breaking every other administrator key in it. An unreadable file (the normal case: only an
- * elevated process may read it) is skipped; a line that IS there but cannot be removed throws,
- * so the revoke reports `local: false` rather than a removal that did not happen.
+ * breaking every other administrator key in it. A line that IS there but cannot be removed
+ * throws, so the revoke reports `local: false` rather than a removal that did not happen.
+ *
+ * KNOWN RESIDUAL: an unreadable file is skipped, and unreadable is the NORMAL case — that ACL
+ * denies an unelevated process even a read. So an unelevated revoke cannot see a manually copied
+ * line and cannot say one exists; only an elevated nodeterm reaches it. Failing every unelevated
+ * revoke instead would make "Remove device" permanently impossible on any admin account with
+ * sshd installed, for a copy nodeterm never made.
*/
async function removeAdministratorsKeysForDevice(deviceId: string): Promise<void> {
if (platform !== 'win32') return
diff --git a/src/main/pairing-service.windows.test.ts b/src/main/pairing-service.windows.test.ts
index e9e321e12..6f1058759 100644
--- a/src/main/pairing-service.windows.test.ts
+++ b/src/main/pairing-service.windows.test.ts
@@ -255,6 +255,8 @@ describe('Windows revoke sweeps the administrators key file', () => {
expect(readFileSync(ADMIN_KEYS, 'utf8')).toBe(`${OTHER}\n${KEY_A}\n`)
})
+ // The unelevated case: that file's ACL denies even a read. Skipped (see the KNOWN RESIDUAL note on
+ // removeAdministratorsKeysForDevice) — a missing file stands in for an unreadable one here.
it('does not fail a revoke over a file it cannot read — the normal, unelevated case', async () => {
seed()
rmSync(ADMIN_KEYS)