Node-based terminal manager for AI coding agents — tmux-backed terminals and parallel agent sessions as draggable nodes on an infinite pan/zoom canvas. macOS, Linux, and a browser Server Edition.
TypeScript adhdagent-orchestrationai-agentscanvasclaude-codecodexcoding-agentsdeveloper-toolselectrongeminilinuxmacosmultiplexeropencodeparallel-agentsterminalterminal-emulatorterminal-multiplexertmuxworkspace-manager
build(deps): bump lucide-react to 1.48.0 with our own GitHub glyph
reviewe69fbf4f866a
diff --git a/package-lock.json b/package-lock.jsonindex a9f979487..31340c435 100644--- a/package-lock.json+++ b/package-lock.json@@ -17,7 +17,7 @@"dompurify": "^3.4.16","electron-updater": "^6.8.9","emoji-picker-react": "^4.22.2",- "lucide-react": "^0.545.0",+ "lucide-react": "^1.48.0","marked": "^12.0.2","monaco-editor": "^0.57.0","node-pty": "^1.0.0",@@ -6947,9 +6947,9 @@}},"node_modules/lucide-react": {- "version": "0.545.0",- "resolved": "https://registry.npmjs.org/lucide-react/-/lucide-react-0.545.0.tgz",- "integrity": "sha512-7r1/yUuflQDSt4f1bpn5ZAocyIxcTyVyBBChSVtBKn5M+392cPmI5YJMWOJKk/HUWGm5wg83chlAZtCcGbEZtw==",+ "version": "1.48.0",+ "resolved": "https://registry.npmjs.org/lucide-react/-/lucide-react-1.48.0.tgz",+ "integrity": "sha512-R0CIKY/fXiC6y9xRBADgsK+VW2p/pcTJOMhLZf1T+uG+vJUvyUR02nGOgmIIC7MPkiNK4Ox8QDnbqF8rJYWPZQ==","license": "ISC","peerDependencies": {"react": "^16.5.1 || ^17.0.0 || ^18.0.0 || ^19.0.0"diff --git a/package.json b/package.jsonindex 1e91d928e..5fa9609b9 100644--- a/package.json+++ b/package.json@@ -179,7 +179,7 @@"dompurify": "^3.4.16","electron-updater": "^6.8.9","emoji-picker-react": "^4.22.2",- "lucide-react": "^0.545.0",+ "lucide-react": "^1.48.0","marked": "^12.0.2","monaco-editor": "^0.57.0","node-pty": "^1.0.0",diff --git a/src/renderer/components/icons.tsx b/src/renderer/components/icons.tsxindex d65b5bfed..48467aa86 100644--- a/src/renderer/components/icons.tsx+++ b/src/renderer/components/icons.tsx@@ -509,3 +509,23 @@ export const IconRestoreSize = () => (<path d="M4 20l6-6" /></svg>)++/** GitHub mark, drawn in the same 24px/2px stroke grid as the lucide glyphs it sits beside (the+ * project-icon picker's Avatar tab). Ours because lucide-react 1.x removed its brand icons. */+export const IconGithub = ({ className }: { className?: string }) => (+ <svg+ width={24}+ height={24}+ viewBox="0 0 24 24"+ fill="none"+ stroke="currentColor"+ strokeWidth={2}+ strokeLinecap="round"+ strokeLinejoin="round"+ className={className}+ aria-hidden="true"+ >+ <path d="M15 22v-4a4.8 4.8 0 0 0-1-3.5c3 0 6-2 6-5.5.08-1.25-.27-2.48-1-3.5.28-1.15.28-2.35 0-3.5 0 0-1 0-3 1.5-2.64-.5-5.36-.5-8 0C6 2 5 2 5 2c-.3 1.15-.3 2.35 0 3.5A5.403 5.403 0 0 0 4 9c0 3.5 3 5.5 6 5.5-.39.49-.68 1.05-.85 1.65-.17.6-.22 1.23-.15 1.85v4" />+ <path d="M9 18c-4.51 2-5-2-7-2" />+ </svg>+)diff --git a/src/renderer/components/settings/ProjectIconPicker.test.tsx b/src/renderer/components/settings/ProjectIconPicker.test.tsxindex 0fee1818b..7d96e7c57 100644--- a/src/renderer/components/settings/ProjectIconPicker.test.tsx+++ b/src/renderer/components/settings/ProjectIconPicker.test.tsx@@ -235,6 +235,23 @@ describe('ProjectIconPicker', () => {})})+ // lucide-react 1.x dropped its brand icons, so a `Github` import resolves to undefined at runtime+ // and the whole picker throws on render. The glyph is our own now; pin that both uses paint it.+ it('draws the GitHub glyph on the Avatar tab and the "Use GitHub avatar" button', async () => {+ useAvatar(vi.fn(async () => ({ dataUrl: 'data:image/png;base64,AV==' })))+ await mount()+ await flush()+ const avatarTab = tab('Avatar')+ expect(avatarTab.querySelector('svg')?.getAttribute('class')).toBe('size-3.5')+ await click(avatarTab)+ const useBtn = [...host.querySelectorAll('button')].find(+ (b) => b.textContent === 'Use GitHub avatar'+ )!+ const svg = useBtn.querySelector('svg')!+ expect(svg.getAttribute('class')).toBe('size-4')+ expect(svg.querySelectorAll('path').length).toBe(2)+ })+it('keeps an already-set github icon when the resolve returns null (anti-clobber)', async () => {const projectAvatar = vi.fn(async () => null)useAvatar(projectAvatar)diff --git a/src/renderer/components/settings/ProjectIconPicker.tsx b/src/renderer/components/settings/ProjectIconPicker.tsxindex 0d9d3551c..46e5d2b22 100644--- a/src/renderer/components/settings/ProjectIconPicker.tsx+++ b/src/renderer/components/settings/ProjectIconPicker.tsx@@ -1,11 +1,12 @@-import { useEffect, useRef, useState } from 'react'-import { Github, Image as ImageIcon, RotateCcw, Shapes, Smile } from 'lucide-react'+import { useEffect, useRef, useState, type ComponentType } from 'react'+import { Image as ImageIcon, RotateCcw, Shapes, Smile } from 'lucide-react'import {LUCIDE_ICON_IDS,sanitizeProjectIcon,type ProjectIcon} from '@shared/project-icon'import { cn } from '@renderer/ui/cn'+import { IconGithub } from '../icons'import { ProjectGlyph } from '../ProjectGlyph'import EmojiPickerLazy from './EmojiPickerLazy'@@ -148,8 +149,13 @@ export function ProjectIconPicker({// (so a transient resolve failure never strands the user without the tab).const showAvatar = avatarAvailable || hasGithubIcon- const TABS: { id: Tab; label: string; icon: typeof Github; disabled?: boolean }[] = [- { id: 'avatar', label: 'Avatar', icon: Github, disabled: !showAvatar },+ const TABS: {+ id: Tab+ label: string+ icon: ComponentType<{ className?: string }>+ disabled?: boolean+ }[] = [+ { id: 'avatar', label: 'Avatar', icon: IconGithub, disabled: !showAvatar },{ id: 'emoji', label: 'Emoji', icon: Smile },{ id: 'lucide', label: 'Lucide', icon: Shapes },{ id: 'upload', label: 'Upload', icon: ImageIcon }@@ -262,7 +268,7 @@ export function ProjectIconPicker({className="flex w-full items-center justify-center gap-2 rounded-lg border border-transparent bg-[color:var(--accent)] px-3 py-2 text-[13px] font-medium text-white transition-opacity hover:opacity-90"onClick={() => void onUseGithubAvatar()}>- <Github className="size-4" />+ <IconGithub className="size-4" />Use GitHub avatar</button><p className="text-[12px] leading-relaxed text-muted">