Skip to content

armgit / nota

Public Imported from GitHub
0

Nota — a free DAW for macOS, Windows and Linux. No subscription, no account — just open it and make music.

(feat) Update release skill (#26)

Egor Khindikaynen02546f5b86c9
diff --git a/.claude/skills/release/SKILL.md b/.claude/skills/release/SKILL.md
index 5eef02fd..e39cdd13 100644
--- a/.claude/skills/release/SKILL.md
+++ b/.claude/skills/release/SKILL.md
@@ -1,6 +1,6 @@
---
name: release
-description: Cut a Nota release in three phases. `prepare` (on develop) promotes CHANGELOG.md [Unreleased] to a dated version, writes the curated EN + RU release notes in release-notes/ (the one source for the GitHub release and the news channels), bumps the app and engine versions, makes the release image and the PR text. `tag` (on main, after the user merged the develop → main PR) creates the vX.Y.Z tag. `verify` (after the user pushed the tag) waits for the build and checks the GitHub draft against the curated notes. Run this when the user asks to release, ship, cut a version, tag a release or check a release build.
+description: Cut a Nota release in three phases. `prepare` (on a release/X.Y.Z branch from develop) promotes CHANGELOG.md [Unreleased] to a dated version, writes the curated EN + RU release notes in release-notes/ (the one source for the GitHub release and the news channels), bumps the app and engine versions, makes the release image and the PR texts. `tag` (on main, after the user merged the release PR into develop and the develop → main PR) creates the vX.Y.Z tag. `verify` (after the user pushed the tag) waits for the build and checks the GitHub draft against the curated notes. Run this when the user asks to release, ship, cut a version, tag a release or check a release build.
user-invocable: true
---
@@ -26,17 +26,23 @@ The release runs through the branches like this. **The user does every commit, p
by hand.** This skill never commits, pushes or opens a PR (see the user-commits rule).
```
-develop ── /release prepare ── user commits, pushes, opens PR develop → main
-main ── user merges ── /release tag ── user pushes the tag
-CI ── release.yml builds 6 files + draft release ── /release verify ── user publishes
+release/X.Y.Z ── /release prepare ── user commits, pushes, opens PR → develop (squash)
+develop ── CI green, user merges ── user opens PR develop → main (merge commit)
+main ── CI green, user merges ── /release tag ── user pushes the tag
+CI ── release.yml builds 6 files + draft release ── /release verify ── user publishes
```
+`develop` and `main` are protected (rulesets): changes land only through a pull request
+with the `macOS`, `Windows` and `Linux` CI checks green; `develop` takes squash merges,
+`main` takes merge commits only, so `develop` → `main` never rewrites history. Release
+tags `v*` can be created only by maintainers.
+
**Argument** (`/release <phase> [bump]`): the phase is `prepare` (default), `tag` or
`verify`. For `prepare` the bump is `minor` or `patch` (see step P2).
---
-## Phase 1 — `prepare` (on `develop`)
+## Phase 1 — `prepare` (on a `release/X.Y.Z` branch from `develop`)
### P1. Preflight. Stop if any check fails
@@ -44,8 +50,11 @@ CI ── release.yml builds 6 files + draft release ── /release verify
2. The tree is clean (`git status --porcelain` is empty). Otherwise ask the user to commit
or stash first, so the release changes stay separate.
3. Up to date: `git fetch origin`, then `git rev-list --left-right --count origin/develop...HEAD`
- must show `0` behind.
+ must show `0` behind and `0` ahead (unpushed commits on `develop` can't reach it any
+ more except through a pull request).
4. `## [Unreleased]` has real entries.
+5. Once the version is chosen (P2), create the branch: `git switch -c release/X.Y.Z`. This is
+ the only branch operation the skill does itself; every later step edits files on it.
### P2. Choose the bump
@@ -148,12 +157,16 @@ Don't commit. Give the user:
- the version change (`app a → b`, `engine c → d`) and the list of changed files:
`CHANGELOG.md`, `VERSION`, `src/native/nota.engine/VERSION`, `FEATURES.md`,
`release-notes/X.Y.Z.{en,ru}.md`,
-- the commit message `(chore) Release X.Y.Z`,
-- the **PR text** for develop → main. Title `Release X.Y.Z`, body = the output of
- `scripts/release-notes.sh X.Y.Z github`, so the reviewer reads exactly what will be
- published,
+- the commit message `(chore) Release X.Y.Z` and the push command
+ `git push -u origin release/X.Y.Z`,
+- the **PR into develop**: title `(chore) Release X.Y.Z` (it becomes the squash commit
+ message), body = a short list of the changed files,
+- the **PR text** for develop → main, opened after the first one is merged. Title
+ `Release X.Y.Z`, body = the output of `scripts/release-notes.sh X.Y.Z github`, so the
+ reviewer reads exactly what will be published. Merge it with **Create a merge commit**
+ (the only method `main` allows),
- the image path and any docs gaps,
-- the next step: merge the PR, then run `/release tag`.
+- the next step: merge both PRs once CI is green, then run `/release tag`.
---
@@ -172,7 +185,8 @@ Don't commit. Give the user:
```
If the script fails, report its message as is. Common causes: the PR isn't merged yet, or
-local main is behind.
+local main is behind. After the tag, `develop` needs no sync: the merge commit on `main`
+already has `develop` as a parent.
---
diff --git a/.specify/bugs/export-restart-headless/test.md b/.specify/bugs/export-restart-headless/test.md
new file mode 100644
index 00000000..e5585b22
--- /dev/null
+++ b/.specify/bugs/export-restart-headless/test.md
@@ -0,0 +1,57 @@
+# Bug Verification: Export and freeze restart audio that was never running
+
+- **Slug**: export-restart-headless
+- **Tested**: 2026-10-14
+- **Assessment**: ./assessment.md
+- **Fix**: ./fix.md
+- **Result**: verified
+
+## Summary
+
+The original reproduction — the smoke test on GitHub's Linux and Windows runners, which have
+no audio output device — now runs to the end: export, stem export, bounce and freeze leave a
+never-started engine stopped and nothing throws. No regressions on any of the three
+platforms.
+
+## Checks Performed
+
+| Check | Command / Action | Result | Notes |
+|-------|------------------|--------|-------|
+| Reproduction (post-fix) | CI run [38556208783](https://github.com/nota-daw/nota/actions/runs/38556208783), `scripts/build-linux.sh` / `build-win.ps1` on `ubuntu-latest` / `windows-2022`, commit `a6374a7` | pass | the same headless runners that crashed in run 38546277984 |
+| New tests | 4 smoke checks "… leaves a backend that was never started stopped" (export, stems, bounce, freeze) | pass | on Linux, Windows and macOS in the run above |
+| Regression suite | full smoke test, all three CI jobs | pass | `SMOKE TEST PASSED` ×3 |
+| Regression suite (local) | `scripts/build.sh` on macOS after the merge | pass | `SMOKE TEST PASSED` |
+| Lint / type-check | design-token lint inside the smoke test; `dotnet build` in CI | pass | build has 0 errors; warning count not compared |
+
+## Output Excerpts
+
+```
+Linux [PASS] export leaves a backend that was never started stopped
+Linux [PASS] stem export leaves a backend that was never started stopped
+Linux [PASS] bounce leaves a backend that was never started stopped
+Linux [PASS] freeze leaves a backend that was never started stopped
+Linux SMOKE TEST PASSED
+Windows [PASS] export leaves a backend that was never started stopped (… same four)
+Windows SMOKE TEST PASSED
+macOS SMOKE TEST PASSED
+```
+
+Before the fix, the same Linux job logged `ALSA lib pcm.c:2721:(snd_pcm_open_noupdate)
+Unknown PCM default` and died with `NotaEngineException: AudioDevice` from
+`AudioExporter.Restore`. After it, no ALSA open attempt appears in the log: the engine no
+longer tries to start a device it never had.
+
+## Residual Risks
+
+- The other half of the behaviour — an engine that *was* running restarts after an export —
+ has no automated check (CI has no device; `--audiocheck` was not extended, see fix.md
+ Deviations). The code path for it is unchanged from before the fix.
+- A device that disappears while running and is gone when the export ends still throws from
+ `Restore`; that is intended (a real device error) and surfaced by the app's export UI.
+- `bg warp: plays identically to the synchronous rebuild` failed once locally during the fix
+ (unrelated, intermittent); it passed on all three CI jobs here.
+
+## Recommendation
+
+Close the bug — verified end-to-end on the environments where it reproduced. Track the
+intermittent `bg warp` check separately.