Skip to content

armgit / nota

Public Imported from GitHub
0

Nota — a free DAW for macOS, Windows and Linux. No subscription, no account — just open it and make music.

(fix) Plug-in search in Downloads no longer crashes

Egor Khindikaynen6151e5ccb36b
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 801b370a..f5c473cf 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -64,6 +64,8 @@ Entry categories: `Added`, `Changed`, `Fixed`, `Removed`.
The browser also opens wider by default.
### Fixed
+- **Plug-in search in Downloads no longer crashes:** typing a search that matched nothing
+ and then erasing it with Backspace threw an error instead of bringing the list back.
- **Long audio files no longer stall the app:** after dropping a long file (a multi-minute
FLAC, say) onto the arrangement, the app stuttered for as long as it took to time-stretch
the clip to the project tempo. Warping now runs in the background, so the app stays smooth
diff --git a/src/managed/Nota.App/PreferencesWindow.Store.cs b/src/managed/Nota.App/PreferencesWindow.Store.cs
index c22829a3..41840e21 100644
--- a/src/managed/Nota.App/PreferencesWindow.Store.cs
+++ b/src/managed/Nota.App/PreferencesWindow.Store.cs
@@ -259,12 +259,13 @@ public sealed partial class PreferencesWindow
}
if (available.Count == 0 && items[0] is StoreEntry first) items[0] = first with { First = true };
_storeItems.ItemsSource = items;
- if (_storeList.Content is not Border { Tag: "store-table" })
- _storeList.Content = new Border
- {
- Tag = "store-table", BorderBrush = Divider, BorderThickness = new Thickness(1), CornerRadius = NotaRadius.Panel,
- ClipToBounds = true, Child = _storeItems,
- };
+ // The rows keep their table border while the empty / loading stub stands in, so reuse
+ // it — wrapping _storeItems in a fresh one would throw "already has a parent".
+ _storeList.Content = _storeItems.Parent as Border ?? new Border
+ {
+ BorderBrush = Divider, BorderThickness = new Thickness(1), CornerRadius = NotaRadius.Panel,
+ ClipToBounds = true, Child = _storeItems,
+ };
}
private static bool MatchesFilter(StorePlugin p, int filter, IReadOnlyDictionary<string, InstalledStorePlugin> installed) => filter switch