Nota — a free DAW for macOS, Windows and Linux. No subscription, no account — just open it and make music.
C# audioaudio-unitavaloniacpp20cross-platformdawdigital-audio-workstationdspjucelinux-audiomcp-servermidimusicmusic-productionpiano-rollplugin-hostsequencersynthesizervstvst3
(fix) Smoke test runs on CI runners
Egor Khindikaynen6e9c8e03289d
diff --git a/tests/Nota.SmokeTest/DesignTokenCheck.cs b/tests/Nota.SmokeTest/DesignTokenCheck.csindex 2380a97e..cb207983 100644--- a/tests/Nota.SmokeTest/DesignTokenCheck.cs+++ b/tests/Nota.SmokeTest/DesignTokenCheck.cs@@ -140,7 +140,7 @@ internal static class DesignTokenCheck: $"geometry drift: {string.Join("; ", drift)}");// Every Radius/Control/Space key a style or view names must exist.- var used = Directory.EnumerateFiles(app, "*.*", SearchOption.AllDirectories)+ var used = Files(app, "*.*", SearchOption.AllDirectories).Where(f => (f.EndsWith(".cs") || f.EndsWith(".axaml")) && !f.Contains("/obj/") && !f.Contains("/bin/")).SelectMany(f => Regex.Matches(File.ReadAllText(f), @"(?:StaticResource |"")(?<key>(?:Radius|Control|Space)\.\w+)[}""]").Select(m => m.Groups["key"].Value))@@ -150,9 +150,9 @@ internal static class DesignTokenCheck: $"references to undefined geometry keys: {string.Join(", ", used)}");// The view layer stays literal-free, flat and shadowless.- var views = Directory.EnumerateFiles(app, "*.cs", SearchOption.AllDirectories)+ var views = Files(app, "*.cs", SearchOption.AllDirectories).Where(f => !f.Contains("/obj/") && !f.Contains("/bin/") && !f.Contains("/Theme/"))- .Select(f => (Path: Path.GetRelativePath(app, f), Text: File.ReadAllText(f))).ToArray();+ .Select(f => (Path: Rel(app, f), Text: File.ReadAllText(f))).ToArray();string[] Offenders(string pattern) => views.Where(v => Regex.IsMatch(v.Text, pattern)).Select(v => v.Path).OrderBy(p => p).ToArray();var radiusLiterals = Offenders(@"new CornerRadius\(\s*[0-9]");@@ -190,9 +190,9 @@ internal static class DesignTokenCheckfiles.Length == 0 ? "all eight Geist weights are bundled" : $"missing font files: {string.Join(", ", files)}");yield return (File.Exists(Path.Combine(root, "LICENSES/OFL-1.1-Geist.txt")), "the Geist OFL licence ships with the fonts");- var views = Directory.EnumerateFiles(app, "*.*", SearchOption.AllDirectories)+ var views = Files(app, "*.*", SearchOption.AllDirectories).Where(f => (f.EndsWith(".cs") || f.EndsWith(".axaml")) && !f.Contains("/obj/") && !f.Contains("/bin/") && !f.Contains("/Theme/"))- .Select(f => (Path: Path.GetRelativePath(app, f), Text: File.ReadAllText(f))).ToArray();+ .Select(f => (Path: Rel(app, f), Text: File.ReadAllText(f))).ToArray();// A family named by string resolves to whatever the OS has; FontFamily.Default// hides the choice. Both must go through NotaFonts.@@ -226,7 +226,7 @@ internal static class DesignTokenCheckconst string icons = "■□▶▷◀◁●○◆◇★☆✓✔✗✕✖✎❄☰⧉‹›▾▴▸◂▼▲⏵⏸⏹⏺⟳⊘─┄▩⠿+▤";var offenders = new List<string>();- foreach (var f in Directory.EnumerateFiles(app, "*.*", SearchOption.AllDirectories)+ foreach (var f in Files(app, "*.*", SearchOption.AllDirectories).Where(f => (f.EndsWith(".cs") || f.EndsWith(".axaml")) && !f.Contains("/obj/") && !f.Contains("/bin/"))){int n = 0;@@ -236,7 +236,7 @@ internal static class DesignTokenCheckvar code = f.EndsWith(".cs") ? line.Split("//")[0] : Regex.Replace(line, "<!--.*?-->", "");foreach (Match m in Regex.Matches(code, "\"((?:[^\"\\\\]|\\\\.)*)\""))if (m.Groups[1].Value.IndexOfAny(icons.ToCharArray()) >= 0)- offenders.Add($"{Path.GetRelativePath(app, f)}:{n}");+ offenders.Add($"{Rel(app, f)}:{n}");}}yield return (offenders.Count == 0,@@ -274,7 +274,7 @@ internal static class DesignTokenCheck("vowel-dropped parameter label", new("\"(FDBK|FEEDB|FB|ATK|DEC|SUS|REL|LVL|DET|SPR|QNT|PIT|TRANSP|AMT|VOL|POS|EMPH|RESON)\"")),};var hits = rules.ToDictionary(r => r.Name, _ => new List<string>());- foreach (var f in Directory.EnumerateFiles(app, "*.cs", SearchOption.AllDirectories)+ foreach (var f in Files(app, "*.cs", SearchOption.AllDirectories).Where(f => !f.Contains("/obj/") && !f.Contains("/bin/") && !f.EndsWith("NotaNum.cs"))){int n = 0;@@ -285,7 +285,7 @@ internal static class DesignTokenCheck// Only what reaches the screen: the string literals on the line.var literals = string.Join("\n", Regex.Matches(code, "\"((?:[^\"\\\\]|\\\\.)*)\"").Select(m => m.Value));foreach (var (name, re) in rules)- if (re.IsMatch(name.StartsWith("invariant") ? code : literals)) hits[name].Add($"{Path.GetRelativePath(app, f)}:{n}");+ if (re.IsMatch(name.StartsWith("invariant") ? code : literals)) hits[name].Add($"{Rel(app, f)}:{n}");}}foreach (var (name, _) in rules)@@ -299,8 +299,8 @@ internal static class DesignTokenCheckvar root = RepoRoot();if (root is null) { yield return (false, "repo root located"); yield break; }var app = Path.Combine(root, "src/managed/Nota.App");- var views = Directory.EnumerateFiles(Path.Combine(app, "Controls"), "*.cs")- .Select(f => (Path: Path.GetRelativePath(app, f), Text: File.ReadAllText(f))).ToArray();+ var views = Files(Path.Combine(app, "Controls"), "*.cs")+ .Select(f => (Path: Rel(app, f), Text: File.ReadAllText(f))).ToArray();// Deliberate exception: MixBar is a level strip, not a graph window.var exempt = new HashSet<string> { "Controls/MixBar.cs" };string[] Offenders(string pattern) => views.Where(v => !exempt.Contains(v.Path) && Regex.IsMatch(v.Text, pattern)).Select(v => v.Path).OrderBy(p => p).ToArray();@@ -320,7 +320,7 @@ internal static class DesignTokenCheckvar meter = File.ReadAllText(Path.Combine(app, "Controls/MeterBar.cs"));yield return (Regex.IsMatch(meter, @"ChannelW = 11, Step = 5"), "level meter channels are 11px with a 5px step");- var arr = string.Concat(Directory.EnumerateFiles(app, "ArrangementView*.cs").Select(File.ReadAllText));+ var arr = string.Concat(Files(app, "ArrangementView*.cs").Select(File.ReadAllText));yield return (!arr.Contains("PlayheadGlow") && Regex.IsMatch(arr, @"PlayheadPen = new Pen\(PlayheadBrush, 1\)"),"the arrangement playhead is a 1px brass line with no glow");}@@ -353,11 +353,11 @@ internal static class DesignTokenCheck("brush snapshotting a theme colour", new(@"new (?:[\w.]+\.)?SolidColorBrush\(\s*(?:NotaPalette\.\w+(?:\.Color)?\s*[,)]|[\w.]*TrackColor(?:ForIndex)?\(|NotaPalette\.(?:TrackColors|ReturnColors)\[)|static readonly (?:I?Solid\w*Brush|IBrush)(?:\[\])?\s+\w+\s*=\s*new (?:[\w.]+\.)?SolidColorBrush\((?!Color\.FromArgb\(0x[0-9A-Fa-f]{2}, 0x00, 0x00, 0x00\))|static readonly Color(?:\[\])?\s+\w+\s*=.*NotaPalette"), null),};var hits = rules.ToDictionary(r => r.Name, _ => new List<string>());- foreach (var f in Directory.EnumerateFiles(app, "*.*", SearchOption.AllDirectories)+ foreach (var f in Files(app, "*.*", SearchOption.AllDirectories).Where(f => (f.EndsWith(".cs") || f.EndsWith(".axaml")) && !f.Contains("/obj/") && !f.Contains("/bin/")&& !f.EndsWith("Theme/NotaPalette.cs") && !f.EndsWith("Theme/NotaTheme.axaml"))){- var rel = Path.GetRelativePath(app, f);+ var rel = Rel(app, f);int n = 0;foreach (var line in File.ReadLines(f)){@@ -386,7 +386,7 @@ internal static class DesignTokenCheck// Physical instruments keep their wider layouts. (Plug-ins are S 260 / L 700.)var exempt = new HashSet<string> { "GenericParamDeviceBody.cs", "GenericMidiBody.cs","BassInstrumentCard.cs", "PhysicalInstrumentCard.cs" };- var off = Directory.EnumerateFiles(Path.Combine(app, "DeviceCards"), "*.cs", SearchOption.AllDirectories)+ var off = Files(Path.Combine(app, "DeviceCards"), "*.cs", SearchOption.AllDirectories).Where(f => !exempt.Contains(Path.GetFileName(f))).SelectMany(f => Regex.Matches(File.ReadAllText(f), @"public double (?:Card)?Width => (?<w>[0-9]+);").Where(m => m.Groups["w"].Value != "700").Select(m => $"{Path.GetFileName(f)} ({m.Groups["w"].Value})"))@@ -426,6 +426,13 @@ internal static class DesignTokenCheckreturn hex;}+ // The rules match paths written with '/' ("/obj/", "Theme/NotaPalette.cs"); Windows+ // hands back '\', so every path is normalised on the way in.+ private static IEnumerable<string> Files(string dir, string pattern, SearchOption option = SearchOption.TopDirectoryOnly)+ => Directory.EnumerateFiles(dir, pattern, option).Select(f => f.Replace('\\', '/'));++ private static string Rel(string root, string path) => Path.GetRelativePath(root, path).Replace('\\', '/');+/// <summary>Walk up from the test binary until the solution file appears.</summary>private static string? RepoRoot(){diff --git a/tests/Nota.SmokeTest/KeysTests.cs b/tests/Nota.SmokeTest/KeysTests.csindex 7c391470..5c24ca62 100644--- a/tests/Nota.SmokeTest/KeysTests.cs+++ b/tests/Nota.SmokeTest/KeysTests.cs@@ -296,7 +296,7 @@ internal static class KeysTestsfor (int i = 0; i < blocks; i++) e.RenderOffline(blk, 128, Sr);sw.Stop();double budget = 128 * 1000.0 / Sr, avg = sw.Elapsed.TotalMilliseconds / blocks;- yield return (e.InstrumentVoiceCount(tr) == 64 && avg < budget * 0.5,+ yield return TimingBudget.Check(e.InstrumentVoiceCount(tr) == 64, avg < budget * 0.5,$"Nota Keys stress: 64 Clav voices + FX avg {avg:0.000} ms per 128-frame block (budget {budget:0.00} ms, {e.InstrumentVoiceCount(tr)} voices)");}}diff --git a/tests/Nota.SmokeTest/PaletteTests.cs b/tests/Nota.SmokeTest/PaletteTests.csindex 911b65e5..a4e9e853 100644--- a/tests/Nota.SmokeTest/PaletteTests.cs+++ b/tests/Nota.SmokeTest/PaletteTests.cs@@ -376,7 +376,7 @@ internal static class PaletteTestslong alloc = GC.GetAllocatedBytesForCurrentThread() - before;times.Sort();double median = times[times.Count / 2], worst = times[^1];- yield return (median <= 8, $"per keystroke on {index.Count:N0} items: median {median:0.0} ms, worst {worst:0.0} ms (budget 8 ms) · index built in {buildMs:0} ms");+ yield return TimingBudget.Check(true, median <= 8, $"per keystroke on {index.Count:N0} items: median {median:0.0} ms, worst {worst:0.0} ms (budget 8 ms) · index built in {buildMs:0} ms");yield return (alloc / typed.Length < 256 * 1024, $"…allocating {alloc / typed.Length / 1024} KB per keystroke (results only, nothing per item)");}}diff --git a/tests/Nota.SmokeTest/Program.cs b/tests/Nota.SmokeTest/Program.csindex 5a6d5c05..0927d091 100644--- a/tests/Nota.SmokeTest/Program.cs+++ b/tests/Nota.SmokeTest/Program.cs@@ -2457,7 +2457,8 @@ Console.WriteLine("-- Nota Pentad --");int active = se.InstrumentVoiceCount(ta);se.StopTransport();double budget = 128 / 44.1;- Check(active == 16 && totalMs / blocks < budget * 0.5, $"Nota Pentad stress: 16-voice unison ×4 OS avg {totalMs / blocks:0.000} ms, worst {worstMs:0.000} ms per 128-frame block (budget {budget:0.00} ms)");+ var (pentadOk, pentadLabel) = TimingBudget.Check(active == 16, totalMs / blocks < budget * 0.5, $"Nota Pentad stress: 16-voice unison ×4 OS avg {totalMs / blocks:0.000} ms, worst {worstMs:0.000} ms per 128-frame block (budget {budget:0.00} ms)");+ Check(pentadOk, pentadLabel);}// Automation: a plugin-param lane drives the cutoff during playback.@@ -2732,7 +2733,8 @@ Console.WriteLine("-- Nota Consort --");for (int i = 0; i < blocks; i++) se.RenderOffline(blk, 128);sw.Stop();double budget = 128 / 44.1, avg = sw.Elapsed.TotalMilliseconds / blocks;- Check(se.InstrumentVoiceCount(ta) == 16 && avg < budget * 0.5, $"Nota Consort stress: 16 voices ×4 OS avg {avg:0.000} ms per 128-frame block (budget {budget:0.00} ms)");+ var (consortOk, consortLabel) = TimingBudget.Check(se.InstrumentVoiceCount(ta) == 16, avg < budget * 0.5, $"Nota Consort stress: 16 voices ×4 OS avg {avg:0.000} ms per 128-frame block (budget {budget:0.00} ms)");+ Check(consortOk, consortLabel);se.StopTransport();}// Factory presets: every named param is a real Consort id, each applies in place and sounds.diff --git a/tests/Nota.SmokeTest/RemoteTests.cs b/tests/Nota.SmokeTest/RemoteTests.csindex 32f38798..ec79a282 100644--- a/tests/Nota.SmokeTest/RemoteTests.cs+++ b/tests/Nota.SmokeTest/RemoteTests.cs@@ -306,6 +306,13 @@ internal static class RemoteTests}return null;}+ // Polls a state change that sends no reply — not a fixed sleep, which a slow CI+ // runner outlasts.+ void WaitFor(Func<bool> done, int ms = 2000)+ {+ var until = DateTime.UtcNow.AddMilliseconds(ms);+ while (DateTime.UtcNow < until && !done()) { hub.Tick(); Thread.Sleep(20); }+ }Send(new { t = "hello", token = "nope", name = "x" });var denied = Wait("denied");@@ -404,11 +411,11 @@ internal static class RemoteTestsSend(new { t = "vol", id = inst, v = 0.5, ph = 2 });Send(new { t = "mute", id = inst, on = true });- Wait("none", 150);+ WaitFor(() => e.TryGetTrackInfo(0, out var t) && Math.Abs(t.Volume - 0.5f) < 1e-3 && t.Muted == 1 && host.Refreshes > 0);yield return (e.TryGetTrackInfo(0, out var t1) && Math.Abs(t1.Volume - 0.5f) < 1e-3 && t1.Muted == 1, "fader and mute from the phone reach the track");yield return (host.Refreshes > 0, "Nota redraws after a phone edit");Send(new { t = "play" });- Wait("none", 120);+ WaitFor(() => host.Plays == 1);yield return (host.Plays == 1, "transport goes through Nota's transport");diff --git a/tests/Nota.SmokeTest/TimingBudget.cs b/tests/Nota.SmokeTest/TimingBudget.csnew file mode 100644index 00000000..53162809--- /dev/null+++ b/tests/Nota.SmokeTest/TimingBudget.cs@@ -0,0 +1,21 @@+// SPDX-License-Identifier: AGPL-3.0-only+// Copyright (c) 2026 Egor Khindikaynen (Nota). See LICENSES/ for license terms.+//+// Wall-clock budgets (DSP stress, per-keystroke search) hold on a developer machine but+// not on shared CI runners, whose speed swings run to run. Under CI (the `CI` variable+// GitHub Actions sets) a missed budget is printed and not failed; the functional half of+// such a check — voice counts and the like — is enforced everywhere.++namespace Nota.SmokeTest;++internal static class TimingBudget+{+ private static readonly bool Lenient =+ Environment.GetEnvironmentVariable("CI") is { Length: > 0 } ci && ci != "false";++ public static (bool Ok, string Label) Check(bool functional, bool withinBudget, string label)+ {+ if (withinBudget || !functional) return (functional && withinBudget, label);+ return (Lenient, Lenient ? $"{label} — over budget, not enforced under CI" : label);+ }+}