Skip to content

armgit / nota

Public Imported from GitHub
0

Nota — a free DAW for macOS, Windows and Linux. No subscription, no account — just open it and make music.

(fix) Change shortcuts: cmd + a selects all clips, cmd + shift + a shows automation mode

Egor Khindikaynen77dc3b038062
diff --git a/CHANGELOG.md b/CHANGELOG.md
index d32521f8..0920b297 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -32,6 +32,7 @@ Entry categories: `Added`, `Changed`, `Fixed`, `Removed`.
## [Unreleased]
### Changed
+- ⌘A now selects all clips in the arrangement. Automation mode moved to ⌘⇧A.
- Nota Arp has a new look and two sizes: a full card and a small 260-pixel one. Switch
between them with S / L in the card's header. Both sizes share the same presets, and the
preset you pick stays selected when you switch size. The Pattern view shows the notes the arp
diff --git a/src/managed/Nota.App/ArrangementView.cs b/src/managed/Nota.App/ArrangementView.cs
index 202cf119..42b91358 100644
--- a/src/managed/Nota.App/ArrangementView.cs
+++ b/src/managed/Nota.App/ArrangementView.cs
@@ -1300,6 +1300,16 @@ public sealed partial class ArrangementView : UserControl
return any;
}
+ /// <summary>Cmd+A — select every clip in the arrangement. False when there are none,
+ /// so the key falls through.</summary>
+ public bool SelectAllClips()
+ {
+ var all = _tracks.SelectMany(t => t.Clips.Select(c => (t.Id, c.ClipIndex))).ToList();
+ if (all.Count == 0) return false;
+ SetSelection(all);
+ return true;
+ }
+
/// <summary>Replaces the selection with the given clips (marquee). Does not open
/// the detail panel — it only highlights; the primary becomes the first clip.</summary>
internal void SetSelection(IEnumerable<(int track, int clip)> clips)
diff --git a/src/managed/Nota.App/MainWindow.Input.cs b/src/managed/Nota.App/MainWindow.Input.cs
index 3dc3f789..5237e4a7 100644
--- a/src/managed/Nota.App/MainWindow.Input.cs
+++ b/src/managed/Nota.App/MainWindow.Input.cs
@@ -22,7 +22,7 @@ public partial class MainWindow
{
// Computer-keyboard piano mapping, classic typing-keyboard layout: the A-row is the
// white keys (A=C4=60 … K=C5) and the Q-row the black keys (W E T Y U). Z/X shift the
- // octave and C/V the velocity (see the handlers below); Automation mode moved to ⌘A.
+ // octave and C/V the velocity (see the handlers below); Automation mode moved to ⌘⇧A.
// These are BASE pitches at octave 0 — _typingOctave*12 is added when a note plays.
private static readonly Dictionary<Key, int> KeyToPitch = new()
{
@@ -105,15 +105,22 @@ public partial class MainWindow
return;
}
- // ⌘/⌃ + A: toggle Automation mode. Moved off plain 'A' (now a piano key) — gated to
- // when the piano-roll grid isn't focused, where ⌘A instead selects all notes.
- if (mod && e.Key == Key.A && (e.KeyModifiers & (KeyModifiers.Alt | KeyModifiers.Shift)) == 0
- && _editorRoll is not { GridFocused: true })
+ // ⌘/⌃ + ⇧ + A: toggle Automation mode. ⌘/⌃ + A: select all arrangement clips —
+ // gated to when the piano-roll grid isn't focused, where ⌘A instead selects all notes.
+ if (mod && e.Key == Key.A && (e.KeyModifiers & KeyModifiers.Alt) == 0)
{
- AutomationToggle.IsChecked = !(AutomationToggle.IsChecked == true);
- OnToggleAutomation(AutomationToggle, new RoutedEventArgs());
- e.Handled = true;
- return;
+ if ((e.KeyModifiers & KeyModifiers.Shift) != 0)
+ {
+ AutomationToggle.IsChecked = !(AutomationToggle.IsChecked == true);
+ OnToggleAutomation(AutomationToggle, new RoutedEventArgs());
+ e.Handled = true;
+ return;
+ }
+ if (_editorRoll is not { GridFocused: true } && Timeline.SelectAllClips())
+ {
+ e.Handled = true;
+ return;
+ }
}
bool plainMod = mod && (e.KeyModifiers & (KeyModifiers.Alt | KeyModifiers.Shift)) == 0;
if (plainMod && e.Key == Key.R && _heldKeys.Add(e.Key))
diff --git a/src/managed/Nota.App/MainWindow.axaml b/src/managed/Nota.App/MainWindow.axaml
index c0fb27ac..213bd20d 100644
--- a/src/managed/Nota.App/MainWindow.axaml
+++ b/src/managed/Nota.App/MainWindow.axaml
@@ -265,7 +265,7 @@
</ToggleButton>
<!-- Automation: a breakpoint envelope — the ramp and handles the lanes draw -->
<ToggleButton x:Name="AutomationToggle" Classes="tp-icon" Click="OnToggleAutomation"
- ToolTip.Tip="Show parameter-automation lanes (⌘A)">
+ ToolTip.Tip="Show parameter-automation lanes (⌘⇧A)">
<Viewbox Width="15" Height="15">
<Canvas Width="24" Height="24">
<Path Stroke="{Binding $parent[ToggleButton].Foreground}" StrokeThickness="1.8"
diff --git a/src/managed/Nota.App/PreferencesWindow.cs b/src/managed/Nota.App/PreferencesWindow.cs
index 1433668c..a2cf587f 100644
--- a/src/managed/Nota.App/PreferencesWindow.cs
+++ b/src/managed/Nota.App/PreferencesWindow.cs
@@ -655,7 +655,8 @@ public sealed class PreferencesWindow : NotaWindow
("ARRANGEMENT & EDITING", new[]
{
("⌘Z ⌘⇧Z", "Undo / redo"),
- ("⌘A", "Toggle automation mode"),
+ ("⌘A", "Select all clips"),
+ ("⌘⇧A", "Toggle automation mode"),
("⌘⇧M", "Toggle the Mixer view"),
("Tab", "Cycle Devices / Pattern / Clip in the detail panel"),
("Esc", "Cancel the current gesture / clear the selection · close the patch-bay overlay"),