Skip to content

A fully open source & end-to-end encrypted note taking alternative to Evernote.

editor: fix pasting a word inside a list adds newlines around it (#3843)

Muhammad Ali15a32ac83a90
diff --git a/packages/editor/src/extensions/clipboard/clipboard.ts b/packages/editor/src/extensions/clipboard/clipboard.ts
index 1ca9319fb..ee1d422fa 100644
--- a/packages/editor/src/extensions/clipboard/clipboard.ts
+++ b/packages/editor/src/extensions/clipboard/clipboard.ts
@@ -25,6 +25,7 @@ import { ClipboardDOMParser } from "./clipboard-dom-parser";
import { ClipboardDOMSerializer } from "./clipboard-dom-serializer";
import { clipboardTextParser } from "./clipboard-text-parser";
import { clipboardTextSerializer } from "./clipboard-text-serializer";
+import { EditorView } from "prosemirror-view";
declare module "@tiptap/core" {
interface Commands<ReturnType> {
@@ -76,7 +77,7 @@ export const Clipboard = Extension.create({
}
});
-export function transformCopied(slice: Slice): any {
+export function transformCopied(slice: Slice, view: EditorView): any {
// when copying a single list item, we shouldn't retain the
// list formatting but copy it as a paragraph.
const maybeList = slice.content.firstChild;
@@ -86,7 +87,11 @@ export function transformCopied(slice: Slice): any {
maybeList.childCount === 1 &&
maybeList.firstChild
) {
- return transformCopied(new Slice(maybeList.firstChild.content, 0, 0));
+ return transformCopied(
+ new Slice(maybeList.firstChild.content, slice.openStart, slice.openEnd),
+ view
+ );
}
+
return slice;
}
diff --git a/packages/editor/src/extensions/clipboard/tests/__snapshots__/clipboard-text-serializer.test.ts.snap b/packages/editor/src/extensions/clipboard/tests/__snapshots__/clipboard-text-serializer.test.ts.snap
index 9ea6f8c48..d2668ac05 100644
--- a/packages/editor/src/extensions/clipboard/tests/__snapshots__/clipboard-text-serializer.test.ts.snap
+++ b/packages/editor/src/extensions/clipboard/tests/__snapshots__/clipboard-text-serializer.test.ts.snap
@@ -29,5 +29,6 @@ exports[`copying a single nested list item shouldn't copy the list metadata 1`]
"type": "paragraph",
},
],
+ "openStart": 5,
}
`;