Skip to content

A fully open source & end-to-end encrypted note taking alternative to Evernote.

editor: revoke blob urls on image unmount

Abdullah Atta2074320583ff
diff --git a/packages/editor/src/extensions/image/component.tsx b/packages/editor/src/extensions/image/component.tsx
index 3dee84e7c..86d665e4f 100644
--- a/packages/editor/src/extensions/image/component.tsx
+++ b/packages/editor/src/extensions/image/component.tsx
@@ -34,6 +34,7 @@ import { Resizer } from "../../components/resizer";
import {
corsify,
downloadImage,
+ revokeBloburl,
toBlobURL,
toDataURL
} from "../../utils/downloader";
@@ -86,6 +87,13 @@ export function ImageComponent(
})();
}, [inView]);
+ useEffect(() => {
+ return () => {
+ if (!hash) return;
+ revokeBloburl(hash);
+ };
+ }, []);
+
return (
<>
<Box
diff --git a/packages/editor/src/utils/downloader.ts b/packages/editor/src/utils/downloader.ts
index 2d6b6fc4f..cfd307e11 100644
--- a/packages/editor/src/utils/downloader.ts
+++ b/packages/editor/src/utils/downloader.ts
@@ -144,3 +144,11 @@ export function toBlobURL(
if (id) OBJECT_URL_CACHE[id] = objectURL;
return objectURL;
}
+
+export function revokeBloburl(id: string) {
+ const url = OBJECT_URL_CACHE[id];
+ if (!url) return;
+
+ URL.revokeObjectURL(url);
+ OBJECT_URL_CACHE[id] = undefined;
+}