Skip to content

A fully open source & end-to-end encrypted note taking alternative to Evernote.

editor: hide hover popup if right click occurs before popup is shown (#7687)

01zulfi303282624e07
diff --git a/packages/editor/src/toolbar/floating-menus/hover-popup/index.tsx b/packages/editor/src/toolbar/floating-menus/hover-popup/index.tsx
index b17a8aa06..936c16154 100644
--- a/packages/editor/src/toolbar/floating-menus/hover-popup/index.tsx
+++ b/packages/editor/src/toolbar/floating-menus/hover-popup/index.tsx
@@ -49,6 +49,16 @@ export function HoverPopupHandler(props: FloatingMenuProps) {
useEffect(
() => {
+ function onContextMenu(e: MouseEvent) {
+ if (
+ !e.target ||
+ !(e.target instanceof HTMLElement) ||
+ e.target.classList.contains("ProseMirror")
+ )
+ return;
+
+ clearTimeout(hoverTimeoutId.current);
+ }
function onMouseOver(e: MouseEvent) {
if (
!e.target ||
@@ -126,8 +136,10 @@ export function HoverPopupHandler(props: FloatingMenuProps) {
);
}
window.addEventListener("mouseover", onMouseOver);
+ window.addEventListener("contextmenu", onContextMenu);
return () => {
window.removeEventListener("mouseover", onMouseOver);
+ window.removeEventListener("contextmenu", onContextMenu);
};
},
// eslint-disable-next-line react-hooks/exhaustive-deps