Skip to content

A fully open source & end-to-end encrypted note taking alternative to Evernote.

web: fix attachment delete dialog not rendering any buttons

Abdullah Atta38ca451d7e15
diff --git a/apps/web/src/common/multi-select.ts b/apps/web/src/common/multi-select.ts
index c191644aa..d67b429cc 100644
--- a/apps/web/src/common/multi-select.ts
+++ b/apps/web/src/common/multi-select.ts
@@ -82,7 +82,9 @@ async function deleteAttachments(ids: string[]) {
!(await confirm({
title: "Are you sure?",
message:
- "Are you sure you want to permanently delete these attachments? This action is IRREVERSIBLE."
+ "Are you sure you want to permanently delete these attachments? This action is IRREVERSIBLE.",
+ negativeButtonText: "No",
+ positiveButtonText: "Yes"
}))
)
return;
diff --git a/apps/web/src/stores/attachment-store.ts b/apps/web/src/stores/attachment-store.ts
index 67758a12c..b83b7befb 100644
--- a/apps/web/src/stores/attachment-store.ts
+++ b/apps/web/src/stores/attachment-store.ts
@@ -141,7 +141,6 @@ class AttachmentStore extends BaseStore<AttachmentStore> {
this._changeWorkingStatus(attachment.hash);
if (e instanceof Error)
showToast("error", `Failed to delete: ${e.message}`);
- throw e;
}
};