Skip to content

A fully open source & end-to-end encrypted note taking alternative to Evernote.

editor: render interactive popups in popup instead of menu

Abdullah Atta44827d13fedd
diff --git a/packages/editor/src/extensions/code-block/component.tsx b/packages/editor/src/extensions/code-block/component.tsx
index 7d1839377..8b86249d6 100644
--- a/packages/editor/src/extensions/code-block/component.tsx
+++ b/packages/editor/src/extensions/code-block/component.tsx
@@ -193,7 +193,7 @@ export function CodeblockComponent(
}}
focusOnRender={false}
mobile="sheet"
- desktop="menu"
+ desktop="popup"
position={{
target: toolbarRef.current || undefined,
align: "end",
diff --git a/packages/editor/src/toolbar/tools/embed.tsx b/packages/editor/src/toolbar/tools/embed.tsx
index c584af92e..dad85b730 100644
--- a/packages/editor/src/toolbar/tools/embed.tsx
+++ b/packages/editor/src/toolbar/tools/embed.tsx
@@ -107,7 +107,7 @@ export function EmbedProperties(props: ToolProps) {
<ResponsivePresenter
isOpen={isOpen}
- desktop="menu"
+ desktop="popup"
mobile="sheet"
onClose={() => setIsOpen(false)}
blocking
diff --git a/packages/editor/src/toolbar/tools/image.tsx b/packages/editor/src/toolbar/tools/image.tsx
index 151cf30a9..b8b4e0d3f 100644
--- a/packages/editor/src/toolbar/tools/image.tsx
+++ b/packages/editor/src/toolbar/tools/image.tsx
@@ -142,7 +142,7 @@ export function ImageProperties(props: ToolProps) {
<ResponsivePresenter
isOpen={isOpen}
- desktop="menu"
+ desktop="popup"
mobile="sheet"
onClose={() => setIsOpen(false)}
blocking
diff --git a/packages/editor/src/toolbar/tools/link.tsx b/packages/editor/src/toolbar/tools/link.tsx
index 0f3a55984..72dbd8205 100644
--- a/packages/editor/src/toolbar/tools/link.tsx
+++ b/packages/editor/src/toolbar/tools/link.tsx
@@ -268,7 +268,7 @@ function LinkTool(props: LinkToolProps) {
/>
<ResponsivePresenter
mobile="sheet"
- desktop="menu"
+ desktop="popup"
position={{
target: buttonRef.current || undefined,
isTargetAbsolute: true,