Skip to content

A fully open source & end-to-end encrypted note taking alternative to Evernote.

web: fix tabs are not clickable everywhere

Abdullah Atta5430966b0292
diff --git a/7421.patch b/7421.patch
new file mode 100644
index 000000000..b6854c485
--- /dev/null
+++ b/7421.patch
@@ -0,0 +1,37 @@
+From af88ee05e1620afb65c76148d347cb7efc32bded Mon Sep 17 00:00:00 2001
+From: 01zulfi <[email protected]>
+Date: Wed, 29 Jan 2025 12:22:32 +0500
+Subject: [PATCH] editor: fix hover styling in toolbar color buttons
+ Signed-off-by: 01zulfi <[email protected]>
+
+---
+ packages/editor/src/toolbar/popups/color-picker.tsx | 2 +-
+ packages/editor/src/toolbar/tools/colors.tsx | 2 +-
+ 2 files changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/packages/editor/src/toolbar/popups/color-picker.tsx b/packages/editor/src/toolbar/popups/color-picker.tsx
+index 0abca19268..34209bd550 100644
+--- a/packages/editor/src/toolbar/popups/color-picker.tsx
++++ b/packages/editor/src/toolbar/popups/color-picker.tsx
+@@ -284,7 +284,7 @@ function PaletteButton(props: PaletteButtonProps) {
+ ml: [2, 2, 1],
+ bg,
+ ":hover:not(:disabled):not(:active)": {
+- bg: bg?.startsWith("#") ? colord(bg).darken(5).toRgbString() : "hover"
++ bg: bg?.startsWith("#") ? colord(bg).darken().toRgbString() : "hover"
+ },
+ ...sx
+ }}
+diff --git a/packages/editor/src/toolbar/tools/colors.tsx b/packages/editor/src/toolbar/tools/colors.tsx
+index 08c6b41d8a..77ea660e75 100644
+--- a/packages/editor/src/toolbar/tools/colors.tsx
++++ b/packages/editor/src/toolbar/tools/colors.tsx
+@@ -137,7 +137,7 @@ export function ColorTool(props: ColorToolProps) {
+ mr: 0,
+ bg: activeColor || "transparent",
+ ":hover:not(:disabled):not(:active)": {
+- bg: tColor ? tColor.darken(5).toRgbString() : "transparent"
++ bg: tColor ? tColor.darken().toRgbString() : "transparent"
+ }
+ }}
+ onOpen={toggle}
diff --git a/apps/web/src/components/editor/action-bar.tsx b/apps/web/src/components/editor/action-bar.tsx
index db5e5eb15..fd07aa328 100644
--- a/apps/web/src/components/editor/action-bar.tsx
+++ b/apps/web/src/components/editor/action-bar.tsx
@@ -573,14 +573,11 @@ function Tab(props: TabProps) {
onAuxClick={(e) => {
if (e.button == 1) onClose();
}}
+ onClick={() => onFocus()}
{...listeners}
{...attributes}
>
- <Flex
- onMouseUp={(e) => {
- if (e.button == 0) onFocus();
- }}
- >
+ <Flex>
<Icon
data-test-id={`tab-icon${isUnsaved ? "-unsaved" : ""}`}
size={14}