Skip to content

A fully open source & end-to-end encrypted note taking alternative to Evernote.

desktop: fix error 153 in youtube embeds (#9510)

Abdullah Atta558beaf216a4
diff --git a/apps/desktop/src/utils/protocol.ts b/apps/desktop/src/utils/protocol.ts
index 243798b22..00dafd37a 100644
--- a/apps/desktop/src/utils/protocol.ts
+++ b/apps/desktop/src/utils/protocol.ts
@@ -62,7 +62,17 @@ function registerProtocol() {
headers: { "Content-Type": extensionToMimeType[fileExtension] }
});
} else {
- return net.fetch(request, { bypassCustomProtocolHandlers: true });
+ const requestHeaders = new Headers(request.headers);
+ if (!requestHeaders.has("referer"))
+ requestHeaders.set("referer", PROTOCOL_URL);
+ return await net.fetch(
+ new Request(request, {
+ headers: requestHeaders
+ }),
+ {
+ bypassCustomProtocolHandlers: true
+ }
+ );
}
});
console.info(`${SCHEME} protocol inteception "successful"`);
diff --git a/packages/editor/package-lock.json b/packages/editor/package-lock.json
index 6383ab837..5fd7f5df0 100644
--- a/packages/editor/package-lock.json
+++ b/packages/editor/package-lock.json
@@ -15,7 +15,7 @@
"@notesnook/intl": "file:../intl",
"@notesnook/theme": "file:../theme",
"@notesnook/ui": "file:../ui",
- "@social-embed/lib": "^0.1.0-next.7",
+ "@social-embed/lib": "^0.1.0-next.11",
"@tiptap/core": "2.6.6",
"@tiptap/extension-blockquote": "^2.6.6",
"@tiptap/extension-bullet-list": "^2.6.6",
@@ -1326,9 +1326,10 @@
]
},
"node_modules/@social-embed/lib": {
- "version": "0.1.0-next.7",
- "resolved": "https://registry.npmjs.org/@social-embed/lib/-/lib-0.1.0-next.7.tgz",
- "integrity": "sha512-aasU+EoZpWaoGkFgKrYgUWGIo6h98YjN2L5kwSJrbCLCGE8lucnwzxFTDRAlW0yHs4JUz3C4Dct0U7jS8cQy4A==",
+ "version": "0.1.0-next.11",
+ "resolved": "https://registry.npmjs.org/@social-embed/lib/-/lib-0.1.0-next.11.tgz",
+ "integrity": "sha512-tT56VJkIbMVkkSm6+6drbhcCvTdLZTgWmj0SJ7k3UoDxxyrlkrwux8C+afjx5PKmTC2oqHznMUjgYFMjAfs3tw==",
+ "license": "MIT",
"engines": {
"node": ">=18"
}
diff --git a/packages/editor/package.json b/packages/editor/package.json
index 6290bfafe..75fcf0b28 100644
--- a/packages/editor/package.json
+++ b/packages/editor/package.json
@@ -35,7 +35,7 @@
"@notesnook/intl": "file:../intl",
"@notesnook/theme": "file:../theme",
"@notesnook/ui": "file:../ui",
- "@social-embed/lib": "^0.1.0-next.7",
+ "@social-embed/lib": "^0.1.0-next.11",
"@tiptap/core": "2.6.6",
"@tiptap/extension-blockquote": "^2.6.6",
"@tiptap/extension-bullet-list": "^2.6.6",
diff --git a/packages/editor/src/extensions/embed/component.tsx b/packages/editor/src/extensions/embed/component.tsx
index 5ba09e1d6..30f4be629 100644
--- a/packages/editor/src/extensions/embed/component.tsx
+++ b/packages/editor/src/extensions/embed/component.tsx
@@ -136,6 +136,9 @@ export function EmbedComponent(
})}
width={"100%"}
height={"100%"}
+ allow={getIframeAllowPermissions(src)}
+ allowFullScreen
+ referrerPolicy={isYouTubeEmbed(src) ? "origin" : undefined}
sandbox={getSandboxFeatures(src)}
onLoad={() => setIsLoading(false)}
/>
@@ -188,6 +191,19 @@ function isTwitterX(src: string) {
}
}
+function getIframeAllowPermissions(src: string) {
+ if (!isYouTubeEmbed(src)) return undefined;
+ return [
+ "accelerometer",
+ "autoplay",
+ "clipboard-write",
+ "encrypted-media",
+ "gyroscope",
+ "picture-in-picture",
+ "web-share"
+ ].join("; ");
+}
+
function tweetToEmbed(src: string, isDarkTheme: boolean) {
src = src.replaceAll("x.com", "twitter.com");