Skip to content

A fully open source & end-to-end encrypted note taking alternative to Evernote.

mobile: fix shortcuts not updating

Ammar Ahmed5633d4504f13
diff --git a/apps/mobile/app/components/list/reorderable-list.tsx b/apps/mobile/app/components/list/reorderable-list.tsx
index 6ff77e5e2..6658e072e 100644
--- a/apps/mobile/app/components/list/reorderable-list.tsx
+++ b/apps/mobile/app/components/list/reorderable-list.tsx
@@ -131,7 +131,7 @@ function ReorderableList<T extends { id: string }>({
]
);
- function getOrderedItems() {
+ const getOrderedItems = React.useCallback(() => {
if (!customizableSidebarFeature?.isAllowed) return data;
const items: T[] = [];
itemOrderState.forEach((id) => {
@@ -142,7 +142,7 @@ function ReorderableList<T extends { id: string }>({
items.push(...data.filter((i) => !itemOrderState.includes(i.id)));
return items;
- }
+ }, [data, customizableSidebarFeature?.isAllowed]);
return (
<View style={styles.container}>
diff --git a/apps/mobile/app/components/side-menu/menu-item.tsx b/apps/mobile/app/components/side-menu/menu-item.tsx
index 3df1de275..da56da1e6 100644
--- a/apps/mobile/app/components/side-menu/menu-item.tsx
+++ b/apps/mobile/app/components/side-menu/menu-item.tsx
@@ -37,7 +37,7 @@ import { Pressable } from "../ui/pressable";
import Paragraph from "../ui/typography/paragraph";
import { useSideBarDraggingStore } from "./dragging-store";
-function _MenuItem({
+export function MenuItem({
item,
index,
testID,
@@ -179,12 +179,3 @@ function _MenuItem({
</Pressable>
);
}
-
-export const MenuItem = React.memo(_MenuItem, (prev, next) => {
- if (
- prev.item.id !== next.item.id &&
- prev.item.data?.dateModified !== next.item.data?.dateModified
- )
- return false;
- return true;
-});