Skip to content

A fully open source & end-to-end encrypted note taking alternative to Evernote.

editor: fix subtasks getting unchecked on drag/drop reorder (#4135)

Muhammad Ali76a4d5c2a553
diff --git a/packages/editor/src/extensions/task-list/task-list.ts b/packages/editor/src/extensions/task-list/task-list.ts
index 935a3efca..6b7516e93 100644
--- a/packages/editor/src/extensions/task-list/task-list.ts
+++ b/packages/editor/src/extensions/task-list/task-list.ts
@@ -268,12 +268,14 @@ export const TaskListNode = TaskList.extend({
// Case # 1
// if the user clicks on a task item that has children, we
// should automatically check/uncheck all its children
+ // const oldTaskList = oldState.doc.nodeAt(edit.pos);
+ // const newTaskList = newState.doc.nodeAt(edit.pos);
if (
// when a task item has children, the task list is always the
// last child
edit.node.lastChild?.type.name === TaskList.name &&
- oldState.doc.nodeAt(edit.pos)?.attrs.checked !==
- newState.doc.nodeAt(edit.pos)?.attrs.checked
+ !!oldState.doc.nodeAt(edit.pos)?.attrs.checked !==
+ !!newState.doc.nodeAt(edit.pos)?.attrs.checked
) {
changeCount += toggleChildren(
tr,