Skip to content

A fully open source & end-to-end encrypted note taking alternative to Evernote.

web: fix faulty useEffect Signed-off-by: 01zulfi <[email protected]>

01zulfi7abf19071d33
diff --git a/apps/web/src/app.tsx b/apps/web/src/app.tsx
index 0250e3372..15fc41c39 100644
--- a/apps/web/src/app.tsx
+++ b/apps/web/src/app.tsx
@@ -154,8 +154,16 @@ function DesktopAppContents({ show, setShow }: DesktopAppContentsProps) {
const [isSideMenuOpen, setIsSideMenuOpen] = useState(false);
useEffect(() => {
- AppEventManager.subscribe(AppEvents.toggleSideMenu, setIsSideMenuOpen);
- });
+ const { unsubscribe } = AppEventManager.subscribe(
+ AppEvents.toggleSideMenu,
+ (state) => {
+ setIsSideMenuOpen(Boolean(state));
+ }
+ );
+ return () => {
+ unsubscribe();
+ };
+ }, []);
useEffect(() => {
if (isTablet) navPane.current?.collapse(0);
@@ -193,7 +201,10 @@ function DesktopAppContents({ show, setShow }: DesktopAppContentsProps) {
background: "rgba(0,0,0,0.5)"
}}
onClick={() => {
- AppEventManager.publish(AppEvents.toggleSideMenu);
+ AppEventManager.publish(
+ AppEvents.toggleSideMenu,
+ !isSideMenuOpen
+ );
}}
/>
<Flex sx={{ width: 300 }}>