Skip to content

A fully open source & end-to-end encrypted note taking alternative to Evernote.

web: hide monograph list for not logged in users (#8258)

01zulfi87cea6a12038
diff --git a/apps/web/__e2e__/monographs.test.ts b/apps/web/__e2e__/monographs.test.ts
new file mode 100644
index 000000000..249bb9caf
--- /dev/null
+++ b/apps/web/__e2e__/monographs.test.ts
@@ -0,0 +1,40 @@
+/*
+This file is part of the Notesnook project (https://notesnook.com/)
+
+Copyright (C) 2023 Streetwriters (Private) Limited
+
+This program is free software: you can redistribute it and/or modify
+it under the terms of the GNU General Public License as published by
+the Free Software Foundation, either version 3 of the License, or
+(at your option) any later version.
+
+This program is distributed in the hope that it will be useful,
+but WITHOUT ANY WARRANTY; without even the implied warranty of
+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+GNU General Public License for more details.
+
+You should have received a copy of the GNU General Public License
+along with this program. If not, see <http://www.gnu.org/licenses/>.
+*/
+
+import { test, expect } from "@playwright/test";
+import { AppModel } from "./models/app.model";
+import { USER } from "./utils";
+
+test("don't show monographs list to unauthenticated user", async ({ page }) => {
+ const app = new AppModel(page);
+ await app.goto();
+
+ await expect(
+ async () => await app.navigateTo("Monographs")
+ ).rejects.toThrowError();
+});
+
+test("show monographs list to authenticated user", async ({ page }) => {
+ const app = new AppModel(page);
+ await app.auth.goto();
+
+ await app.auth.login(USER.CURRENT);
+
+ await app.navigateTo("Monographs");
+});
diff --git a/apps/web/src/components/navigation-menu/index.tsx b/apps/web/src/components/navigation-menu/index.tsx
index 63bfc41d0..f38e1131c 100644
--- a/apps/web/src/components/navigation-menu/index.tsx
+++ b/apps/web/src/components/navigation-menu/index.tsx
@@ -113,6 +113,7 @@ type Route = {
path: string;
icon: Icon;
tag?: string;
+ loginRequired?: boolean;
};
const routes: Route[] = [
@@ -133,7 +134,8 @@ const routes: Route[] = [
id: "monographs",
title: strings.routes.Monographs(),
path: "/monographs",
- icon: Monographs
+ icon: Monographs,
+ loginRequired: true
},
{ id: "trash", title: strings.routes.Trash(), path: "/trash", icon: Trash },
{
@@ -449,9 +451,12 @@ function Routes({
collapse: () => void;
}) {
const hiddenRoutes = useAppStore((store) => store.hiddenRoutes);
+ const isLoggedIn = useUserStore((store) => store.isLoggedIn);
return (
<ReorderableList
- items={routes.filter((r) => !hiddenRoutes.includes(r.id))}
+ items={routes
+ .filter((r) => !hiddenRoutes.includes(r.id))
+ .filter((r) => (r.loginRequired ? isLoggedIn : true))}
orderKey={`sidebarOrder:routes`}
order={() => db.settings.getSideBarOrder("routes")}
onOrderChanged={(order) => db.settings.setSideBarOrder("routes", order)}